Want to shorten my scripts

jalrock

Can all of this be turned into a pre-defined function and called as needed?

//////////// GET TT&L ////////////////////
    $sql = "SELECT * FROM ttl";
    $result = mysql_query($sql);
    $myrow = mysql_fetch_array($result);
    $tax= $myrow["tax"];
    $vit = $myrow["vit"];
    $doc = $myrow["doc"];
    $registration = $myrow["registration"];
    $title = $myrow["title"];
$taxamount = $tradediff*$tax;
$cashprice = $saleprice-$rebate;
$vitamount = $cashprice*$vit;
$amountfinanced = $cashprice+$taxamount+$vitamount+$doc+$title+$registration;
//////////// GET TT&L ////////////////////

if so can you show me how. The idea is to have a functions.php that I can include in php pages so I do not have to keep putting the entire thing in each page.

Any help appreciated.

drawmack

//////////// GET TT&L ////////////////////
function get_ttl() {
   $retVal = array();
    $sql = "SELECT * FROM ttl";
    $result = mysql_query($sql);
    $myrow = mysql_fetch_array($result);
    $retVal['tax']= $myrow["tax"];
    $retVal['vit'] = $myrow["vit"];
    $retVal['doc'] = $myrow["doc"];
    $retVal['registration'] = $myrow["registration"];
    $retVal['title'] = $myrow["title"];
    $retVal['taxamount'] = $tradediff*$tax;
    $retVal['cashprice'] = $saleprice-$rebate;
    $retVal['vitamount'] = $cashprice*$vit;
    $retVal['amountfinanced'] =  $cashprice+$taxamount+
      $vitamount+$doc+$title+$registration;
    return $retVal;
}
//////////// GET TT&L ////////////////////

jayant

//////////// GET TT&L //////////////////// 
function get_ttl() { 
    global $tradediff,$tax,$saleprice,$rebate,$cashprice,$vit,
        $taxamount,$vitamount,$doc,$title,$registration;
    $retVal = mysql_fetch_array(mysql_query("SELECT * FROM ttl")); 
    $retVal['taxamount'] = $tradediff*$tax; 
    $retVal['cashprice'] = $saleprice-$rebate; 
    $retVal['vitamount'] = $cashprice*$vit; 
    $retVal['amountfinanced'] =  $cashprice+$taxamount+ 
      $vitamount+$doc+$title+$registration; 
    return $retVal; 
} 
//////////// GET TT&L ////////////////////

jalrock

Cool!

I have created a file called functions.php

<?php
require "./connect.php";
//////////// GET TT&L //////////////////// 
function get_ttl() {  

    global  $tradediff,$tax,$saleprice,$rebate,$cashprice,$vit
, 
        $taxamount,$vitamount,$doc,$title,$registration; 
    $retVal = mysql_fetch_array(mysql_query("SELECT * FROM ttl"));  

    $retVal['taxamount'] = $tradediff*$tax;  

    $retVal['cashprice'] = $saleprice-$rebate;  

    $retVal['vitamount'] = $cashprice*$vit;  

    $retVal['amountfinanced'] =  $cashprice+$taxamount+  

      $vitamount+$doc+$title+$registration;  

    return $retVal;  

}  

//////////// GET TT&L ////////////////////
?>

How would I call it in the following page where indicated that will produce the needed variables?

<?php
require "./connect.php";
include "./header.inc"; 
include "./functions.php"; 
///-------PRE-SET----------///
$tradediff = $saleprice-$rebate-$tradevalue;
//$date = date("l h:i A");
$today = getdate();
$date = ("".$today['mon']."-".$today['mday']."-".$today['year'].""); 
///-------PRE-SET----------///

////  *** NEED TO CALL IT HERE ***  /////

echo "<form method=\"post\" action=\"index.php\">\n";
//echo "<input type=hidden name=\"id\" value=\"$id\">\n";
if ($submit) {
if ($overridedown) {
$cashdown = $taxamount;
}
       $sql = "INSERT INTO deals (date,saleprice,rebate,tradevalue,tradepayoff,cashdown,msrp,residual,firstname,lastname,beacon) VALUES ('$date','$saleprice','$rebate','$tradevalue','$tradepayoff','$cashdown','$msrp','$residual','$firstname','$lastname','$beacon')";

} elseif ($edit) {
    echo "2";
    $sql = "UPDATE deals SET saleprice='$saleprice',rebate='$rebate',tradevalue='$tradevalue',tradepayoff='$tradepayoff',cashdown='$cashdown',firstname='$firstname',lastname='$lastname',beacon='$beacon' WHERE id=$id";

?>
<?php
}
 $result = mysql_query($sql);
////////
// Find the last insert row
$id = mysql_insert_id();
////////

$sixtymonthpmt = $amountfinanced*.0240;
$fortyeightmonthpmt = $amountfinanced*.0280;
$thirtysixmonthpmt = $amountfinanced*.0311;
?>

<?php
include "./maintemplate.inc";
include "./footer.inc";
?>

trininox

I thought i had something but then i reviewed it again and lost my train of thought... what exactly is the problem?

jalrock

2 posts up....
I need to know how to call the function in functions.php you all helped me to create.

Weedpacket

Just looking at the initially supplied code, it could be written as

$sql = "Select
        tax, vit, doc, registration, title
        from ttl";
$result = mysql_query($sql);
list($tax, $vit, $doc, $registration, $title) = mysql_fetch_row($result);
$taxamount = $tradediff*$tax;
$cashprice = $saleprice-$rebate;
$vitamount = $cashprice*$vit;
$amountfinanced =  $cashprice*(1+$vit)+$taxamount+$doc+$title+$registration;

Weedpacket

Originally posted by jalrock
2 posts up....
I need to know how to call the function in functions.php you all helped me to create.

You'd put the call to the function in the spot where your comment says //// * NEED TO CALL IT HERE * ////

and put the returned array into some variable - call it "$ttl".

$ttl = get_ttl();

Then when you want the taxamount that the function calculated, it's in $ttl['taxamount'];

I should point out though that your function won't work: $vit (for example) never gets a value.

<?php
function get_ttl() {  

    global   $tradediff, $saleprice, $rebate, $cashprice, $taxamount, $vitamount; 
    $retVal = mysql_fetch_array(mysql_query("SELECT tax, vit, doc, registration, title FROM ttl"));  

    $retVal['taxamount'] = $tradediff*$retVal['tax'];  

    $retVal['cashprice'] = $saleprice-$rebate;  

    $retVal['vitamount'] = $cashprice*$retVal['vit'];  

    $retVal['amountfinanced'] = $cashprice + $taxamount + $vitamount + $retVal['doc']  +$retVal['title']  +$retVal['registration'];  

    return $retVal;  

}  

?>

And it would be good practice if you passed all those global variables to the function as parameters.