Help with mysql_insert_id();

[Chrysanthus]

Hi i need help with mysql_insert_id(); im trying to make a insert from a ID generated from the previous INSERT operation..

The new value that is generated from the colume ID in table childetopics, i wount it to insert the same value to colume called childetopicID in tabel mainposts..

Now i do not know how to do this but if som one can help med with this it woulde help me a lot ...

Here i the function.php

I hop some one can help me with this!!

<?php

include ("../Management/mysqlcondbfm.php");



function addmainpost () {
global $password,$email,$username,$post,$childetopicID;
	$timestamp = time();
	$new_password = addslashes($password); 	$new_email = addslashes($email);
	$new_name = addslashes($username);
	$new_post = addslashes(htmlspecialchars($post));
	$insert = mysql_query("INSERT INTO mainposts VALUES ('NULL','$childetopicID','$new_name','$new_email','$new_password','$new_post','$timestamp')");
	if (mysql_error() != "") {
		showheader("MySQL Error ".mysql_error());
		?>
		<br><p><center><b>There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
		<?php
		showfooter();
		exit;
	}

}


function addchildetopic () {
global $password,$email,$username,$maintopicID,$childetopicname;
	$timestamp = time();
	$new_password = addslashes($password); 	$new_email = addslashes($email);
	$new_name = addslashes($username);
	$new_post = addslashes(htmlspecialchars($childetopicname));
	$insert = mysql_query("INSERT INTO childetopics VALUES ('NULL','$maintopicID','$new_post','$new_name','$new_email','$new_password','$timestamp')");
	if (mysql_error() != "") {
		showheader("MySQL Error ".mysql_error());
		?>
		<br><p><center><b>There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
		<?php
		exit;
	}

}

function addmaintopic () {
global $password,$email,$username,$maintopicname,$maintopicdescription;
	$timestamp = time();
	$new_password = addslashes($password); 	$new_email = addslashes($email);
	$new_name = addslashes($username);
	$new_post = addslashes(htmlspecialchars($maintopicdescription));
	$insert = mysql_query("INSERT INTO maintopics VALUES ('NULL','$maintopicname','NULL','$new_name','$new_email','$new_password','$new_post','$timestamp')");
	if (mysql_error() != "") {
		showheader("MySQL Error ".mysql_error());
		?>
		<br><p><center><b>There was a MySQL Error -- <?php echo mysql_error() ?></b></center></p>
		<?php
		exit;
	}

}


?>

[laserlight]

It might be as simple as using:
$insert = mysql_query("INSERT INTO mainposts VALUES (" . mysql_insert_id() . ",'$childetopicID','$new_name', ...)");

Though you'll have to call addmainpost() immediately after addchildetopic().

Personally I would re-structure the functions, since they appear to be using too many global variables than is normally healthy, and I think that if you do indeed use them together, you'll be repeating a number of processes, e.g. addslashes().

[Chrysanthus]

I solved it in another way but if i dont know if may way is sow good but i defined mysql_insert_id() in my form action...

see this code and look at code mysql_insert_id() where it is!

<?php

require( './functions.php');

$action=$_POST["action"]; 
$username=$_POST["username"]; 
$email=$_POST["email"]; 
$password=$_POST["password"]; 
$post=$_POST["post"]; 
$childetopicname=$_POST["childetopicname"]; 
$maintopicID=$_GET["maintopicID"];
$redirect_maintopicID=$_GET["maintopicID"];

if ($action=="add_two") {
	if ($username=="" or $email=="" or $password=="" or $post=="") {
	echo "You Must Fill in all fields before proceeding";
	exit;
	}
	$maintopicID = addchildetopic();
	$childetopicID = mysql_insert_id();
	addmainpost();

function redirect($url,$delay='7') { 
print ' 
    <meta http-equiv="refresh" content="'.$delay.';URL='.$url.'"> 
'; 
} 

redirect("childe-topicview.php?maintopicID=redirect_maintopicID"); 

echo "<b>Your topic and your post has been added succesfuly!<br>
	 Now You Will Be Redirect back to childe topic viewbord in 7 Secounds!</B>";


}
else {
?>
<TABLE BORDER=0 WIDTH=100% CELLSPACING=3 CELLPADDING=5>
	<TR>
		<TD>
			<FONT COLOR="#000000" FACE="Arial,Verdana,Helvetica" size=-1>
			<P>
			<a href="childe-topicview.php?maintopicID=<?php echo $maintopicID['ID'] ?>"><FONT COLOR="#000000">Return back to childe topics</a>
		</TD>
	</TR>
</TABLE>
<FORM METHOD=POST ACTION="<?php echo $PHP_SELF ?>">
<INPUT TYPE="hidden" name="action" value="add_two">
<table border=0 cellpadding=0 cellspacing=0 width="95%">
<TR><td bgcolor="#000000">
<table border=0 cellpadding=4 cellspacing=1 width=100%>
<tr bgcolor="#C0C0C0">
<td >
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><B>Topic name:</B>
<BR><FONT SIZE="-2">The topic name can only contane 50 letters.
</FONT></td><td>
<INPUT TYPE="TEXT" NAME="childetopicname" SIZE=60>
</td></tr>
<tr bgcolor="#C0C0C0">
<td >
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><B>Topic creator:</B></FONT></td><td>
<INPUT TYPE="TEXT" NAME="username" SIZE=25>
</td></tr>
<tr bgcolor="#C0C0C0">
<td>
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><B>Creators email:</B></FONT></td>
<td><INPUT TYPE="text" NAME="email" SIZE=25 VALUE="">
</font></td></tr>
<tr bgcolor="#C0C0C0">
<td>
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><B>Creators password:</B>
<BR><FONT SIZE="-2">This is used when you would like to edit or delete your maintopic.
</FONT></td><td>
<INPUT TYPE="password" NAME="password" SIZE=25 VALUE="">
</font></td></tr>

<tr bgcolor="#C0C0C0">
<td valign=top>
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica"><B>Your Post:</B></FONT>
<p><BR>
<FONT SIZE="-1" FACE="Trebuchet MS,Arial,Helvetica">
The post appear exactly as you have submitted them an can only contane Letters. HTML will not be allowed, as the tags are instantly converted into harmless text. Therefore, you cannot have HTML formatting.
</p>
</font>
<br>
<input class="button" type="SUBMIT" name="Submit" value="Submit" style="width: 88px; height: 20px;">
<input class="button" type="RESET" name="Reset" value="Clear Fields" style="width: 88px; height: 20px;">
</td>
<td>
<TEXTAREA NAME="post" ROWS=10 COLS=45 WRAP="VIRTUAL"></TEXTAREA></td></tr>
</table>
</td></tr></table> 
<P>
<CENTER>


<br>
</CENTER>
</FORM>
<?php
}
?>

[Shrike]

It is just as easy as that. Theres a caveat to using mysql_insert_id(), in that it will remember the auto_id generated for the last successful INSERT statement, so if a query fails you could end up with the wrong auto_id. Be careful 🙂

[Chrysanthus]

is there another way to do this sow it can bee safe to work with it if a inserts go wrong!?

[laserlight]

You're using the global variable there, but seriously I'd prefer to re-structure a little.

Anyway, you'll have to do some error checking, and say, halt the script (gracefully) if a query fails.

[Chrysanthus]

Do you have an exampel on a query check? Globals??? not god ? or should i use $_POST insted?