email form/global_register OFF

jarow

This simple form works fine with global_registers ON but with globals OFF it does not. Can anyone give me an idea how I can get this to work with globals OFF. many thanks

<?php

$fname = "James";           // Name to be shown in from details.
$femail = "address@hotmail.com";  // E-mail address to be shown in  from details.

//-------------------------------------------------------------------------------------------

if(!isset($action)){

?>


<form name="form1" method="post" action="mailform.php">
<input name="action" type="hidden" value="send">
<table width="370" border="0" cellspacing="0" cellpadding="2">
  <tr>
    <td width="120" >to e-mail:</td>
    <td width="250" ><input name="toemail" type="text" size="30"></td>
  </tr>

  <tr>
    <td>subject:</td>
    <td><input name="subject" type="text" size="30" value=""></td>
  </tr>
  <tr>
    <td  valign="top">message:</td>
    <td>
	 <textarea name="message" rows="5" cols="35">

 </textarea>
</td>
  </tr>
  <tr>
    <td>type:</td>
    <td>
	  text&nbsp;<input name="rdType" type="radio" value="0" checked>
	  &nbsp;&nbsp;
	  html&nbsp;<input name="rdType" type="radio" value="1">
	</td>
  </tr>
  <tr>
    <td>&nbsp;</td>
    <td>
	 <input name="cmdSend" type="submit" value="send">&nbsp;
	 <input name="cmdReset" type="reset" value="reset">
	</td>
  </tr>
</table>
</form>


<?php
}else{
 $from = $fname . "<$femail>";
 $headers = "From: $from \r\n";
 if($rdType == 1){
   $headers .= "MIME-Version: 1.0\n" . "Content-type: text/html; charset=iso-8859-1";
   $message = stripslashes($message);
 }else{
   $headers .= "MIME-Version: 1.0\n" . "Content-type: text/plain; charset=iso-8859-1";
 }
 $ok = @mail($toemail, $subject, $message, $headers);
  if ($ok) {
   echo "<center><font class='general'>Mail sent successfully. Thank you.</font></center>";
  } else {
   echo "<center><font class='general'>Mail could not be sent.</font></center>";
  }
 }

?>

ClevaTreva

The form posts to mailform.php which I assume this code is, and not another page.

Try putting this code at the start of the page:

foreach (array_keys($_POST) as $key)
{ 
	$$key = $_POST[$key]; 
//	print "POST variable $key is ${$key}<br />"; 
}

I have commented out the printing of the variables posted, but if you need to debug, then enable that line.

Hope this works, it does for me.

Trevor

keith73

Originally posted by ClevaTreva
Hi

The form posts to mailform.php which I assume this code is, and not another page.

Try putting this code at the start of the page:
foreach (array_keys($_POST) as $key)
{ 
	$$key = $_POST[$key]; 
//	print "POST variable $key is ${$key}<br />"; 
}
Trevor [/B]

or you could just use the php function
import_request_variables("gp");

but it's better not to do that and to actually use the $_POST['myvar'] way of doing things. it's safer.

keith

Pig

You need to use $POST['var'] format for every variable that comes from the form. Don't use $action, use $POST['action'].

ClevaTreva

The reason I suggested the code that I did was to avoid re-writing his code by using $_POST('action'), etc for every variable. My code reads in the entire Post array, and declares variables in the page corresponding to the variable names posted, with the values they held, thus he should need do no re-coding, just post this code a tthe top of the page. It also has the advantage of being able to display each passed variable with the associated value.

I was trying to keep it easy. After all, I once had a 1,000 plus line page to do with loads of variables. Hand re-coding that lot was just asking for trouble. 😉

Trevor

Pig

Globaling all of the $POST vars would work as well. I just don't feel comfortable ever recommending globaling something. The earlier you start coding with $POST['var'] the better off you are. That's my opinion anyway.

jarow

Thanks very much to all who answered. It turned out that sendmail_from was incorrectly set up on the server.

All fixed.

thanks again