My IF statement is skipped right over!!

l008com

Here is my code...

function URLCheck( $line )
	{

for ($i = 0; $i < $blackurls; $i++ )
	{
	if (strpos($line,$Blacklist[$i]) === false)
		{
		echo "9\n";
		echo "$line, $Blacklist[$i]\n";
		}
	else
		{
		$badcounter++;
		$shibby = number_format($badcounter);
		echo "\nSkipped #$shibby: $line\n";
		return false;
		}		
	}
echo "true\n";
return true;	
}

Now for reasons I don't understand, this function always returns true, and writes TRUE to the command line. It never writes anything else. But with echo's on both sides of the IF statement, how could it not? Its like it's just skipping right over my IF statement!! Is very annoying.

I've tested it in cases where strpos() will return a true value, which should cause the whole function to return a false, but it doesn't. Also $blackurls is equal to the number of items in array $blacklist[$i]

file_cabinet

have you tried changing to two equal signs?

(strpos($line,$Blacklist[$i]) == false)

l008com

no because the function will return 0 if the string starts with the search string, thereby giving a false negative.

ahundiak

Need to read up on globals, both $blackurls and $Blacklist are out of scope.

l008com

I defined them as global in my main section of code, do I have to define them as global again in each function?

ahundiak

Take a few minutes and lookup the answer in the manual. Trust me on this, your development process will go much smoother once the manual becomes part of it.

l008com

OK what the hell i added a whole huge new question to this thread last night and now its gone?!?! What the frig is going on?

l008com

Anyway, I fixed up the code, but now there's a new problem, it seems like this little function returns true all the time, even when it really returns false. I can't figure it out and I even read the manual first this time.

function AddURL( $line )
	{
	if ( URLCheck( $line ) );
		{
		mysql_query("insert into urldatabasenew (url) values ('$line')");
		}
	}


function URLCheck( $line )
	{
	global $blackurls;
	global $Blacklist;
	global $badcounter;

for ($i = 0; $i < $blackurls; $i++ )
	{
	if( !(strpos($line,$Blacklist[$i]) === false) )
		{
		$badcounter++;
		$shibby = number_format($badcounter);
		echo "Skipped #$shibby: $line\n";
		return false;
		}		
	}
return true;
}

In the above example, even when the url is blacklisted, and even when it prints "Skipped..." to the screen, it still ads the url to the database, as if the function returned true. As far as I can tell, return does NOT exit you out of a for loop, it exits the whole function, so this doesn't make sense to me.

nemonoman

function URLCheck( $line )
{
global $blackurls;
global $Blacklist;
global $badcounter;

$return=true;

for ($i = 0; $i < $blackurls; $i++ )
    {
    if( !(strpos($line,$Blacklist[$i]) === false) &&$return)
        {
        $badcounter++;
        $shibby = number_format($badcounter);
        echo "Skipped #$shibby: $line\n";
        $return=false;
        }        
    }

if($return){return true;}
}

l008com

ooooh crap... if i really am getting stuck in the for loop, you are right... but i think i see an extra ';' in there...

I think that was it, I'm testing now and post my new results tomorrow, but i'm confident thats it. The if had a ; after it, so it was like it was an if with no statements to do if true, then it would simply always do what lied after it :-D.