for each loop

aj3220

What was happening with this scrip was it would loop all the vars in a var and post them. However, i did not want it to display the vars if the var was equal too default.gif. So i added some code and basically now it wont show them at all. I think it might just be a variable name problem but i can' tseem to find it. Maby you all could take a look and tell me if you see anything out of the ordinary.

foreach ($pics as $key => $value)
{

if ($value == "default.gif") { unset ($pics[$key]); }

}

that is the code i added to unset the one of the vars if it equals default.gif

$sql = "SELECT * FROM users WHERE user='$name'";
$result = mysql_query($sql,$con);
$row = mysql_fetch_array($result) or die(mysql_error());

    $mainpic = $row['mainpic'];

    $pic1 = $row['pic1'];
    $pic2 = $row['pic2'];
    $pic3 = $row['pic3'];
    $pic4 = $row['pic4'];

    $pics = array($pic1,$pic2,$pic3,$pic4);


foreach ($pics as $key => $value)
{

if ($value == "default.gif") { unset ($pics[$key]); }

}



foreach($pics as $picname)
{
$table .= "
<td align=center><a href=http://c.com/viewimage.php?image=$picname&name=$name> <span style='text-decoration: none'><img
src=http://l.com/pics/$picname height=80 width=80></a></span></td>
"; 
}

thank you for your time and help
Anthony

Weedpacket

function is_not_default_gif($element)
{ return $element!='default.gif';
}

$pics = array_filter($pics, 'is_not_default_gif');

OR:
Don't waste time putting pics into the $pics array if you're just going to take them out again a moment later. Check to see if they're default.gif first and only put them in if they're not.

AND:
Better yet: renormalise the database so that you don't have to have a "default.gif" just for the sake of having something in a database field. Give the pics their own table instead.

aj3220

Well they are currently all in their own field in the db. However, i have no idea where to begin on tlling it to only show the fields that arn't in == default.gif and then actually show from left to right in the html.

Any ideas?

Weedpacket

I'm talking about this bit

        $pic1 = $row['pic1'];
        $pic2 = $row['pic2'];
        $pic3 = $row['pic3'];
        $pic4 = $row['pic4'];

    $pics = array($pic1,$pic2,$pic3,$pic4);

Why not

$pics=array();
if($row['pic1']!='default.gif') $pics[]=$row['pic1'];
if($row['pic2']!='default.gif') $pics[]=$row['pic2'];
if($row['pic3']!='default.gif') $pics[]=$row['pic3'];
if($row['pic4']!='default.gif') $pics[]=$row['pic4'];

In other words, don't put them in if you're only having to take them out again.

But it would still be nicer to give them their own table; what if you want five pictures someday?