fopen throws no error but no handle opened

bubblenut

Hi here is a snippet of my code

<?php
    $buffer='';
    for($i=0;$i<count($readfile);$i++) {
        $readfile[$i]=str_replace("\n",'',$readfile[$i]);
        echo("\t".$i." : ".$readfile[$i]."\n");
        if(is_file($readfile[$i])) {
            if(!$fp=fopen($readfile[$i],'r')) {
                exit("\tCould not open file\n");
            }
            echo("\tSize : ".filesize($fp)."\n");
            while($buffer.=fgets($fp,4096)){}
            fclose($fp);
            echo("\tREAD\n");
            if(preg_match("/^".addslashes($file)."$/",$buffer)) {
                return $readfile[$i];
            }
            $buffer='';
        } else {
            echo("\tWas not a file\n");
        }
    }
?>

and here is the output

0 : /home/httpd/path/to/file
 
Warning: stat failed for Resource id #1 (errno=2 - No such file or directory) in /home/user/bin/searcher on line 17 
Size :

It doesn't seem to make sense, no error is caught by fopen but there is no handle right after when we hit the filesize() echo
Thanks in advance

[EDIT] Ignore me, I'm retarded :p

cosminb

from the manual:
int filesize ( string filename)

meaning that the parameter for filesize should be a filename(string) not a resource handler

cosminb

.... that's of course if you don't have PHP 5 installed.

bubblenut

Yea, I realized (that's what the EDIT was for)
Changed things round to this and I am now having a slightly different (by no means fatal) problem.
Here is the code

<?php
    $buffer='';
    for($i=0;$i<count($readfile);$i++) {
        $readfile[$i]=str_replace("\n",'',$readfile[$i]);
        echo("\t".$i." : ".$readfile[$i]."\n");
        if(is_file($readfile[$i])) {
            if(is_readable($readfile[$i])) {
                if(!$fp=fopen($readfile[$i],'r')) {
                    exit("\tCould not open file\n");
                }
                $filesize=filesize($readfile[$i]);
                echo("\tSize : ".$filesize."\n");
                $div=(int)($filesize/100)+(($filesize%10==0)?0:1);
                if($div==0)
                    $div=1;
                echo("\t");
                while(!feof($fp)) {
                    echo("*");
                    $buffer.=fread($fp,$div);
                }
                fclose($fp);
                echo("\n");
                for($j=0;$j<10000;$j++) {}
                if(preg_match("/^".str_replace('/','\/',$file)."$/",$buffer)) {
                    echo("\nMATCHER!!!!\n");
                    return $readfile[$i];
                }
                $buffer='';
            } else {
                echo("\tNot Readable ... get root!\n");
            }
        } else {
            echo("\tWas not a file\n");
        }
    }
?>

An the area I am having a poblem with is this

<?php
 $filesize=filesize($readfile[$i]);
echo("\tSize : ".$filesize."\n");
$div=(int)($filesize/100)+(($filesize%10==0)?0:1);
if($div==0)
  $div=1;
echo("\t");
while(!feof($fp)) {
  echo("*");
  $buffer.=fread($fp,$div);
}
fclose($fp);
?>

Now, by my reconing that should print 100 s for each file unless it is less that 100 bytes long and the it hould show less. The aim, as I'm sure you can guess is to show me the progress through the files. However, a strange thing I am noticing is that for some files I am getting more than 100 s, somtimes about 150!
I can't explain it. Also is there a commant to make php wait for a given amount of time before it continues?
Thanks
Bubble

mtimdog

I'm looking at the problem code and I'm perplexed at what you're trying to do?

The code suggests you're printing the filesize.

Then setting a variable named $div to either 0 or 1.
Then if $div is 0 then set it to 1.

If you're trying to echo 100 for filesize or lower if file is smaller you should try something like this

echo ($filesize < 100)?$filesize:"100";

cosminb

Originally posted by bubblenut
...Also is there a commant to make php wait for a given amount of time before it continues?
Thanks
Bubble

sleep() or usleep()

bubblenut

Originally posted by mtimdog
Then setting a variable named $div to either 0 or 1.
Then if $div is 0 then set it to 1.

Not quite, it get's an integer value for one hundredth of the file size (int)($filesize/100) then if $filesize is not exactly divisible by one ($div100 is going to less than filesize) it adds 1.
Then it checks to see if the value assigned to $div is equal to zero (this could happen if $filesize is less than 100) if this is the case it sets $div to 1. Incidentally if this last check isn't made and you come accross a file which is less than 100 bytes (as I did) it prints out a lot of s, in fact it carrys on printing them out untill you kill the process.
Basically, now we have just under ($filesize/100) in $div so the while loop should iterate 100 or less times.

Cosminb - Thanks for the sleep() and usleep().
Cheers
Bubble

mtimdog

I thought I saw another pair of parenthesis there.

mtimdog

$num_stars = ($filesize < 100)?$filesize:"100";

for ($i = 0;$i < num_stars;$i++){
echo "*";
$buffer.=fread($fp,1);//$div doesn't make sense here for this loop
}

fclose(...);

bubblenut

Your script won't read the whole file for any file bigger than 100 bytes. $div makes perfect sense in the fread statement, it fecilitates reading a proportion of the file size every iteration rather than a finite amount (like one byte). The purpose is not just to print 100 stars on the screen but to show the progress which has been made in reading the file.
Bubble

mtimdog

Ok, I'm getting the gist now (is that w/ a g or a j??)

Your error is making $div....if the file is 140 bytes long

$div = 1, so it'll print out 140 stars

try

$div= $filesize/100;//yes, we want a float
$count=0;//initialize count
while (!feof($fp)){
      $count++;    //increment count
      $buffer=fread($fp, 1); //only get 1 byte
      if ($count >= $div){ //we want to put out a star
                                    // and reinitialize count
            echo "*";
            $count=$div - $count;//we don't use 0 so 
                                              //there's no error..
                                             //i.e.  it will put out 100 stars
       }
}

bubblenut

Nice, cheers.

mtimdog

We can further create this by making it work for any filesize (under 100...it will print out 100 stars also)
by changing the inside if to a while loop

$div= $filesize/100;//yes, we want a float 
$count=0;//initialize count 
while (!feof($fp)){ 
      $count++;    //increment count 
      $buffer=fread($fp, 1); //only get 1 byte 
      while ($count >= $div){ //we want to put out a star 
                                    // and reinitialize count 
            echo "*"; 
            $count=$count - $div;//we don't use 0 so 
                                              //there's no error.. 
                                             //i.e.  it will put out 100 stars 
       } 
}

btw, I think the original should be count=count-div as well in the loop...not sure what I was thinking!!