Help with PHP/MYSQL

expert_21

Hi, i tried inserting data into mysql using:

$query='INSERT INTO zeus_phones';
$query .='VALUES (\'\',\'$today\', \'$manufacturer\', \'$model\', \'$website\', \'$network\', \'$dimension\', \'$weight\', \'$batterylife_talktime\', \'$batterylife_standbytime\', \'$antenna\', \'$display\', \'$os\', \'$pros\', \'$cons\', \'$source1\', \'$source1_abstract\', \'$source2\', \'$source2_abstract\', \'$source3\', \'$source3_abstract\')';
$result=mysql_query($query) or die(mysql_error());

those $website/$network/$dimension are variables, containing certain values. Take for instance $website contains "abc". When i check my database, it turns out to contain '$website' instead of 'abc'. I'm dumbfolded, anyone willing to help? thank you.

laserlight

The reason is that your string is delimited by single quotes, and variables are not interpolated within single quotes.
As such, you should use double quotes.
Normally using variable interpolation would be slightly more expensive, but in this case we also want the SQL query to be easy to read:

$query = "INSERT INTO `zeus_phones`
	VALUES ('', '$today', '$manufacturer', '$model', '$website',
	'$network', '$dimension', '$weight', '$batterylife_talktime',
	'$batterylife_standbytime', '$antenna', '$display', '$os',
	'$pros', '$cons', '$source1', '$source1_abstract', '$source2',
	'$source2_abstract', '$source3', '$source3_abstract')";
$result = mysql_query($query)
	OR die(mysql_error());

rgermain

I was just wondering, shouldn't it also list which fields the values need to go into. Like

<?
$q = "INSERT INTO my_tbl (col_1,col_2,col_3,col_4,col_5) VALUES
('$value1','$value2','$value3','$value4','$value5')";
?>

laserlight

If I remember correctly assuming all the columns are used that isnt required, but it's better to check the manual.

EDIT:
yes, it is optional:

If you specify no column list for INSERT ... VALUES or INSERT ... SELECT, values for all columns in the table must be provided in the VALUES() list or by the SELECT.

rgermain

Oh ok, then I am guessing you have to list the values in the same order as your fields. Otherwise, how does it know which goes where?

Sorry, I just like asking questions to learn, not to be a pain! 🙂

expert_21

Originally posted by laserlight
The reason is that your string is delimited by single quotes, and variables are not interpolated within single quotes.
As such, you should use double quotes.
Normally using variable interpolation would be slightly more expensive, but in this case we also want the SQL query to be easy to read:
$query = "INSERT INTO `zeus_phones`
	VALUES ('', '$today', '$manufacturer', '$model', '$website',
	'$network', '$dimension', '$weight', '$batterylife_talktime',
	'$batterylife_standbytime', '$antenna', '$display', '$os',
	'$pros', '$cons', '$source1', '$source1_abstract', '$source2',
	'$source2_abstract', '$source3', '$source3_abstract')";
$result = mysql_query($query)
	OR die(mysql_error());
[/B]

You just saved my day! thank you. as you can see, i'm really a beginner in this stuff.

i am just a bit confused as to when should we use double quotes and when should we use single quotes. as far as i can see, the disadvantage of single quotes is that the variables arent interpolated(don't know what is interpolated but i assume variables can't be used with single quotes :p ).