$help$me not working

expert_21

i have this simple php:

for ($i=1;$i=5;$i++){
	if (!empty($pro$i))
		$pros. =$pro$i."\n";
}

i have 4 variables, $pro1, $pro2...$pro5. What i want to do, is to check whether the variable is empty or not, and if it is not empty, add to another variable. anyone has any idea as to why it won't work?

the error returned is:

Parse error: parse error, expecting ','' or')'' in /home/mydomain/public_html/tmp/addphone.php on line 28

laserlight

Read the PHP manual again on variable variables.
The solution is:

for ($i = 1; $i < 5; $i++) {
    if (!empty(${'pro' . $i}))
        $pros .= ${'pro' . $i} . "\n";
}

expert_21

hi, thank you laserlight for pointing me to the correct source. however, i still can't get it to work.

$pro1=addslashes($_POST['pro1']);
$pro2=addslashes($_POST['pro2']);
$pro3=addslashes($_POST['pro3']);
$pro4=addslashes($_POST['pro4']);
$pro5=addslashes($_POST['pro5']);

for ($i=1;$i==5;$i++){
	if (!empty(${'pro'.$i}))
		$pros.=${'pro'.$i}."\n";
}
echo nl2br($pros);

$pros return nothing, although $pro1 and $pro2 contain certain value. Any idea?

sid

without having tried it myself it would seem a lot more logic and easier to me if you used arrays.

ClevaTreva

I think you need to use eval() on the if line and the one following it. And laserlight is right about the middle part of the for needing a < not an =

eval("if (!empty(\$pro$i))");

what this SHOULD do is look for variables and replace them. The escape in front of the $pro leaves this as is, but the $i becomes the number. So the code becomes:

$pro1=addslashes($_POST['pro1']); 
$pro2=addslashes($_POST['pro2']); 
$pro3=addslashes($_POST['pro3']); 
$pro4=addslashes($_POST['pro4']); 
$pro5=addslashes($_POST['pro5']); 

for ($i=1;$i<=5;$i++){ 
eval("if (!empty($pro\$i))") 
eval("$pros.=\"$pro\$i\\n\";"); 
} 
echo nl2br($pros);

I think.

Trevor

philipolson

To quote Rasmus (the creator of PHP):

If eval() is the answer, you have asked the wrong question.

Anyway, simply changing the == to <= in your for() loop will do the job. Also for good measure (although PHP doesn't really care), you should always initialize your variables, so, do $pros = ''; before your loop.