Display checked checkboxes

[[deleted]]

I am trying to display all checked and unchecked checkboxes for a given user. The idea is that if a value in one table,priv, is the same in another table, uspmatrix, then the checkbox is checked and if not then the checkbox is unchecked, but still visible. The problem is that only one checkbox ends up being checked. This is, of course, the first value returned by my query.

Any suggestions?

Here's the code:

	// get all privileges for selected user
				$result = mysql_query ("SELECT p.privid,p.privname
									FROM crc1.priv p, crc1.uspmatrix u
									WHERE p.privid = u.privid
									AND u.userid = '$id'");								  

							while ($priv_row = mysql_fetch_array ($result)){
								$priv_id = $priv_row ['privid'];

			// get all privileges
			$result = mysql_query ("SELECT * from crc1.priv ORDER BY privname ASC");

						while ($row = mysql_fetch_array($result)){		
							$privId = $row['privid']; 
							$privName = $row['privname']; 
							$privCheckBox = "<tr>
                    							<td style=\"padding-left: 50px;width:200px\">$privName</td>
					 							<td col=\"1\"><input type=\"checkbox\" name=\"priv[]\" value=\"".$privId."\"";
							if ($privId == $priv_id){
								$sel = "checked";
							} else {
								$sel = "";
							}//end if
							$privCheckBox = $privCheckBox." $sel></td>
                           					<td col=\"1\"><input name=\"deletePriv[]\" type=\"checkbox\" value=\"$privId\"></td>
						   					<td width=\"300px\">"; 
							echo "$privCheckBox"; 
							}//end while	
							}//end while

[zhabala]

You are probably using the same value for result in both while loops. You are using $result for both. I think that it is the problem.

Zdenek

[[deleted]]

Ok, so I changed the first $result to $privResult. I now see more than one checked checkbox, but for each checked checkbox there are four others with the same name unchecked. There seems to be a problem with my loop.

[zhabala]

I didn't studied it before, but now I can see, it is probably wrong.

You have two loops, second nested in first. But first loop goes through privileges for your user, and second goes through all privileges, so you have as many combination as there is privileges and privileges for your user.

I think, that you should do it as two not nested loops. First loop will read privileges for your user. And will store them into an array.
Second loop will go through all privileges, and will check them in the array. When it is in the array then it should be checked, when it is not in the array it should be unchecked.

Makes sense ?

Zdenek

[[deleted]]

Is this what you meant?

// get all privileges for selected user
				$result = mysql_query ("SELECT DISTINCT p.privid,p.privname
									FROM crc1.priv p, crc1.uspmatrix u
									WHERE p.privid = u.privid
									AND u.userid = '$id'");								  

							while ($priv_row = mysql_fetch_array ($result)){
								$priv_id = $priv_row ['privid'];
								}
				// get all privileges
				$privResult = mysql_query ("SELECT * from crc1.priv ORDER BY privname ASC");

						while ($row = mysql_fetch_array($privResult)){		
							$privId = $row['privid']; 
							$privName = $row['privname']; 
							$privCheckBox = "<tr>
                    				<td style=\"padding-left: 50px;width:200px\">$privName</td>
					 				<td col=\"1\"><input type=\"checkbox\" name=\"priv[]\" value=\"".$privId."\"";

							if ($privId == $priv_id){
								$sel = "checked";
							} else {
								$sel = "";
							}//end if
							$privCheckBox = $privCheckBox." $sel></td>
                           			<td col=\"1\"><input name=\"deletePriv[]\" type=\"checkbox\" value=\"$privId\"></td>
						   			<td width=\"300px\">"; 
							echo "$privCheckBox"; 

							}//end while

Now I only get the last checkbox checked (highest value in db).

[[deleted]]

bump

[zhabala]

No I meant this one.

// get all privileges for selected user 
$priv_id = array();
$result = mysql_query ("SELECT DISTINCT p.privid,p.privname 
                    FROM crc1.priv p, crc1.uspmatrix u 
                    WHERE p.privid = u.privid 
                    AND u.userid = '$id'");                                   

while ($priv_row = mysql_fetch_array ($result)){ 
    $priv_id[] = $priv_row ['privid']; 
} // end while through all rights
	// get all privileges 
$privResult = mysql_query ("SELECT * from crc1.priv ORDER BY privname ASC"); 

while ($row = mysql_fetch_array($privResult)){         

    $privId = $row['privid'];  

    $privName = $row['privname'];  

    $privCheckBox = "<tr> 
            <td style=\"padding-left: 50px;width:200px\">$privName</td> 
             <td col=\"1\"><input type=\"checkbox\" name=\"priv[]\" value=\"".$privId."\""; 

if (in_array($privId,$priv_id)) { 
    $sel = "checked"; 
} else { 
    $sel = ""; 
}//end if 
$privCheckBox = $privCheckBox." $sel></td> 
           <td col=\"1\"><input name=\"deletePriv[]\" type=\"checkbox\" value=\"$privId\"></td> 
           <td width=\"300px\">";  
echo "$privCheckBox";  

}//end while