[Resolved] how do i replace spaces with underscore in an uploaded filename?

[jasonmills58]

I have this:

$time = time(); 
$new_file_name = $time."_".$_FILES['file_to_upload']['name']; 
$exp_file_name = explode("_", $finalfile); 
$old_file_name = exp_file_name[1];

I was wondering how I could check the filename for spaces, and replace them with underscores. I imagine it look something like this:

if (filename has spaces)
{
    explode $_FILES['file_to_upload']['name']; 
    foreach ( $_FILES['file_to_upload']['name'][] )
    {
    put the file back together with underscores...
    }
}

Am I close?
cheers,
Jason

[LordShryku]

Try using [man]strpos[/man] to find if the name has spaces, then use [man]str_replace[/man] to replace them. Your foreach loop should come before the conditional strpos check though. You'll want to perform the check for each file in the array.

[jasonmills58]

ok, those make sense. I changed things a bit, but here's what I'm working with...

$file_dir = "/home/httpd/vhosts/babysteps.tv/httpdocs/counterpoint/uploads";
$file_url = "http://babysteps.tv/counterpoint/uploads"; 
move_uploaded_file( $_FILES['file_to_upload']['tmp_name'], $file_dir.'/'.$_FILES['file_to_upload']['name'] ) 
    or die ("Couldn't Copy"); 

$time = time();  

$safe_filename = $time."-".$_FILES['file_to_upload']['name'];  

$filename = $_FILES['file_to_upload']['name']; 
$path = $file_dir.'/';

I know this isn't in the right order. I guess I'm not sure where to change the file name. The original filename (with spaces) and the "safe" filename (with underscores and a timestamp+dash) will be stored in separate fields in the database. I just need to make sure that $safe_filename is the name of the file when it gets moved to the uploads directory.

Then, I guess, when they download the file, it needs to have the timestamp+dash stripped off.

[jasonmills58]

ok, so I got the timestamp prepended, and I decided I don't really care about stripping it off for the download. All I really care about is removing any possible spaces in the filenames. Here's what I have:

$file_dir = "/home/httpd/vhosts/babysteps.tv/httpdocs/counterpoint/uploads"; 
$file_url = "http://babysteps.tv/counterpoint/uploads"; 
if ( isset ( $_FILES ) ) {
	foreach( $_FILES as $file_name => $file_array ) { 
		if ( is_uploaded_file ( $file_array['tmp_name'] ) ) {
			$time = time();  

			$safe_filename = $time."-".$file_array['name'];  

			$filename = $file_array['name']; 
			move_uploaded_file( $file_array['tmp_name'], $file_dir.'/'.$safe_filename )
				or die ( "Couldn't Copy" ); 
			$file_query = "INSERT INTO notefiles ( noteid, clientid, topic, filename, safe_filename )
										VALUES( '$noteid', '$id', '$topic', '$filename', '$safe_filename' )";
			if( ! mysql_query( $file_query, $link ) ) { 
				die("Could not execute query: ".mysql_error()); 
			} 
		 }
	}
}

Its a loop for a page where I have four possible uploads at a time. They all get the same timestamp, but thats not a problem. Where do I check for the spaces and replace them?

cheers,
Jason

[jasonmills58]

"Oh, the cleverness of me."

$file_dir = "/home/httpd/vhosts/babysteps.tv/httpdocs/counterpoint/uploads"; 
$file_url = "http://babysteps.tv/counterpoint/uploads"; 
if ( isset ( $_FILES ) ) {
	foreach( $_FILES as $file_name => $file_array ) { 
		if ( is_uploaded_file ( $file_array['tmp_name'] ) ) {
			$time = time();  

			$safe_filename = $time."-".$file_array['name'];  

			$filename = $file_array['name']; 
			$safe_filename = str_replace( " ", "_", $safe_filename );
			move_uploaded_file( $file_array['tmp_name'], $file_dir.'/'.$safe_filename )
				or die ( "Couldn't Copy" ); 
			$file_query = "INSERT INTO notefiles ( noteid, clientid, topic, filename, safe_filename )
										VALUES( '$noteid', '$id', '$topic', '$filename', '$safe_filename' )";
			if( ! mysql_query( $file_query, $link ) ) { 
				die("Could not execute query: ".mysql_error()); 
			} 
		 }
	}
}

str_replace did it all.
cheers mate!