Email Check Not Working

phpscripters

Hello,

I have created a form mailer that works well except the email checker does not work. I have gotten rid of all the other code in this message so that all you need is the part were it checks the mail (for convinience). The problem is that all email addressess are considered valid, even unvalid ones! Any help would be greatly appreciated.

function show_form() {
?>

<html>
<body>

<?php 
if($emailaddr) {
echo "<input type=\"text\" name=\"emailaddr\" value=\"$emailaddr\" size=\"28\">";
} else {
echo "<input type=\"text\" name=\"emailaddr\" size=\"28\">";
}
?>

</body>
</html>

<?php
}

// NOW HERE IS THE PHP TO CHECK THE CODE //


function send_message() {

function emailcheck($intext) {
$theresults = ereg("^[^@ ]+@[^@ ]+\.[^@ \.]+$", $intext, $trashed);
}

$check = emailcheck($emailaddr);

if(!($check))$errors .= "- The specified email address is not valid! Please specify a valid email address!<br>";

}

It verifies everything. Even bad addressess!

TTT

why don't you validate email address before submit

<script language="javascript">
		if(document.formi.email.value.length > 0) {
			if((document.formi.email.value.length  - document.formi.email.value.lastIndexOf(".") > 4) || (document.formi.email.value.length  - document.formi.email.value.lastIndexOf(".") < 3) || (document.formi.email.value.indexOf("@") < 2) || (document.formi.email.value.lastIndexOf(".") - document.formi.email.value.indexOf("@") < 3)) {
				alert("ERROR")
			return false;
			}		
		} else {
 /// do something else
// document.formi.submit();
}
</script>

phpscripters

The reason we don't use that is because the client I am writting this for wants it to check the form, and if there is something not filled out or invalid it goes back to the form page with red text at the top telling the user of the errors, that is already written and it works fine, we just can't get the email checker to work.

AstroTeg

Originally posted by TTT
why don't you validate email address before submit
[/code]

Actually, disable JavaScript and you hose your database integrity with bad data. Having JavaScript form validation is just something nice to do to save the user some time and your server some bandwidth.

phpscripters

where would i put that code? I haven't ever used javascript

AstroTeg

That JavaScript would go at the top of your HTML form page. Then for the form tag, you'll want to include something like:

<form action="" method="post" onSubmit="javascript: return ValidateForm(this);">

Or something like that.

Then ValidateForm() (or whatever you decide to call it) must either return true which will tell the browser to submit the form or false which will tell the browser to cancel the submit. So if the validation false, you have it return false. You'll also want to show an alert box to let the user know there was an error...

phpscripters

Well, I have been searching to find more about why it won't validate any emails. If someone can tell me why this is then I would like that, we don't want to use those ugly alert boxes.

In the code in the part where it is supposed to validate it calls a function "emailcheck()" I have discovered that for some reason it doesn't. It is supposed to but, it doesn't. It runs everything around it, just not that part. It's like it just skips it. Here is that snippit of code:

function emailcheck($intext) {
$theresults = ereg("^[^@ ]+@[^@ ]+\.[^@ \.]+$", $intext, $trashed);
if($theresults) { $isamatch = "yes"; } else { $isamatch = "no"; }
if($isamatch == "no") { $errors .= "- The email address supplied is not valid! Please specify a valid email address!<br>"; }
}

emailcheck($emailaddr);