[Resolved] Can anyone see my fault?

scriptkiddie

I'm trying to insert some data into a mySQL table, but I get the error:

Column count doesn't match value count at row 1

Here's my code:

   $sql = "INSERT INTO $db_tabell (tittel, forfatter, sjanger, karakter, laerer, lev_dato, skoleaar, beskrivelse, path, upl_dato)
        VALUES (\"$_POST['tittel'], $ht_brukernavn, $_POST['sjanger'], $_POST['karakter'], $_POST['laerer'], $_POST['lev_dato'],
        $_POST['skoleaar'], $_POST['beskrivelse'], $lagre_dir, $upl_dato\")";

And here's the table structure for the table I'm trying to insert to:

CREATE TABLE `oppgaver` (
  `id` tinyint(11) NOT NULL auto_increment,
  `forfatter` varchar(50) NOT NULL default '',
  `sjanger` varchar(50) NOT NULL default '',
  `karakter` tinyint(2) NOT NULL default '0',
  `laerer` varchar(50) NOT NULL default '',
  `lev_dato` varchar(20) NOT NULL default '',
  `skoleaar` enum('GK','VK1','VK2') NOT NULL default 'GK',
  `beskrivelse` blob NOT NULL,
  `path` varchar(225) NOT NULL default '',
  `upl_dato` varchar(20) NOT NULL default '',
  PRIMARY KEY  (`id`)
) TYPE=MyISAM AUTO_INCREMENT=1 ;

What's wrong?

Thank you.

groovything

You wrapped the insert values in double quotes so your SQL query thinks its one long value.

this should work:

$sql = "INSERT INTO $db_tabell (tittel, forfatter, sjanger, karakter, laerer, lev_dato, skoleaar, beskrivelse, path, upl_dato)VALUES 
('$_POST['tittel']', '$ht_brukernavn', '$_POST['sjanger']', '$_POST['karakter']', '$_POST['laerer']', '$_POST['lev_dato']', '$_POST['skoleaar']', '$_POST['beskrivelse']', '$lagre_dir', '$upl_dato')";

If this format causes problems: '$_POST['tittel']' you should be able to just use '$tittel' if you are grabbing these values from a submitted form.

scriptkiddie

Thanks man.. Can't believe I used an hour figuring this out..!

But just for the record, I must use the $_POST prefix, because of the register globals issue in PHP.

Thanks, again!

groovything

hmm... I havent had to deal with that one yet...guess I'll know what you are talking about if it ever becomes an issue for me. I'm not sure what version of php my server is using - my buddy handles all of that server set-up stuff. I just hack away at the code. :-)

I'm curious.. is my sql statement formatted correctly?

does this work within the sql statement? '$_POST['tittel']'

or do you have to escape the interior ' ' somehow?

I know with javascript you have to work it out like:

<a onClick=\"NewWindow(this.href,'report','500','450','no','center','yes'); \"