Still error messages!!

[raladin]

Hello all..

This is the PHP code :

<?php

include("Config.php");

$link = mysql_connect("$user_hostname", "$user_username", "$user_password");
mysql_select_db("$user_database", $link);

$UserName = $_GET['UserName'];
$Password = $_GET['Password'];
$LogoutTime = date("U");

$query1 = "UPDATE accounts SET LogoutTime=$LogoutTime";
$query2 = "SELECT LoginTime,Distance,LessonNumber FROM accounts WHERE UserName='$UserName' AND Password='$Password'";
$query3 = "UPDATE accounts SET LessonNumber=LessonNumber + 1";
$result = mysql_query($query1) or die("Query error: " . mysql_error());


$RightLoginTime = 'LoginTime';
$Distance = 'Distance';
$LessonNumber = 'LessonNumber';
$LessonsTimeLimit = "30";

$query4 = "UPDATE accounts SET (Distance='" . $LogoutTime - $RightLoginTime . "') WHERE UserName=" . $UserName . " AND Password=" . $Password . ")";
$result2 = mysql_query($query4) or die("Query error: " . mysql_error());

if($Distance == $LessonsTimeLimit){
    $result3 = mysql_query($query3) or die("Query error: " . mysql_error());
}else{
    echo "Not yet!";
}

?>

And this is the mySQL structure :

phpMyAdmin MySQL-Dump

version 2.2.3

http://phpwizard.net/phpMyAdmin/

http://phpmyadmin.sourceforge.net/ (download page)

#

Host: localhost

Generation Time: Jan 28, 2004 at 08:27 PM

Server version: 3.23.47

PHP Version: 4.1.1

Database : elearning

--------------------------------------------------------

#

Table structure for table accounts

#

CREATE TABLE accounts (
UserName varchar(50) NOT NULL default '',
Password varchar(50) NOT NULL default '',
SecurityQuestion varchar(50) NOT NULL default '',
SecurityAnswer varchar(50) NOT NULL default '',
CourseTitle varchar(50) NOT NULL default '',
CourseLanguage varchar(50) NOT NULL default '',
FirstName varchar(50) NOT NULL default '',
LastName varchar(50) NOT NULL default '',
BirthDay varchar(50) NOT NULL default '',
BirthMonth varchar(50) NOT NULL default '',
BirthYear varchar(50) NOT NULL default '',
Gender varchar(50) NOT NULL default '',
Language varchar(50) NOT NULL default '',
Country varchar(50) NOT NULL default '',
StateOrCity varchar(50) NOT NULL default '',
ZIPPostalCode varchar(50) NOT NULL default '',
Occupation varchar(50) NOT NULL default '',
Email varchar(50) NOT NULL default '',
Phone varchar(50) NOT NULL default '',
Mobile varchar(50) NOT NULL default '',
Serial varchar(50) NOT NULL default '',
Activation varchar(50) NOT NULL default '',
Random varchar(101) NOT NULL default '',
Adjective varchar(50) NOT NULL default '',
LessonNumber varchar(50) NOT NULL default '',
LoginTime varchar(200) NOT NULL default '',
LogoutTime varchar(200) NOT NULL default '',
Distance varchar(50) NOT NULL default '',
UNIQUE KEY UserName (UserName)
) TYPE=MyISAM;

#

Dumping data for table accounts

#

So where are the errors?

This is the error message :

"Query error: You have an error in your SQL syntax near '0') WHERE UserName=
AND Password=)' at line 1"

Also when I put the right UserName and Password.. the same error!!

So also there are sme other errors.. please see the whole script..

What I'm trying to do is :

To UPDATE a value in the database (Login_Time and Logout_Time) and then
caculate the distance between them and put it in (Distance) field.. then
after that program the PHP file and put in it a LessonLimit value.. if the
LessonLimit is the same of the Distance.. then make a value in that row
(LessonNumber) = Its currently value + 1 (So for example : is LessonNumber =
2 then it must be 3...Etc..)

Hope you got my meaning..

Waiting your help..
Regards..

[bubblenut]

$query4 = "UPDATE accounts SET (Distance='" . $LogoutTime - $RightLoginTime . "') WHERE UserName=" . $UserName . " AND Password=" . $Password . ")"; 

parenthesize $LogoutTime - $RightLoginTime so

$query4 = "UPDATE accounts SET (Distance='" . ($LogoutTime - $RightLoginTime) . "') WHERE UserName=" . $UserName . " AND Password=" . $Password . ")"; 

As you have it at the moment php will be trying to subtract $RightLoginTime."') WHERE UserName=" . $UserName . " AND Password=" . $Password . ")" from "UPDATE accounts SET (Distance='" . ($LogoutTime and will inevitably get a little confused.
HTH
Bubble

[raladin]

Thank alot for your reply..

But the same error 🙁

So what is the problem?

Regards..

[bubblenut]

Right then, let's debug. Number your error messages so we can see exactly where this is being fired off. Also when you echo the error message echo the query as well.
HTH
Bubble

[raladin]

I added you to my ICQ Messenger.

I echoed all the queries.. and this is what was shown on the screen :

UPDATE accounts SET LogoutTime=1075313199SELECT LoginTime,Distance,LessonNumber FROM accounts WHERE UserName='' AND Password=''UPDATE accounts SET LessonNumber=LessonNumber + 1
Query error: You have an error in your SQL syntax near '0') WHERE UserName= AND Password=)' at line 1

So what is the problem?

[bubblenut]

Echo the query in the or die statement so we can see which query it's applying to as that error message is not for any of those queries.
Something like this

$result4 = mysql_query($query4) or die("Query: ".$query4."<br />\nQuery error: " . mysql_error()."<br />\n");

Also, (this is just a point of convenience) try to name your variables intellegently. In this case that means having $result4 be the result of $query4 (and eventually $row4 be the result set container for $result4).
Bubble

[raladin]

Thanks alot for your help..

Finally it was fixed 🙂

Again thanks alot..

Regards..