String & elseif toubles !

[b0ksah]

Name Generator

Only rule files online is the Human Male ..

I'm trying to make a Name Generator for World of Warcraft ..

BUT I have some toubles I hope someone can help me with

<?php
if (!isset ($_GET['gender']))
{
   $pastenames = 'No names generated';
}
else{
	$race = $_GET["race"];
	$gender = $_GET["gender"];
	$pastenames = '';
	//$pastenames = $race." ".$gender;
	$rule = $race."_".$gender;
	$rule1 = $rule."_start.txt";   //File holding Start
	$rule2 = $rule."_mid.txt";	   //File holding Mid
	$rule3 = $rule."_last.txt";	   //File holding Last 

$i = 0;
while ($i != 20){
$check1 = FALSE;
$check2 = FALSE;
$finalcheck = FALSE;
$name = '';
$lim = "\n"; 
//Finding Name 
	while (!$finalcheck){
		if (!$check1 && !$check2){
			$rulefile = $rule1;
			$check1 = TRUE;	
		}
		elseif (!check2 && check1){
			$rulefile = $rule2;
			$check1 = TRUE;		
		}
		else{
			$rulefile = $rule3;
			$finalcheck = TRUE;
		} 
		$fp = fopen($rulefile, "r"); 
		$content = fread($fp, filesize($rulefile)); 
		$namearr = explode($lim,$content); 
		fclose($fp); 

		srand((double)microtime()*1000000);  //Start the randomness 

		$index = (rand(1, sizeof($namearr)) - 1); //Pick random thingie 


		$rthingie = $namearr[$index]; //Return the thingie

		$name = $name."".$rthingie; 
	}
	$pastenames = $name."".$lim;
	$i++;
}
}
?>

My Elseif fucks up ... because it never add something from the _mid.txt fil

and the $pastenames only have one name in it ...It should have 20 ...

Plz help !! 😕

[b0ksah]

I fixed my While problem ...a matter of fact the loop wasn't the problem

$pastenames = $pastenames.$name.$lim; // I had forgot to include the varible itself ..

But I still have problems with my If and else if

while ($i != 20){
    $check1 = FALSE;
    $check2 = FALSE;
    $finalcheck = FALSE;
    $name = '';
    $lim = "\n"; 
    //Finding Name 
        while (!$finalcheck){
            if (!$check1 && !$check2){
                $rulefile = $rule1;
                $check1 = TRUE;    

            }
            elseif (!check2 && check1){
                $rulefile = $rule2;
                $check2 = TRUE;        

            }
            else{
                $rulefile = $rule3;
                $finalcheck = TRUE;
            } 
            $fp = fopen($rulefile, "r"); 
            $content = fread($fp, filesize($rulefile)); 
            $namearr = explode($lim,$content); 
            fclose($fp); 

        srand((double)microtime()*1000000);  //Start the randomness 

        $index = (rand(1, sizeof($namearr)) - 1); //Pick random thingie 


        $rthingie = $namearr[$index]; //Return the thingie

        $name = $name."".$rthingie; 
    }
    $pastenames = $name."".$lim;
    $i++;
}

It wouldn't add something from the middle rule file 🙁

[b0ksah]

it works now 🙂

see the link above in the first post ... (only Human male works)

<?php
if (!isset ($_GET['gender']))
{
   $pastenames = 'No names generated';
}
else{
	$race = $_GET["race"];
	$gender = $_GET["gender"];
	$pastenames = "";
	//$pastenames = $race." ".$gender;
	$rule = $race."_".$gender;
	$rule1 = $rule."_start.txt";   //File holding Start
	$rule2 = $rule."_mid.txt";	   //File holding Mid
	$rule3 = $rule."_last.txt";	   //File holding Last 



$i = 0;
while ($i<20){
//$check1 = FALSE;
//$check2 = FALSE;
//$finalcheck = FALSE;
$name = "";
$lim = "\n";
$c = 1; 
//Finding Name 
	while ($c<4){
		$temp = "rule".$c;

		$rulefile = $$temp;


		$fp = fopen($rulefile, "r"); 
		$content = fread($fp, filesize($rulefile)); 
		$namearr = explode($lim,$content); 
		fclose($fp); 

		srand((double)microtime()*1000000);  //Start the randomness 

		$index = (rand(1, sizeof($namearr)) - 1); //Pick random thingie 


		$rthingie = $namearr[$index]; //Return the thingie

		$name = $name."".$rthingie;
		$c++; 
	}
	$pastenames = $pastenames.$name.$lim;
	$i++;
}
}
?>

I changed the if and else if to a while ..and now it works 🙂