[Resolved] How can I condense these if statements?

[jasonmills58]

Hi there. I have a small pile of if statements that seem like they could be distilled down to a case/switch, or something like that. Any suggestions?

<?php
if ( $a_row['notecheck'] == "Y" ) {
	$notechecked = "checked=\"checked\"";
} else {
	$notechecked = " ";
}
if ( $a_row['progcheck'] == "Y" ) {
	$progchecked = "checked=\"checked\"";
} else {
	$progchecked = " ";
}
if ( $a_row['hostcheck'] == "Y" ) {
	$hostchecked = "checked=\"checked\"";
} else {
	$hostchecked = " ";
}
if ( $a_row['helpcheck'] == "Y" ) {
	$helpchecked = "checked=\"checked\"";
} else {
	$helpchecked = " ";
}
?>

<td width="25%"><input type="checkbox" <?php print $notechecked; ?> name="notecheck" value="notecheck"> Notes </td>
<td width="25%"><input type="checkbox" <?php print $progchecked; ?> name="progcheck" value="progcheck"> Progress</td>
<td width="25%"><input type="checkbox" <?php print $hostchecked; ?> name="hostcheck" value="hostcheck"> Hosting</td>
<td width="25%"><input type="checkbox" <?php print $helpchecked; ?> name="helpcheck" value="helpcheck"> Helpful Docs</td>

<?php
//setting checkbox values
if ( ! empty( $notecheck ) ) 
{
	$notecheck = "Y";
} else { 
	$notecheck = "N";
}

if ( ! empty( $progcheck ) ) 
{
	$progcheck = "Y";
} else { 
	$progcheck = "N";
}

if ( ! empty( $hostcheck ) ) 
{
	$hostcheck = "Y";
} else { 
	$hostcheck = "N";
}

if ( ! empty( $helpcheck ) ) 
{
	$helpcheck = "Y";
} else { 
	$helpcheck = "N";
}
?>

cheers!
jason

[LordShryku]

I'd say definately use arrays, and maybe variable variables for the second set of statements.

[drawmack]

This should take care of it for you.
WARNING
This code is untested so probably has errors so I'm comenting it so you can debug it yourself.

<?php
//create an array that contains the names of 
//the variables as the keys and the
//printed name as the value.
$vars_ary = array(
    'notecheck' => 'Notes',
    'progcheck' => 'Progress',
    'hostcheck' => 'Hosting',
    'helpcheck' => 'Helpful Docs');

//loop through the keys of the array
//we just created
foreach(array_keys($vars_ary) as $chk_name) {
    //start the table cell and the checkbox 
    echo "<td width=\"25%\" > <input type=\"checkbox\" ";

//if the value in a_row is Y then
//print the checked code and set
//the value of a variable named
//after this key to Y
if($a_row[$chk_name] == "Y") {
    echo "checked=\"checked\" ";
    $$chk_name = "Y";
//otherwise just set the variable
//named after this key to N
} else {
    $$chk_name = "N";
}

//print the end of the checkbox and the display
//name then finish the table cell
echo "name=\"" . $chk_name . "\" value=\"" . $chk_name . "\"> ";
echo $vars_ary[$chk_name] . "</td>\n";
}
?>

don't forget to remove most of these comments as this code is seriously over comented.

[jasonmills58]

thanks for the input, I'll try those ideas out.

cheers!
jason