What;'s wrong with this code?

zzz

I need to pass value from list2. I realize it's going to be an array. Right now I'm not able to pass value. Period.

Here's the entire page - move.php (I was trying to attach teh values to the url to see if it posts it...)

<html>
<HEAD>
<SCRIPT LANGUAGE="JavaScript">
<!-- Begin
function move(fbox, tbox) {
var arrFbox = new Array();
var arrTbox = new Array();
var arrLookup = new Array();
var i;
for (i = 0; i < tbox.options.length; i++) {
arrLookup[tbox.options[i].text] = tbox.options[i].value;
arrTbox[i] = tbox.options[i].text;
}
var fLength = 0;
var tLength = arrTbox.length;
for(i = 0; i < fbox.options.length; i++) {
arrLookup[fbox.options[i].text] = fbox.options[i].value;
if (fbox.options[i].selected && fbox.options[i].value != "") {
arrTbox[tLength] = fbox.options[i].text;
tLength++;
}
else {
arrFbox[fLength] = fbox.options[i].text;
fLength++;
   }
}
arrFbox.sort();
arrTbox.sort();
fbox.length = 0;
tbox.length = 0;
var c;
for(c = 0; c < arrFbox.length; c++) {
var no = new Option();
no.value = arrLookup[arrFbox[c]];
no.text = arrFbox[c];
fbox[c] = no;
}
for(c = 0; c < arrTbox.length; c++) {
var no = new Option();
no.value = arrLookup[arrTbox[c]];
no.text = arrTbox[c];
tbox[c] = no;
   }
}
//  End -->
</script>
</HEAD>
<BODY>
<form action="move.php?list1=<? echo $list1; ?>&list2=<? echo $list2; ?>" method=post>
<table><tr><td>
<select multiple size="3" name="list1" style="width:100">
<option value="1">value1</option>
<option value="2">value2</option>
<option value="3">value3</option>
<option value="4">value4</option>
<option value="5">value5</option>
</select>
</td>
<td align="center" valign="middle">
<input type="button" onClick="move(this.form.list2,this.form.list1)" value="<<">
<input type="button" onClick="move(this.form.list1,this.form.list2)" value=">>">
</td>
<td>
<select multiple size="3" name="list2" style="width:100">
</select>
</td></tr></table>
<input type="submit">
</form>
</body>
</html>

Norman_Graham

Hi Zzz

This isn't how it works. The action is just "move.php". If you want to append query strings to the URL, you have to use GET, not POST.

Stick with POST - it's fine. The file move.php needs to pick up the form values thus:

$list1=$_POST["list1"];
$list2=$_POST["list2"];

Your form is passing empty variables via GET to a form validation which is expecting POST. The parameter name="list1" in your form is the value that is passed to move.php, which is why you pick it up in move.php.

Is that clear enough?

Norm

zzz

Thanks, good point. Thanks.

It still doen't really work. I think it's not passing the value somewhere in js. Just copy the entire code in a page and you'll see what I meant.

zzz

I am stil not able to capture the values of list2. Is it because it passes the options from box to box and not the values?

Norman_Graham

As far as I can make out, list2 is nothing at all. You have a <select> input, but with no options, so the user can't choose anything. That's why $list2 is empty. List1, on the other hand, has five <option> tags.

HTH

Norm

zzz

List 2 is pupolated by pushing values from list 1. It's all done with JS. Copy the code into a single file, call it move.php and you'll be able to see it in all it's glory.

coppercoins

If you are using a method=post, you don't need to append anything to the action of the form. The variables are passed onSubmit to the action reference. Just start using them on the action reference and they will be there populated with the values reflected by selection in the form.

SuperCam

Cahnge your form action to
<form action="move.php" method=post>
and add:
<input type="hidden" name="list1" value="<? echo $list1; ?>">
<input type="hidden" name="list2" value="<? echo $list2; ?>">