this is my code..what i do the long way?

[zapa]

this is my newbie codeing, how can i improve this?

<?
 if($HTTP_POST_VARS['submit']) {
	    if($HTTP_POST_VARS['password'] == "123" & $HTTP_POST_VARS['username'] == "abc"){
		echo '<form name="form1" method="post" action="linka.php">';
		echo '<input name="submit" type="submit" id="submit" value="Enter Nilesh >>">';
		echo '<input name="upplanpass" type="hidden" id="upplanpass" value="plan1">';
		echo '</form></head></html>';
		exit;}
	    elseif($HTTP_POST_VARS['password'] == "Dr" & $HTTP_POST_VARS['username'] == "Wi"){ 
		echo '<form name="form1" method="post" action="linkb.php">';
		echo '<input name="submit" type="submit" id="submit" value="Enter Will >>">';
		echo '<input name="upplanpass" type="hidden" id="upplanpass" value="plan2">';
		echo '</form></head></html>';
		exit;}
		elseif($HTTP_POST_VARS['password'] == "Da" & $HTTP_POST_VARS['username'] == "Ar"){ 
		echo '<form name="form1" method="post" action="linkc.php">';
		echo '<input name="submit" type="submit" id="submit" value="Enter Avishkar >>">';
		echo '<input name="upplanpass" type="hidden" id="upplanpass" value="plan3">';
		echo '</form></head></html>'; 
		exit; }
		else {
		 echo "<strong>Log-In Incorrect! </strong><br>username or password. <br> ";
		 }
		}
		?>

<form name="form1" method="post" action="<?=$PHP_SELF?>">
  <p>
    <strong>- Admin Log-In only - <br>
    ID:</strong>    

    <input name="username" type="text" id="username" size="14" maxlength="10">
</p>
  <p><strong>
    code:
        <INPUT NAME="password" TYPE="password" SIZE="12" maxlength="10">
  </strong> </p>
  <p>
    <input name="submit" type="submit" id="submit" value="submit">
</p>
</form>
 

I am sure i could cut repating code, whats a good way doing this. Fuctions (i guess)?

thanks

[planetsim]

Way to many echo's you dont need an echo statement for each new line

This

echo '<form name="form1" method="post" action="linka.php">';
        echo '<input name="submit" type="submit" id="submit" value="Enter Nilesh >>">';
        echo '<input name="upplanpass" type="hidden" id="upplanpass" value="plan1">';
        echo '</form></head></html>'; 

Can be

echo '<form name="form1" method="post" action="linka.php">
<input name="submit" type="submit" id="submit" value="Enter Nilesh >>">
        <input name="upplanpass" type="hidden" id="upplanpass" value="plan1">
        </form></head></html>'; 

Also use && not just & or even AND

[weevil]

You don't really need a function. You want to put your form inside the body tag, not the head tag. Also, if you use single quotes your echo statements will echo the variable names rather than the variable values. I prefer heredoc syntax to echo blocks of code, but that is just a personal preference.

I am assuming you are running PHP 4.1 or higher and the opening html and body tags are higher up in your script.

<?php
If ($_POST['submit'] {
   if($_POST['password'] == "123" && $_POST['username'] == "abc"){
     $action = "a";
     $character = "Nilesh";
     $plan_num = "1";
   } else if  $_POST['password'] == "Dr" & $_POST['username'] == "Wi"){  

     $action = "b";
     $character = "Will";
     $plan_num = "2";
   } else if  $_POST['password'] == "Da" & $_POST['username'] == "Ar"){  

     $action = "c";
     $character = "Avishkar";
     $plan_num = "3";
   } else {
      $loginfailed = "<strong>Log-In Incorrect! </strong><br>username or password. <br>";
   }
    If ($loginfailed) {
      echo "$loginfailed";
    } else {
      echo <<<END
<form name="form1" method="post" action="link$action.php"> 
  <input name="submit" type="submit" id="submit" value="Enter $character >>"> 
  <input name="upplanpass" type="hidden" id="upplanpass" value="plan$plan_num">
</form>
END;
    } 
    echo "</body></html>";
    exit;
}
?>

Your other form looks fine.

[zapa]

planetsim and weevil thank you!

sure am glad phpbuilder is around.