Problem with variables

[golfinggod]

Hi can anyone see a problem with this code. Im trying to set the variables Height and Width to alter depending upon $Size.

The variables are then echoed in the html at the bottom to determine the size of the image. The problem is they are not setting and the image isnt going to the required sizes.

$Size =  $HTTP_POST_VARS['Size'];  

  if ( $Size == 468 ) {

  $Width = 468;
  $Hight = 60;

  }
   if ( $Size == 234 ) {

  $Width = 234;
  $Hight = 60;

  }	

   if ( $Size = 12090 ) {

  $Width = 120;
  $Hight = 90;

  }
  if ( $Size = 12060 ) {

  $Width = 120;
  $Hight = 60;

  }
  if ( $Size = 120240 ) {

  $Width = 120;
  $Hight = 240;

  }
  if ( $Size = 125125 ) {

  $Width = 125;
  $Hight = 125;

  }
  if ( $Size == 8831 ) {

  $Width = 88;
  $Hight = 31;

  }
  if ( $Size = 15038 ) {

  $Width = 150;
  $Hight = 38;

  }


	  echo "
	  <table width=43% border=\"0\" cellspacing=\"0\" cellpadding=\"0\">
                <tr> 
                  <td width=\"11%\" height=\"25\"><div align=\"center\"><img src=\"Images/square.gif\" width=\"6\" height=\"6\"></div></td>
                  <td width=\"89%\" height=\"25\" class=\"Report-Text\"><u>Banner 
                    Information</u></td>
                </tr>
                <tr> 
                  <td height=\"23\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Banner ID : <span class=\"Box-Results\">$Bannerid</span> 
                  </td>
                </tr>
                <tr> 
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Banner Name : <span class=\"Box-Results\">$Bannername</span></td>
                </tr>
                <tr>
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Banner Address : <span class=\"Box-Results\">$Bannerurl  </span>      <a href=\"$Bannerurl\" class=\"Box-Results\" >Test</a></td>
                </tr>
                <tr> 
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Total Banner Impressions 
                    : <span class=\"Box-Results\">$Bannerdisplays</span></td>
                </tr>
                <tr> 
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Total Banner Clicks 
                    : <span class=\"Box-Results\">$Bannerclicks</span></td>
                </tr>
                <tr> 
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">Banner size : <span class=\"Box-Results\">234 
                    * 60 Pixels</span></td>
                </tr>
                <tr> 
                  <td height=\"73\">&nbsp;</td>
                  <td height=\"73\" class=\"Report-Text\"><img src=\"$Imageurl\" width=\"$Width\" height=\"$Height\"></td>
                </tr>
                <tr> 
                  <td height=\"19\">&nbsp;</td>
                  <td height=\"25\" class=\"Report-Text\">&nbsp;</td>
                </tr>
              </table>";
	  

[sks1024]

your variables are spelled wrong

you have $hight = 120

and in the table the variable is spelled $height

change the variable hight in the if statements to height and it will work

if ( $Size == 468 ) { 

  $Width = 468; 
  $Hight = 60;


<img src=\"$Imageurl\" width=\"$Width\" height=\"$Height\">

[devinemke]

just a suggestion to clean up your code: store all those numbers in an array:

$dimensions = array (
	468 => array ('width' => 468, 'height' => 60),
	234 => array ('width' => 234, 'height' => 60),
	12090 => array ('width' => 120, 'height' => 90),
	12060 => array ('width' => 120, 'height' => 60),
	120240 => array ('width' => 120, 'height' => 240),
	125125 => array ('width' => 125, 'height' => 125),
	8831 => array ('width' => 88, 'height' => 31),
	15038 => array ('width' => 150, 'height' => 38)
);

echo '<img src="' . $Imageurl . '" width="' . $dimensions[$_POST['size']]['width'] . '" height="' . $dimensions[$_POST['size']]['height'] . '">';

[seby]

why use unnecessary memory? you should only use arrays when really needed, otherwise its better to use a switch.