does this case statement look correct???

[aron]

<?
.... connection

if($order == 'id'){
$ad = "DESC";
}else{
$ad = "ASC";
}

$type_select = ("'Business', 'House', 'Apartment', 'Acreage', 'Duplex', 'Rental House', 'Rental Unit', 'Commercial Retail', 'Commercial Offices', 'Commercial Industrial', 'Retirement', 'Riverfront Home', 'Studio', 'Townhouse', 'Unit', 'Villa'");
if($nav == 'simsub'){
$price_low = $pview - 50000;
$price_high = $pview + 100000;
switch ($sview)
{
case 'ANSTEAD' || 'PULLENVALE' || 'BROOKFIELD' || 'UPPER BROOKFIELD' || 'PINJARRA HILLS':
$set_1 = ("'ANSTEAD', 'PULLENVALE', 'BROOKFIELD', 'UPPER BROOKFIELD', 'PINJARRA HILLS'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'BELLBOWRIE' || 'MOGGILL' || 'KARANA DOWNS' || 'KARALEE' || 'MOUNT CROSBY':
$set_1 = ("'BELLBOWRIE', 'MOGGILL', 'KARANA DOWNS', 'KARALEE', 'MOUNT CROSBY'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'AUCHENFLOWER' || 'BARDON' || 'INDOOROOPILLY' || 'MILTON' || 'ST LUCIA' || 'TARINGA' || 'TOOWONG':
$set_1 = ("'AUCHENFLOWER', 'BARDON', 'INDOOROOPILLY', 'MILTON', 'ST LUCIA', 'TARINGA', 'TOOWONG'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'CAMIRA' || 'CHUWAR' || 'KARALEE' || 'KARANA DOWNS' || 'MOUNT CROSBY' || 'PINE MOUNTAIN':
$set_1 = ("'CAMIRA', 'CHUWAR', 'KARALEE', 'KARANA DOWNS', 'MOUNT CROSBY', 'PINE MOUNTAIN'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'KENMORE' || 'KENMORE HILLS' || 'CHAPEL HILL' || 'FIG TREE POCKET' || 'INDOOROOPILLY':
$set_1 = ("'KENMORE', 'KENMORE HILLS', 'CHAPEL HILL', 'FIG TREE POCKET', 'INDOOROOPILLY'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'WINDAMERE' || 'WESTLAKE' || 'SINNAMON PARK' || 'RIVERHILLS' || 'MOUNT OMMANEY' || 'MIDDLE PARK' || 'JINDALEE' || 'JAMBOREE HEIGHTS':
$set_1 = ("'WINDAMERE', 'WESTLAKE', 'SINNAMON PARK', 'RIVERHILLS', 'MOUNT OMMANEY', 'MIDDLE PARK', 'JINDALEE', 'JAMBOREE HEIGHTS'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'CHELMER' || 'CORINDA' || 'GRACEVILLE' || 'SHERWOOD':
$set_1 = ("'CHELMER', 'CORINDA', 'GRACEVILLE', 'SHERWOOD'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
case 'OXLEY' || 'DARRA' || 'DOOLANDELLA' || 'FOREST LAKE' || 'SPRINGFIELD' || 'SPRINGFIELD LAKES':
$set_1 = ("'OXLEY', 'DARRA', 'DOOLANDELLA', 'FOREST LAKE', 'SPRINGFIELD', 'SPRINGFIELD LAKES'");
$sql = "SELECT FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) AND suburb NOT IN ($set_1) AND price BETWEEN $price_low AND $price_high ORDER BY $order";
break;
default:
echo "Error";
}
}else{
$sql = "SELECT * FROM Listings WHERE status<>'sold' AND type NOT IN ($type_select) ORDER BY $order $ad";
}
$sql_result = mysql_query($sql,$connection) or die ("Could not connect to database");
$rows = mysql_num_rows($sql_result);
?>

[bubblenut]

No.
Bubble
PS (please put php code in [\p\h\p] [\/\p\h\p] tags (minus the backslashes of course)

[bubblenut]

I'm guessing that's not the answer you're looking for.
With switch statements you place the cases one after the other without a break in between to match more than one condition (there's a special name for this but I can't remember it at the moment, help anyone?)
It looks something line this.

<?php
switch($string) {
  case 'one':
  case 'two':
    //exectured for both one and two
    break;
  case 'three':
    //executed for three
  case 'four':
    //exectured for four
  case 'five':
    //executed for five and continued execution of four
    break;
}
?>

HTH
Bubble

[aron]

but i used a if else statement instead.