whats wrong with this select sql ??

[aron]

$sql = "SELECT *
FROM Listings
WHERE status!='sold'
AND suburb IN (".$sql_2.")
AND price BETWEEN ".$pricefrom." AND ".$priceto."
AND beds BETWEEN ".$bedfrom." AND ".$bedto."
AND land_area BETWEEN ".$landfrom." AND ".$landto."
AND baths<= ".$bath."
AND lugarage<= ".$lug.""
if ($pool != ""){
echo "AND pool = ".$pool;
}
"ORDER BY '".$order."'";
echo $sql;

its this part.
if ($pool != ""){
echo "AND pool = ".$pool;
}

see i have a a select box that the user selects N/A , Yes, No

Yes and No have values in my database
Yes = 1
No = 0

but N/A dosent its value in the form is.

<option value="" selected>N/A</option>
                        <option value="0">No</option>
                        <option value="1">Yes</option>
                        </select>

so what im trying to do above is if the value of pool is = to "" then dont write that line else write it.

cheers aron.

[findapollo]

if you're trying to set the $sql string
you'd need to do it like this:

$sql = "SELECT * FROM Listings ....";

if ($pool != "")
$sql .= "AND pool = ".$pool;

$sql .= "ORDER BY ....";

echo $sql;

The way you were doing it the if would not get evaluated inside the assignment (=). The only way to do it that way would possibly be:
$sql = "SELECT ..".(($pool)?$pool:"")."ORDER BY ..";

that second method is tricky but should work with some testing.

Hope i answered the right question,
findapollo

[aron]

ahh cool it worked thanks.