php by Example :Toby Butzon

seanstuart

Trying a Example on page 147: Listing 7.1 feedback form. When the page loads its BLANK????? Why?

<?php 

// Make reference to form variables
$form =& $HTTP_POST_VARS;

// Define configuration settings
define('FEEDBACK_TO','sean@rushcliffehomes.co.uk');//email for webmaster
define('FEEDBACK_SUBJ','Feedback:');//subject prefix

switch ($form['step']) // decide what to do based on step
{
	case "1":              // if step is one 1, or if
	default:						 // no known step is specified, display the form	 

 ?>

<html>
<head>
<title>Feedback Form</title>
</head>
<body>
<div>
<h2>Feedback Form</h2>
<form action="<?php= $PHP_SELF ?>" method="post">
<input type="hidden" name="step" value="2" />
<b>Name:</b><br>
<input type="text" name="feedback_name" /><br><br>
<b>Email:</b><br>
<input type="text" name="feedback_email"/><br><br>
<b>Subject:</b><br>
<select name="feedback_subj">
<option selected>Comment</option>
<option>Complaint</option>
<option>Suggestion</option>
</select><br><br>
<b>Message:</b><br>
<textarea name="feedback_msg" rows="5" cols="40"></textarea><br><br>
<input type="submit" value="Continue"></button>
</form>
</div>
</body>
</html>

<?php 
				break; // end of case 1 / default for switch ($form['step'])

case "2":								// show user their submission for reveiw
 ?>

 <html>
<head>
<title>Feedback Form: Review your submission</title>
</head>
<body>
<div>
<h2>Feedback Form: Review your submission</h2>
<b>Name:</b><br>
<?= $form['feedback_name'] ?><br><br>
<b>Email:</b><br>
<?= $form['feedback_email'] ?><br><br>
<b>Subject:</b><br>
<?= $form['feedback_subj'] ?><br><br>
<b>Message:</b><br>
<?= $form['feedback_msg'] ?><br><br>

<form action="<?PHP= $PHP_SELF ?>" method="post">

<input type="hidden" name="step" value="3" />
<input type="hidden" name="feedback_name" value="<?php= $form['feedback_name'] ?>" />
<input type="hidden" name="feedback_email" value="<?php= $form['feedback_email'] ?>" />
<input type="hidden" name="feedback_subj" value="<?php= $form['feedback_subj'] ?>" />
<input type="hidden" name="feedback_msg" value="<?php= $form['feedback_msg'] ?>" />
<input type="button" value="Back" onclick="javascript:history.go(-1);" />
<input type="submit" value="Send" />
</form>
 </body>
</html>

<?php 
				break; // end of case 2 for switch ($form['step'])

	case "3":       // send feedback and show thank you page

//send feedback
			$feedback_subj = FEEDBACK_SUBJ . $form['feedback_subj'];
		  $feedback_body = <<<END
		Name:    {$form['feedback_name']}
		Email:   {$form['feedback_email']}
		Subject: {$form['feedback_subj']}
		Message: {$form['feedback_msg']}
		END;

			mail(FEEDBACK_TO, $feedback_subj, $feedback_body);

 ?>
<html>
<head>
<title>Thank You</title>
</head>
<body>
<h2>Feedback Form</h2>
<h4>Thank You</h4>
Your feedback has been sent"

</body>
</html>

<?php 
			break; // end of case 3 for switch ($form['step'])

	}	
 ?>

regards Sean Stuart U.K

:mad:

Volitics

Sounds like maybe you're missing possibly a semicolor or a quote mark somewhere.

What you might need to do is narrow your code down and test it piece by piece. That way you can zero in on what's causing your page to not process.

I can suggest that you might want to consider looking into using templates to design your web site. With a template design you don't have to mix your PHP code in with the Html and it makes it easier to de-bug.

There is at least one book that has pre-written classes and template code that you can use to incorporate into your web site. You can also find examples of classes and things on the Internet.

planetsim

Originally posted by Volitics
Sounds like maybe you're missing possibly a semicolor or a quote mark somewhere.

What you might need to do is narrow your code down and test it piece by piece. That way you can zero in on what's causing your page to not process.

I can suggest that you might want to consider looking into using templates to design your web site. With a template design you don't have to mix your PHP code in with the Html and it makes it easier to de-bug.

There is at least one book that has pre-written classes and template code that you can use to incorporate into your web site. You can also find examples of classes and things on the Internet.

Why does he need to get a template class, he is clearly writing some code from the book which isnt working, i suggest go to the publisher/authors website and see if there have been updates to the code.

Volitics

It depends on the book. The book I got template and class information from was PHP Advanced for the World Wide Web written by Larry Ullman and published by Peachpit Press.

It's a matter of preference. PHP is, of course, written to enable programmers to mix code with Html. Obviously, there's nothing the matter with mixing PHP and Html.

He still needs to, in my opinion, break the code down and test it in pieces.

dave420

You're probably using a higher version of PHP, so the first line needs changing. $HTTP_POST_VARS was removed some time ago. Replace that with $_GET.

// Make reference to form variables 
$form =& $_GET;