Problem using recordset returned from a function in a class

[miraclewhipkey]

I have done some searching, but haven't been able to put together a query that finds what I'm looking for, so here goes:

I have a Class called UserAdmin, which looks like this:

class UserAdmin { 
 //Database connection
 var $db;

/***************************************
*	Purpose:	constructor function
*	Returns:	n/a
***************************************/
 function UserAdmin(&$db) { 
   $this->db = &$db;
 }

/****************************************
*	Purpose:	gets all the groups in the DB
*	Returns:	a recordset of groups
****************************************/
 function viewGroups() { 
   $sql = "SELECT * FROM " . GROUP_TABLE; 
    if ($result = $this->db->query($sql)) {
      return $result->fetch();
   } else {
      return "failure";
   }
 }

$db is another class that has already been instantiated.

I want the function to return the equivalent of your normal mysql_fetch_array(mysql_query($sql)). So on the page I can do this:

if ($userAdmin->viewGroups() == "failure") {
	 	echo "failure";
	 } else {
	 	while ($rstGroups = $userAdmin->viewGroups()) {
			echo $rstGroups['GrupoName'] . "<br>";
		}
	 }

Right now, I am getting stuck in a loop. It takes the first record in that recordset, and writes it over and over again. However, if I put a while loop inside the function viewGroups() and echo the same column, it writes them out just fine. The problem with that is that I can't manipulate the way I use or display those values.

How do I pass a recordset created inside a function, which is inside a class, and have full use of that recordset on the outside page?

thanks for any help.

cheers,
Clay

[barand]

You need to get the function viewGroups() to return next row instead of new query and first row each time

var $view_result = false;  // class var to store the result resource

function viewGroups() {
    if (!this->$view_result) {

    $sql = "SELECT * FROM " . GROUP_TABLE;  
    if ($this->view_result = $this->db->query($sql)) { 
      return $this->view_result->fetch(); 
   } else { 
      return "failure"; 
   } 

} else {
      return $this->view_result->fetch(); 
}

}

[miraclewhipkey]

Thanks for that. I'll give it a try and let you know what happens.

cheers,
Clay

[miraclewhipkey]

Sorry to say that didn't work. I was able to pass the resultset out of the method to the page, but it still just looped forever writing the first record.

However, after searching around and observing several DB classes other people had written, I didn't see anyone actually passing the resultset, but rather loading that resultset into an array, and passing the array.

I did that, and it works like a charm. Observe:

 function result_to_array($sql) { 
   if ($result = $this->query($sql)) {
	 $res_array = array();
      for ($count=0; $rst = $result->fetch(); $count++) {
        $res_array[$count] = $rst;
      }
	 return $res_array;
   } else {
      return FALSE;
   } 
 }

That was the function placed in the MySQL class (a.k.a. $db). Here is how I use it in my other method:

 function viewPermissions() { 
   $sql = "SELECT * FROM " . PERM_TABLE; 
   return $this->db->result_to_array($sql);
 }

Then, when I call it on a page, I just do something like this:

foreach ($userAdmin->viewPermissions() as $rstPermissions) {
     //do something with the data
     echo $rstPermissions[PERM_ID]."<br>";
     echo $rstPermissions[PERM_NAME]."<br>";
}

Anyway, it is working great like that so I am happy. I just wanted to make sure I gave the feedback, in appreciation for the effort to help.

cheers,
Clay