Class Help

Sharif

Okay, on errors.php, I have the following class:

//Errors Class 
class Errors 
{
	//For database errors
	function db_error($code)
	{
		switch($code)
		{
			//If a connection to host could not be made
			case 1: $message = 'A connection to the host could not be made!'; break;

		//If the database couldn't be selected
		case 2: $message = 'The database could not be selected!'; break; 
	}

	//Display message
	echo '<b>' . $message . '</b>'; 
}
}

//Initialize errors class object
$ERROR = new Errors;

In mysql.php, I have the following:

//MySQL Connection Function
function connect()
{
	global $ERROR;

// Switch database connection types (between persistent and non persistent)
switch($type) 
{
	case 1: $connection = mysql_connect($host, $user, $pass); break;
	case 2: $connection = mysql_pconnect($host, $user, $pass); break;
}

if(!$connection) // If a connection couldn't be made...
{
	$ERROR->db_error(1);
	error_mail();
	exit();
}
else
{
	//Select database
	$select = mysql_select_db($db, $connection); 

	// If database couldn't be sellected...
	if(!$select) 
	{
		$ERROR->db_error(2);
		error_mail();
		exit();
	}
}
}

Then in index.php. I do the following:

include('errors.php');
include('mysql.php');

connect(1, 'localhost', '123', 'pwd', 'my_db');

This is the error I get:

Fatal error:Call to a member function on a non-object in /home/oox/public_html/beta/sources/mysql.php on line 16

My question is, why am I getting this error? I mean I set $ERROR to use the Errors class.

barand

Initial observation is that the defined connect() has no arguments but you call

connect(1, 'localhost', '123', 'pwd', 'my_db');

and which line is #16?

Sharif

Yea I noticed that after I posted, even after setting arguments it gives me that error. Line #16 is $ERROR->db_error(1).

barand

Should it be

$ERROR = new ErrorsCOLOR=orangered[/COLOR] ;

Sharif

Ok I changed the object to $ERROR = new Errors(). I specified arguments, and now I get the same error but for line 28, which is $ERROR->db_error(2).

barand

I tried duplicating your code - the error I get is on error_mail().

Sharif

I don't understand what could be wrong. I mean is there any error in the class itself?

swr

When you get a message "Call to a member function on a non-object" it usually means the object you are trying to access is null. It could also mean it's a string or something.

Are you sure $ERROR is set? Is it possible something else is using a global variable called $ERROR and setting it to something unexpected?

Try print_r($ERROR) at the relevant point and see what you get.

Sharif

I did print_r($ERROR) but got nothing.

swr

So $ERROR is null, or "".

Have you posted all of your code? Something is going on that doesn't match the code you have posted.

Sharif

I am positive I did. Why is $ERROR null? I mean I defined it as an object.

ahundiak

All I can say is to double check your spelling. Try setting:
error_reporting(E_ALL);

This code works as expected:

<?php
class Error
{
  function hello()
  {
    echo "hello\n";
  }
}
$ERROR = new Error;

function connect()
{
  global $ERROR;
  $ERROR->hello();
}
connect();
?>

Sharif

Could it be because the object is declared in a different file?

barand

Are you sure the files are being included OK?

Put

echo "Errors.php included OK<br>";

at beginning of 'errors.php' and see if the line is echoed as expected