Need assistance with while loop to rotate bg colors

AshleyQuick

Below is the snippet of code. I'd like to rotate <td align=center class=reverseeven> and <td align=center class=reverseodd>. I've reached an impasse.. 🙁

<table class="reverse" rules="rows" style="width: 90%">
	<tr> 
		<td class="reversetitle">File Description</td>
		<td align="center" class="reversetitle">Downloads</td>
		<td align="center" class="reversetitle">Last Download</td>
	</tr>
	<?php 
	include_once ("download_cfg.php");
	$handle = @opendir("$dircount"); 
	if ($handle==FALSE){
	echo "Error:no counter directory [$dircount] found";
	return;
	}   

	$files = array();
	$cnt = 0 ;

while(false!==($file=readdir($handle))){
if ($file!='.' && $file!='..' && $file!=".htaccess"){
$files[$cnt] = $file;
$cnt = $cnt + 1;
}
}
closedir ($handle);
sort($files);
for ($cnt=0;$cnt<count($files);$cnt++) {
$filenm   = $dircount.$files[$cnt];
$fd       = fopen ($filenm , "rb");
$fcounter   = explode("::",fgets($fd, 1024));

fclose($fd);
// display file name and the counter.
echo "<tr><td class=reverseeven>$fcounter[1]</td>";
$files[$cnt]=substr($files[$cnt],0,strlen($files[$cnt])-4);
echo "<td align=center class=reverseeven>$fcounter[0]</td>";
$filemodtime = date("F j, Y ", filemtime($filenm ));
echo "<td align=center class=reverseeven>$filemodtime</td></tr>";   
} ?>
</table>

Weedpacket

Have you tried searching these forums? Something like alternating row colors, perhaps?

AshleyQuick

I have searched. Every example I've seen here requires db access, which I do not have. How can this be accomplished without it? (I should've clarified)

Ash

twcmad

This is an example of how I have got around this. I have modified it to include the code you posted.

Is this of any help

$i = 1;

while(your loop)
{

         fclose($fd); 
        // display file name and the counter.
        $class="reverseeven";
        if (is_int($i/2)) { $class="reverseodd";}

       echo "<tr><td class=$class>$fcounter[1]</td>"; 
$files[$cnt]=substr($files[$cnt],0,strlen($files[

$cnt])-4);
echo "<td align=center class=$class>$fcounter[0]</td>";
$filemodtime = date("F j, Y ", filemtime($filenm ));
echo "<td align=center class=$class>$filemodtime</td></tr>";

            $i ++;
}

TWCMAD

Weedpacket

Originally posted by AshleyQuick
I have searched. Every example I've seen here requires db access, which I do not have. How can this be accomplished without it? (I should've clarified)

Ash

No they don't; sure, all those examples happen to be in scripts that use databases, but that's got nothing to do with being able to tell if a number is even or odd. twcmad's just given you the same solution again (only in a less efficient form, as it unnecessarily resorts to floating point arithmetic).

One of the things you need to learn as a programmer looking at other people's code is how to work out what the code is doing.

twcmad

weedpacket,

am new to php and kinda muddle my way around. Love the lauange and have never coded in any thing before.

How would you do it ?

Am very keen to learn anything I can.

Thanks

TWCMAD

Weedpacket

$even_colour = 'even colour';
$odd_colour = 'odd colour';
$even=true;
//...start loop...
{
	//...
	if($even==false)
	{	$background_colour = $even_colour;
		$even=true;
	}
	else
	{	$background_colour = $odd_colour;
		$even=false;
	}
	//...
}

$even_colour = 'even colour';
$odd_colour = 'odd colour';
$background_colour=$even_colour;
//...start loop...
{
	//...
	if($background_colour==$even_colour)
		$background_colour = $odd_colour;
	else
		$background_colour = $even_colour;
	//...
}

Or, if I have a loop variable $i handy...

$even_colour = 'even colour';
$odd_colour = 'odd colour';
//...start $i loop...
{
	//...
	$background_colour = ($i&1) ? $odd_colour : $even_colour;
	//...
}

Where ($i&1) is equivalent to ($i%2==1) ....

$even_colour = 'even colour';
$odd_colour = 'odd colour';
$even = true;
//...start $i loop...
{
	//...
	$background_colour = ($even=!$even) ? $odd_colour : $even_colour;
	//...
}

if I was being obtuse. There's probably a whole bunch of others, all on the same theme.

twcmad

Thanks heaps,

I can see many bits of code that I have used that needs changing now. I like the fact that many of your examples do not use numbers at all.

TWCMAD

stevesweetland

it doesnt even need to be that complex....

use a variable $color... and simply use this one line of code :

$color= $color=="#EEEEEE"?"#FFFFFF":"#EEEEEE";

this is a neat, 1 line way of saying

if ($color == "#EEEEEE"){
  $color = "#FFFFFF";
} else { // $color ISNT "#EEEEEE"
  $color = "#EEEEEE";
};

you can substitute your html strings for varibles if you want... like

$color = $color=="$htmlcolor1"?"$htmlcolor2":"$htmlcolor1";

Weedpacket

Originally posted by stevesweetland
it doesnt even need to be that complex....

That's more complex; I use simpler syntax for didactic purposes.

stevesweetland

Originally posted by Weedpacket
That's more complex; I use simpler syntax for didactic purposes.

ok, what i mean is 'you can accomplish that in less lines of code... '

in the interests of helping another programmer, who will benefit from understanding how to use the ternary operator. i never had it explained to me by example, i just had to figure it out.... jus tryin to help in the bigger picture.

to give an answer beyond what someone asks for, thinking this is likely to help in the long run, is really what is the nature of didacticism.

else youd just be answering a question.

not hassling, if you think i should give the easiest answer, then cool - let me know im not the mod!

Weedpacket

Note my last example. I'll point out that there are a couple of coding practice worries. First,

echo "$variable";

is exactly equivalent to

echo $variable;

except the first is slower and requires PHP do much more work. Second, I personally have a problem with, e.g.,

$color= $color=="#EEEEEE"?"#FFFFFF":"#EEEEEE";

because to change one of the colours requires at least two changes to the script, and possibly three, for each set of alternating rows. Save the duplication and break them out into variables that can be adjusted.

stevesweetland

ok cool. :rolleyes: