[Resolved] Updating with php and Oracle

[amrigo]

I am not sure about the correct way to update with Oracle and php, my following script says as error message:
SQL command not properly closed

$conn = ocilogon ("xxx", "xxx", "xxx");
$stmt = ociparse ($conn, "UPDATE TABLE SET COD='$POST[COD]' DESC='$POST[DESC]' WHERE COD='$_POST[COD]'");
ociexecute($stmt);
if (ocifetch($stmt)){
echo "<ul>";
echo "<li><strong>Cód: </strong>".ociresult ($stmt, "COD") ."</li>";
echo "<li><strong>Desc: </strong>".ociresult ($stmt, "DESC") ."</li>";
echo "</ul>";
}
ocifreestatement($stmt);
ocilogoff($conn);

What´s the right way to use UPDATE with PHP and Oracle?

Thank´s in advance

[LordShryku]

You need to either break your superglobals out of the string or enclose them in braces. Nothing to do with Oracle. You also need commas between your update element. Also nothing with Oracle specifically. That's just basic sql. Ether of these should work.

$stmt = ociparse($conn, "UPDATE TABLE 
                            SET COD='".$_POST['COD']."',
                                DESC='".$_POST['DESC']."' 
                          WHERE COD='".$_POST['COD']."'");

$stmt = ociparse($conn, "UPDATE TABLE 
                            SET COD='{$_POST['COD']}',
                                DESC='{$_POST['DESC']}' 
                          WHERE COD='{$_POST['COD']}'");

[amrigo]

Thank´s a lot LordShryku
i do think the second way is more clean
there is some reference on this kind of syntax on www.php.net ?

Best regards

[amrigo]

it is working! the values are updated but it brings an error message:

ocifetch(): OCIFetch: ORA-24374: define not done before fetch or execute and fetch

Below is my code

$conn = ocilogon ("xxx", "xxx", "xxx");
$stmt = ociparse ($conn, "UPDATE TABLE SET COD='{$POST['CODIGO']}', DESC='{$POST['DESC']}' WHERE COD='{$_POST['COD']}'");
ociexecute($stmt);
if (ocifetch($stmt)){
echo "<ul>";
echo "<li><strong>Code: </strong>".ociresult ($stmt, "COD") ."</li>";
echo "<li><strong>Description: </strong>".ociresult ($stmt, "DESC") ."</li>";
echo "</ul>";
}
ocifreestatement($stmt);
ocilogoff($conn);

[LordShryku]

Because there's nothing to fetch, so ocifetch is not really being used. You can remove that line and use the if in the above line.
if(ociexecute($stmt)) {

http://www.php.net/manual/en/language.types.string.php
Contains a little bit about using braces around variables

[amrigo]

Thank´s a lot!!
now is everything working right!!

Cheers