[Resolved] blank $_FILES

[MaxD]

I'm trying to upload files through my script. I have a form with the proper ENCTYPE, and it submits to my upload script:

function upload(){
  if(!empty($_FILES["userfile"])) { 
    $uploaddir = "/upload/";
    if (move_uploaded_file($_FILES["userfile"]["tmp_name"], $uploaddir . $_FILES["userfile"]["name"])) {
      echo("file uploaded");
    } else {
      echo ("error!");
    }
  } 
}

but the form never passes the file to the script. Is there something simple I'm missing?

note: the form contains another <input> field, would that foul things up? I did try removing that field, but it didn't help any, just thought I'd mention it.

[Xoid]

you need to pass the $_FILE data into the function for it to work.

<?php
function upload($getfiles)
{
if(!empty($getfiles))
{

$uploaddir = "/upload/";
if (move_uploaded_file($getfiles["tmp_name"], $uploaddir . $getfiles["name"])) {
echo("file uploaded");
} else {
echo ("error!");
}
}

}

upload($_FILES["userfile"]);

?>

[Weedpacket]

Originally posted by Xoid
you need to pass the $FILE data into the function for it to work.

Er, no; $FILES is already available.

The additional form fields shouldn't be a problem (the submit button is a form field as well, after all), and should continue to be in $_POST.

You say that "the form never passes the file to the script"; what happens instead? The script fails to do anything, or it errors in some way? Add a wee bit to the function for testing:

function upload(){
  if(!empty($_FILES["userfile"])) { 
    $uploaddir = "/upload/";
    if (move_uploaded_file($_FILES["userfile"]["tmp_name"], $uploaddir . $_FILES["userfile"]["name"])) {
      echo("file uploaded");
    } else {
      echo ("error!");
    }
  } 
  else echo "No file uploaded.";
}

Just to check if $_FILES['userfile'] really is empty (and while I'm about it, I'd check to make sure the field name is correct!)

[AstroTeg]

Originally posted by Weedpacket
Er, no; $_FILES is already available.

The server I'm on has PHP setup so $FILES is not globally available. Putting in: global $FILES had it working from within a function. But I'm not a huge fan of global variables so I opted to pass it to the function instead (as Xoid mentioned).

[Weedpacket]

Originally posted by AstroTeg
The server I'm on has PHP setup so $FILES is not globally available. Putting in: global $FILES had it working from within a function. But I'm not a huge fan of global variables so I opted to pass it to the function instead (as Xoid mentioned).

TBH I wasn't aware you could do that: the only alternatives I knew were (a) prevent file uploads completely, or (b) use a pre4.1 version of PHP. Didn't know you could disable superglobals - how's that managed? Not that I can think of a use for it, but it would be nice to know.

[yelvington]

Yah, that doesn't sound right. Superglobals are superglobals, period.

Be sure you have the form properly set as
enctype="multipart/form-data" ... if you don't, the superglobal array may not be populated properly.

[Xoid]

My code is correct, I've tested it.

I've tested passing the data to the function and without it works passing $_FILES into the function.

[MaxD]

all the code works fine, I just had to "global $userfile;" for it to work.

:-P

thanks all

[Xoid]

or pass $_FILES into the function :oP

[Weedpacket]

Originally posted by Xoid
or pass $FILES into the function :oP

Have you tried to use $FILES[] in a function in your code without passing it?

[Xoid]

I have yeah,

I used the code of MAXD:

function upload(){ 
  if(!empty($_FILES["userfile"])) {  

    $uploaddir = "/upload/"; 
    if (move_uploaded_file($_FILES["userfile"]["tmp_name"], $uploaddir . $_FILES["userfile"]["name"])) { 
      echo("file uploaded"); 
    } else { 
      echo ("error!"); 
    } 
  }  

}

when I passed $_FILES["userfile"] it worked,

didn't you get the same result?

[Weedpacket]

A function in your code. Your statement

you need to pass the $_FILE(S) data into the function for it to work.

is flatly contradicted by the manual.

[Xoid]

DUDE, just try it for yourself, tis no joke.