passing variable to pop up window.need some explanation

[kav]

I just want to know why. Or maybe the setting involve or whatever.Hope someone can tell. This is how i always write.

page1.php

<a href=\"javascript:open_window('do.php?libraryid=$libraryid&edit=1')> hello</a>
<a href=\"javascript:open_window('do.php?libraryid=$libraryid&add=1')> hello</a>

do.php

if(isset($GET['edit']))
$hi=$GET['edit'];
if(isset($GET['add']))
$he=$GET['add'];

BUT MY FRIEND do it like this
$hi=$GET['edit'];
$he=$GET['add']; (without the isset())

if i do like he does without the isset, i will get an error msg saying
Notice : undefined index edit/add depends which i click at on page1.php

Anyone can tell me why?

[Xoid]

Originally posted by kav
I just want to know why. Or maybe the setting involve or whatever.Hope someone can tell. This is how i always write.

page1.php

<a href=\"javascript:open_window('do.php?libraryid=$libraryid&edit=1')> hello</a>
<a href=\"javascript:open_window('do.php?libraryid=$libraryid&add=1')> hello</a>


do.php

if(isset($GET['edit']))
$hi=$GET['edit'];
if(isset($GET['add']))
$he=$GET['add'];

BUT MY FRIEND do it like this
$hi=$GET['edit'];
$he=$GET['add']; (without the isset())

if i do like he does without the isset, i will get an error msg saying
Notice : undefined index edit/add depends which i click at on page1.php

Anyone can tell me why?

I believe it's best to check if the variable is set first using 'isset' then assign the data to the variable using '$_GET'.

if you wanted you could use @ which turns off error handling.

e.g. if you did this:

$hi = @$GET['edit'];
$he = @$GET['add'];

this means that when no value is assigned to $hi and $he you won't get that nasty error message because of @ which effectively 'hides' error messages for that particular function, if you get my drift?

one more thing, looking at your code the reason you are getting errors because your using variables libraryid and edit instead of edit and add.

[kav]

i purposely left out the libraryid coz both also has it in the link:

libraryid=$libraryid&add=1
libraryid=$libraryid&edit=1

i just want to ask about the edit and add thing only so just put that two.

hmmm..yes i do get what u mean but why he don't have to put
the @ but still without getting the error message Notice: undefined index xxxxx?

[bad76]

Hi,
you get the error because in your php.ini you have this kind of string:

error_reporting = E_ALL

In the develop environment this is not bad. Give you a lot of debug information.
For more info look this: error_reporting

However my hint is to convert this call
'do.php?libraryid=$libraryid&edit=1'
and
'do.php?libraryid=$libraryid&add=1'

into
'do.php?libraryid=$libraryid&oper=edit'
and
'do.php?libraryid=$libraryid&oper=add'

bye bye