Php and MYsql

adiwood

Just started and trying to get name entered by a user to save within the databse. The table name is customer details and the fields are customerID, FirstName, LastName.

Below is the code

<html>
<head>
<title> Customer Details </title>
</head>

<body>

<?php
if (isset($_GET['addcustomer'])):
?>

<form action=<?=$_SERVER['PHP_SELF']?>" method="post">
<p>Please enter your details <br>

<FirstName: <input type="text" name="FirstName" /> <br>
<LastName: <input type="text" name="LastName" /> <br>

<?php
$dbcnx = @mysql_connect('localhost', 'root', '');

if (!$dbcnx) {
die( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>');
}

if (! @mysql_select_db('customerdetails' ) ) {
die ( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>');
}

if (isset($POST['submitcustomer'])) {
$FirstName = $POST['FirstName'];
$sql = "INSERT INTO customerdetails SET
CustomerID='$customerid";
if (@($sql)) {
echo('<p>Your details have been added.</p>');
} else {
echo('<p>Error adding submitted details: ' .
mysql_error() . '</p>');
}

?>
</body>
</html>

coppercoins

Some inherent problems in your code.

first, you need to enclose your condition statements with curly braces.

second, you're checking to see if a form variable is set before displaying the form. You should be looking for its opposite.

Check the following code against yours and note the differences. Try it first to check my logic, this is an on the fly edit. I could be wrong with some of it.

 
<html> 
<head> 
<title> Customer Details </title> 
</head> 

<body> 

<?php 
if (!isset($_POST['addcustomer']))
{
?> 

<form action="<?php=$_SERVER['PHP_SELF']?>" method="post"> 
<p>Please enter your details <br> 

FirstName: <input type="text" name="FirstName"  <br> 
LastName: <input type="text" name="LastName"  <br> 

<input type="hidden" name="submitcustomer" value="true">
<input type="submit" value="SUBMIT"> 
</p> 
</form> 

<?php
}
else
{
  $dbcnx = @mysql_connect('localhost', 'root', ''); 

  if (!$dbcnx) { 
    die( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>'); 

if (! @mysql_select_db('customerdetails' ) ) { 
die ( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>'); 
    } 
break;
  }

  if (isset($_POST['submitcustomer'])) { 
  $FirstName = $_POST['FirstName']; 
  $sql = "INSERT INTO customerdetails SET 
  CustomerID='$customerid'";
  $query = mysql_query($sql);
  if ($query == true) { 
  echo"<p>Your details have been added.</p>"; 
  } else { 
  echo "<p>Error adding submitted details: ", 
  mysql_error() ,"</p>"; 
  } 
}
?> 
</body> 
</html>

chads2k2

WHOA! WHOA! WHOA! Just stop right there big dog. Your taking the long way around things. Check this out.

<html>
<head>
<title> Customer Details </title>
</head>

<body>

<?php
if (isset($POST['addcustomer']))
{
$db = mysql_connect("localhost","root","");
mysql_select_db("customerdetails",$db);
$FirstName = $POST['FirstName'];
$LastName = $_POST['LastName'];
$sql = "INSERT INTO customerdetails VALUES(NULL,'$FirstName','$LastName')";
if(!(mysql_query($sql))) {
print("Could not exec query (".$sql."), MySQL reports: ".mysql_error());
exit();
}ELSE{
echo "<b> See PHP is really that easy! OH! Your details were also added.</b>";
}
}
?>

<form action=<?=$_SERVER['PHP_SELF']?>" method="post">
<p>Please enter your details <br>

FirstName: <input type="text" name="FirstName"> <br>
LastName: <input type="text" name="LastName"> <br>

I changed a lot of things! Let me try and recap all the errors:

1.) if (isset($_GET['addcustomer'])): <-- You are using POST! NOT GET!

2.) $sql = "INSERT INTO customerdetails SET
CustomerID='$customerid"; <-- What the hell are you trying to use an Update statement mixed with an INSERT statement. Not going to work.

3.) LastName: <input type="text" name="LastName" /> <-- What is with the />?? Your not inside of the PHP block. You don't need to ignore that character. Just makes no sense.

4.) if (! @mysql_select_db('customerdetails' ) ) {
die ( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>');
} <-- WTF? Define the database you want to use and then check connection. This just looks sloppy!

5.) <?php
if (isset($_GET['addcustomer'])):
?> <-- Don't define that all the way up at the top with PHP at the bottom. Just leaves a lot of confusion. Makes the server work harder to figure that out as well. If you want your form to always appear just put it in a .inc. Makes life easier.

Hey just keep working and it just takes time and practice! If you need any help PLEASE don't hesistate to contact me! I am always willing to help! Check out www.ohhbad.com and you will find my E-Mail on there. Lata

Chad

Shrike

Firstly chad...this person has posted in the Newbies forum asking for help, so please don't start ranting about how bad the PHP code is.

Secondly, alot of the things which he has done are perfectly valid, and yet you have said they are wrong. Lets take a look:

if (isset($GET['addcustomer'])): <-- You are using POST! NOT GET!

To me it looks like $GET['addcustomer'] is the entry point to the page, established through a link. If this is the case, then $_GET might be appropriate.

$sql = "INSERT INTO customerdetails SET
CustomerID='$customerid"; <-- What the hell are you trying to use an Update statement mixed with an INSERT statement. Not going to work.

Fair enough, but this is the Newbies forum, and he has said he is just starting out. So go easy.

LastName: <input type="text" name="LastName" /> <-- What is with the />?? Your not inside of the PHP block. You don't need to ignore that character. Just makes no sense.

A forward slash at the end of an empty HTML tag is HTML 4 valid so he is correct.

if (! @mysql_select_db('customerdetails' ) ) {
die ( '<p>Sorry Fernbarrrow website is experiencing difficuties at current.</p>');
} <-- WTF? Define the database you want to use and then check connection. This just looks sloppy!

No, error handling on database connections is absolutely necessary. The script cannot continue without a valid SQL link. Your code snippet has virtually no error handling at all.

If you are going to help out on these forums then please have a clue what you are talking about.

Oh and one final thing, your code is fundamentally wrong.

chads2k2

Adiwood my bad for jumping on your back on this one. I didn't mean no harm by it just think that you might have a few of your signals and codes crossed. I remember how it was back in PHP3 when I started, so terribly sorry for that. I just get a big head and I don't mean no harm by it.

Shrike - Fine my code might not be "fundamentally wrong" but honestly it's short and easy to understand. Plus you have no right to say that I don't know this language. You don't know what I have done nor what I have accomplished. Walk a mile in my shoes to see where I have been. Watch your attitude, as I will watch mine. Plus my last line said that I was trying to help and he can contact me anytime! Yeah that really makes me seem like the bad guy. Right.

Once again my bad Adiwood, the offer still stands that if you need any help (from a nice guy that has made my mistakes) let me know. More than willing to help.

Chad R. Smith

adiwood

Shrike and coppercoins thanx alot, it really helped.

Chads2k - The code may be shorter but its a hello of alot harder to understand, and seems to go against standards. The /> is the new standard on things such as input boxes and stuff that didnt have clodsing bracket, if you knew what u were on about! You have just confused me more, i have been doin php for a week, and that was the first thing i have wrote all by myself, without any help. Dont you dare start swearing at me telling how crap i am., i will become better, thats obvious. I will now take anything you say chads2k with a pitch of salt as you have lost my trust. If your goin to post again, 1) be more friendly - dont be mean 2) know the update stuff and standards - very important for website e.g the closing of the input boxes.
I dont think i did to bad for my first time, apart from chads2k putting me off posting n this sie ever again especially if i post here and get a respose like that.

Thanx alot
adi

ahundiak

$sql = "INSERT INTO customerdetails SET 
CustomerID='$customerid"; <-- What the hell are you trying to use an Update statement mixed with an INSERT statement. Not going to work.

Actually, for mysql, using SET in INSERT statements will work. Just a another non-standard mysql extension. But using a VALUES clause is certainly the way to go.

chads2k2

Yeah my bad. I said I was sorry. Guess you missed that two parts. All well no harm no faul. My code works and it's short. Funny how industry looks at those things. Hmmm.... 🙂

Chad

EDIT: You didn't want to read my first message.

chads2k2

Originally posted by ahundiak
$sql = "INSERT INTO customerdetails SET 
CustomerID='$customerid"; <-- What the hell are you trying to use an Update statement mixed with an INSERT statement. Not going to work. 
Actually, for mysql, using SET in INSERT statements will work. Just a another non-standard mysql extension. But using a VALUES clause is certainly the way to go. [/B]

Guess I missed that shortcut they put in there now. Thanks for pionting that out.

Chad

EDIT: Just so adiwood knows what the "standard" is for this statement might want to READ by going to (http://www.mysql.com/doc/en/INSERT.html) that is the MANUAL on MySQL. Just FYI.