Register Pg-please Help

[obrienkev]

Hi all,
I have created a register page(register.htm) and when the user clicks submit the welcome pg is called(welcome.php).
However, for some reason I cannot register any name. The message I get is:

select * from user where username=''
1That username is taken - go back and choose another one.

Here is some code on my welcome pg:

// attempt to register
$reg_result = register($username, $email, $mimetype, $passwd);

Here is the register() function. The error seems to begin here.

function register($username, $email, $mimetype, $password)
// register new person with db
// return true or error message
{
// connect to db
$conn = db_connect();
if (!$conn)
return 'Could not connect to database server - please try later.';

// check if username is unique
$result = mysql_query("select from user where username='$username'");
//bugcheck
echo "select from user where username='".$username."'</br>";
echo mysql_num_rows($result);

if (!$result)
return 'Could not execute query';
if (mysql_num_rows($result)>0)
return 'That username is taken - go back and choose another one.';

Here is the db_connect() function:

function db_connect()
{
$result = mysql_pconnect('localhost', 'reg_user', 'password');
if (!$result)
return false;
if (!mysql_select_db('register'))
return false;

return $result;
}

There doesnt seem to be a problem connecting to db.
Please, please help me out. Ive been trying to solve it for days without any luck.
Thanks for your time and help.
Kevin.

[The_Chancer]

Seems like your problem lies with the first query - and that $username is null...

When you get in the register function, echo out al the parts first, so you can ensure they were passed to the function.

function register($username, $email, $mimetype, $password)
echo "user :".$username."<br>";
echo "email :".$email."<br>";
echo "mime :".$mimetype."<br>";
echo "pass :".$password."<br>";

// register new person with db
// return true or error message
{
// connect to db
$conn = db_connect();
if (!$conn)
return 'Could not connect to database server - please try later.';

// check if username is unique
$result = mysql_query("select * from user where username='$username'");
//bugcheck
echo "select * from user where username='".$username."'</br>";
echo mysql_num_rows($result);
if (!$result)
return 'Could not execute query';
if (mysql_num_rows($result)>0)
return 'That username is taken - go back and choose another one.'; 
}

Then see if you get the right parts...

[obrienkev]

Cheers chancer,
But when I make those changes I get...

Parse error: parse error, unexpected T_ECHO, expecting '{' in c:\program files\apache group\apache\htdocs\newsite\user_auth_fns.php on line 7

Fatal error: Call to undefined function: register() in c:\program files\apache group\apache\htdocs\newsite\welcome.php on line 241

What do I do???

[helz]

on line 8 of that function remove the { and put it at the end of line 1:

function register($username, $email, $mimetype, $password) {

as for the other problem make sure that you are getting the variables posted from the previous page:
$username = $_POST['username'];

[obrienkev]

No. That didnt work either. I still get the same response. Please any more ideas???