[Resolved] File uploaded...did it?

[Kudose]

Using this script:

 <? 
include('dbinfo.inc.php');
$query = mysql_query("SELECT * FROM admin WHERE password='$password'") or die(mysql_error());
$rows = mysql_num_rows($query); 
if($rows=1){
include('top.php'); 
   include('left.php');?>

 <td width="81%">  <?
$home = '/XXXXXXXXXXXXX/';
if ($HTTP_POST_VARS['submit']) {
  print_r($HTTP_POST_FILES);
  if (!is_uploaded_file($HTTP_POST_FILES['file']['tmp_name'])) {
    $error = "You did not upload a file!";
    unlink($HTTP_POST_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
    //a file was uploaded
    $maxfilesize=200000;

if ($HTTP_POST_FILES['file']['size'] > $maxfilesize) {
  $error = "file is too large";
  unlink($HTTP_POST_FILES['file']['tmp_name']);
  // assign error message, remove uploaded file, redisplay form.
} else {
  if ($HTTP_POST_FILES['file']['type'] != "image/gif" AND $HTTP_POST_FILES['file']['type'] != "image/pjpeg") { 
    $error = "This file type is not allowed";
    unlink($HTTP_POST_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
   //File has passed all validation, copy it to the final destination and remove the temporary file:
   move_uploaded_file("$home".$HTTP_POST_FILES['file']['tmp_name'],"/$path/".$HTTP_POST_FILES['file']['name']);
   unlink($HTTP_POST_FILES['file']['tmp_name']);
   $dir = "$home$path";
   print "File has been successfully uploaded to $dir";
   echo "</td>";
   include('bottom.php');
   exit;
 }
} 
  }
}
?>
 <form action="<?=$PHP_SELF?>" method="post" enctype="multipart/form-data">
    <?=$error?>
    <div align="center"><br>
      <font color="#FF0000" size="2" face="Tahoma"><strong>Password to upload 
      file: 
      <input type="password" name="password" maxlength="12">
      <br>Directory to upload:<select name="path" id="path">
          <option selected>Car</option>
          <option>Truck</option>
          <option>SUV</option>
        </select><br>
      Choose a file to upload: 
      <input type="file" name="file">
      <br>
      <input type="submit" name="submit" value="submit">
      </strong></font> </div>
  </form>

 </td> <?
include('bottom.php'); 
} else {
 include('top.php'); 
   include('left.php');?> <td height="110"> <?
   print "Password is invalid. "; 
   ?> </td> <?
include('bottom.php');
} 
?>  

Returns this:

Array ( [file] => Array ( [name] => 3.jpg [type] => image/pjpeg [tmp_name] => /tmp/phpCsiUpK [error] => 0 [size] => 47444 ) ) File has been successfully uploaded to /XXXXXXXX/SUV

I check the dir but no image is uploaded. Anyone know where my image has gone?

[Volitics]

Unless I'm just overlooking it, you don't have a copy function in your script.

You might try using something like this:

$FileName = $_FILES["$Image"]["name"];
$TempName = $_FILES["$Image"]["tmp_name"];

(copy ($TempName, "".$DirectoryPathName."/".$FileName.""))

// A couple of more image functions are:
$FileType = $_FILES["$Image"]["type"];
$FileSize = $_FILES["$Image"]["size"];

see:
PHP Manual
That way the temp name (which might be something like 'xeyst4e7se') is copied to the uploaded file name and then placed on the server.

Also, in the other part(s) of your script $HTTP_POST_VARS has been replaced with a newer variable, $_POST.

[Kudose]

Now I get this

Warning: copy(XXXXX/SUV/image/pjpeg): failed to open stream: No such file or directory in /home/zayyscec/public_html/upload.php on line 24

with this:

 <?
$home = 'XXXXX/';
if ($_POST['submit']) {

  print_r($_FILES);
  if (!is_uploaded_file($_FILES['file']['tmp_name'])) {
    $error = "You did not upload a file!";
    unlink($_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
    //a file was uploaded
    $maxfilesize=200000;
	$FileName = $_FILES['file']['type']; 
    $TempName = $_FILES['file']['tmp_name']; 
	$dir = "$home"."$path";
	(copy ($TempName, "".$dir."/".$FileName.""));

if ($_FILES['file']['size'] > $maxfilesize) {
  $error = "file is too large";
  unlink($_FILES['file']['tmp_name']);
  // assign error message, remove uploaded file, redisplay form.
} else {
  if ($_FILES['file']['type'] != "image/gif" AND $_POST['file']['type'] != "image/jpg") { 
    $error = "This file type is not allowed";
    unlink($_FILES['file']['tmp_name']);
    // assign error message, remove uploaded file, redisplay form.
  } else {
   //File has passed all validation, copy it to the final destination and remove the temporary file:


   copy("$home".$_FILES['file']['tmp_name'],"/$path/".$_FILES['file']['name']);
   unlink($_FILES['file']['tmp_name']);
   $dir = "$home$path";
   print "File has been successfully uploaded to $dir";
   echo "</td>";
   include('bottom.php');
   exit;
 }
} 
  }
}

Thanks alot already!

[Volitics]

Here's part of the problem. You've got this:

unlink($_FILES['file']['tmp_name']);

before the b;[/b] directive.

The unlink is deleting the file before it gets to the copy function. No wonder it's not copying.

You're welcome already!

[Volitics]

Try this:

// Source: "PHP for the World Wide Web" written by Larry Ullman
/* This next conditional determines whether or not to handle the form, depending upon whether or not $File exists. */
if ($File) {
 	print ("File name: $File_name<P>\n");
 	print ("File size: $File_size<P>\n");
 	if (copy ($File, "users/$File_name")) {
 		print ("Your file was successfully uploaded!<P>\n");
 	} else {
 		print ("Your file could not be copied.<P>\n");
 	}
 	unlink ($File);
}

print ("Upload a file to the server:\n");
print ("<FORM ACTION=\"FileUpload.php\" METHOD=POST ENCTYPE=\"multipart/form-data\">\n");
print ("File <INPUT TYPE=FILE NAME=\"File\" SIZE=20><BR>\n");
print ("<INPUT TYPE=SUBMIT NAME=\"SUBMIT\" VALUE=\"Submit!\"></FORM>\n");

[Kudose]

Now I get this:

File name: 2.jpg
File size: 40142

Warning: copy(home/zayyscec/public_html/SUV): failed to open stream: No such file or directory in /home/zayyscec/public_html/uploader.php on line 17
Your file could not be copied.

Using this:

<?
 $home = 'home/zayyscec/public_html/';
 $dir = "$home"."$path";
 $maxsize = 200000;
 if ($file<=$maxsize) { 
    print ("File name: $file_name<P>\n"); 
    print ("File size: $file_size<P>\n"); 
    if(copy ($file, "$dir")) { 
        print ("Your file was successfully uploaded!<P>\n"); 
    } else { 
        print ("Your file could not be copied.<P>\n"); 
    } 
    unlink ($file); 
} 

?>
 <form action="<?=$PHP_SELF?>" method="post" enctype="multipart/form-data">
    <?=$error?>
    <div align="center"><br>
      <font color="#FF0000" size="2" face="Tahoma"><strong>Password to upload 
      file: 
      <input type="password" name="password" maxlength="12">
      <br>Directory to upload:<select name="path" id="path">
          <option selected>Car</option>
          <option>Truck</option>
          <option>SUV</option>
        </select><br>
      Choose a file to upload: 
      <input type="file" name="file">
      <br>
      <input type="submit" name="submit" value="submit">
      </strong></font> </div>
  </form>

[cgraz]

Try this bro

<? 

if(isset($_POST["submit"])) {

   $home = "/home/zayyscec/public_html/";
   $dir = $home.$_POST["path"]; 
   $maxsize = "200000"; 

   if ($file_size <= $maxsize) { 

       print ("File name: " . $file_name . "<br>");  
       print ("File size: " . $file_size . "<br>");  

       if(copy($file, "$dir/$file_name")) {  
           print ("Your file was successfully uploaded!<br>");  
       } else {  
           print ("Your file could not be copied.<br>");  
       } 

   } else {
       print ("Filesize exceeds " . $maxsize . "File was not uploaded<br>");
   }


   print "<br>" . $dir . "<br>";
   print "$dir/$file_name";

} else {

?> 

 <form action="<?= $PHP_SELF ?>" method="post" enctype="multipart/form-data"> 

<div align="center"><br> 

  <font color="#FF0000" size="2" face="Tahoma"><strong>Password to upload file: 

  <input type="password" name="password" maxlength="12"> 

  <br>Directory to upload:

    <select name="path" id="path"> 
      <option value="Car" selected>Car</option> 
      <option value="Truck">Truck</option> 
      <option value="SUV">SUV</option> 
    </select><br>

  Choose a file to upload: <input type="file" name="file"> <br> 

  <input type="submit" name="submit" value="submit"> 

  </strong></font></div> 

  </form> 

<?

}

?>

Cgraz

[Kudose]

Who's the man? Cgraz is the man.

Werd.

Thanks! It works great 🙂