Problem with if () and echo

iNFERiON

Hi there,
I am having a slight problem with the following script I wrote:

	require 'index.php';
	if (!$lang)
	{
	echo "&nbsp;Text 1";
	}
	if ($lang == 'nl')
	{
	echo "&nbsp;Text 1";
	}
	if ($lang == 'be')
	{
	echo "&nbsp;Text 2";
	}

So if the string lang (defined in index.php so index.php?lang=) is not put in or is equal to nl php should echo Text 1, if the sting is equal to be it should echo Text 2, but it does display Text 1 instead. What am I forgetting here or have I misprogrammed ?

Thanks in advance 🙂

Moonglobe

this is a problem with [man]register_globals[/man]. you need to use $_GET['lang'].

helz

just to further clarify what Moonglobe said here is your code with the appropriate code:

require 'index.php'; 
    if (!$_GET['lang']) 
    { 
    echo "&nbsp;Text 1"; 
    } 
    if ($_GET['lang'] == 'nl') 
    { 
    echo "&nbsp;Text 1"; 
    } 
    if ($_GET['lang'] == 'be') 
    { 
    echo "&nbsp;Text 2"; 
    }

iNFERiON

Thanks for the fast replies, I already tried this by setting

$lang = $_GET['lang'];

after I posted the above, but didn't help unfortunately.

My full source code is as follows:

<body>
<h1 align="left"><img src="images/topleft.jpg" width="102" height="100" align="left"><em><br>
    <span class="style1">&nbsp; 
	<?php
	require 'index.php';
	if (!$_GET['lang'])
	{
	echo "Text 1";
	}
	if ($_GET['lang'] == 'nl')
	{
	echo "Text 1";
	}
	if ($_GET['lang'] == 'be')
	{
	echo "Text 2";
	}
	?></span></em></h1>
</body>

Moonglobe

well are you getting any errors? that would help to know that...

helz

if there are no errors, you might want to try:
$lang = ".$_GET['lang'].";

also echo $_GET['lang'] out to make sure that its getting the data

iNFERiON

Originally posted by helz
if there are no errors, you might want to try:
$lang = ".$_GET['lang'].";

also echo $_GET['lang'] out to make sure that its getting the data

If I do that I get this:

parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING

laserlight

Since you're using $_GET, it is possible that the variable in question has not set yet, or is empty.
You should then perform a check for this first, using [man]isset/man or [man]empty/man

e.g.

require 'index.php';
if (!empty($_GET['lang']))
{
	switch ($_GET['lang'])
	{
	case 'nl':
		echo 'Text1';
		break;
	case 'be':
		echo 'Text2';
		break;
	default:
		//lang unknown
	}
}
else
{
	//lang unstated
}

iNFERiON

Hmmm, that still does not work when I want it to echo Text 2.

This is what I have now:

<?php
require 'index.php'; 
if (!empty($_GET['lang'])) 
{ 
    switch ($_GET['lang']) 
    { 
    case 'nl': 
		//lang nl
        echo 'Text1'; 
        break; 
    case 'be':
		//lang be 
        echo 'Text2'; 
        break; 
    default: 
        //lang unknown 
    } 
} 
else 
{ 
    //lang unstated 
	echo 'Text1';
}
	?>

helz

hmm is the code within index.php or is a seperate php file?

if its seperate then its looking for:
thisfile.php?lang=
and not:
index.php?lang=

you will need to copy the code into the index file to do it...

iNFERiON

Yes, it are 2 different files.
They work when you approch then directly, but I want it to read the lang string set in the URL.
(In my case ]http://localhost/index.php?lang=....)

This is what my index.php looks like

<html>
<head>
<title>TuningCenter</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<frameset rows="101,*" cols="*" frameborder="NO" border="0" framespacing="0">
  <frame src="top.php" name="topFrame" scrolling="NO" noresize>
  <frameset rows="*" cols="143,*" framespacing="0" frameborder="NO" border="0">
    <frame src="nav.php" name="leftFrame" scrolling="NO" noresize>
    <frame src="welkom.php" name="mainFrame">
  </frameset>
</frameset>
<noframes><body>	
</body></noframes>
</html>

I want the files welkom.php and top.php to read the lang string from index.php.

helz

you'll need to put it at the top of index.php
eg:

<html>
<head>
<title>TuningCenter</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<?php 
require 'index.php';  

if (!empty($_GET['lang']))  

{  

    switch ($_GET['lang'])  

    {  

    case 'nl':  

        //lang nl 
        echo 'Text1';  

        break;  

    case 'be': 
        //lang be 
        echo 'Text2';  

        break;  

    default:  

        //lang unknown 
    }  

}  

else  

{  

    //lang unstated 
    echo 'Text1'; 
} 
    ?>
<frameset rows="101,*" cols="*" frameborder="NO" border="0" framespacing="0">
  <frame src="top.php" name="topFrame" scrolling="NO" noresize>
  <frameset rows="*" cols="143,*" framespacing="0" frameborder="NO" border="0">
    <frame src="nav.php" name="leftFrame" scrolling="NO" noresize>
    <frame src="welkom.php" name="mainFrame">
  </frameset>
</frameset>
<noframes><body>	
</body></noframes>
</html>

iNFERiON

Hmm, that just results in a blank page 🙁

helz

you can copy the code into the files that require to know what lang is, but it will probobly be easier to put it in index.php

is it being used to change the whole text to a certain language?

iNFERiON

Well, I registered two domains, a .nl (Netherlands) one and a .be (Belgium) one.
The .be one is going to be a redirect domain to the .nl domain, which has the webspace with the files.
I want the .be domain to redirect to www.mysite.nl/index.php?lang=be
This way the site should have a header (top.php) saying MySite.be instead of the default MySite.nl.
And also the welcome page (welkom.php) states, 'welcome to mysite.nl', which should be 'welcome to mysite.be'
if ?lang=be is set.

helz

ah so its much simpler than what i was worrying about.
(me thinking that you where having a different language for each one)

in your top.php put this right at the toppest of top of the code:

echo "<title>MySite.";
if (isset($_GET['lang'])) {//if lang is set do stuff
  if ($_GET['lang'] == "be") {
    echo "be";
  } elseif ( $_GET['lang'] == "nl") {
    echo "nl";
  }
}
echo "</title>";

you dont need to manually put <html> or body tags as php does that for you, but that again is personal preference...

now the code above does the title but for the rest just add an extra bit of code that does pretty much the same thing but displays the welcome message on the screen

eg:

echo "Welcome to MySite.";
if (isset($_GET['lang'])) {//if lang is set do stuff
  if ($_GET['lang'] == "be") {
    echo "be";
  } elseif ( $_GET['lang'] == "nl") {
    echo "nl";
  }
}
echo "!";

iNFERiON

Okay, now the title does change to the correct domain name, if lang is set, it displays the text it is set to. If it's unset it will display the default "nl".

But the top.php and welkom.php frames still show .nl when I put in ?lang=be

To clear things up, here's the source code of all 3 files.

index.php

<html> 
<head> 
<?
echo "<title>MySite."; 
if (isset($_GET['lang'])) {
//if lang is set do stuff 
  if ($_GET['lang'] == "be") { 
    echo "be"; 
  } elseif ( $_GET['lang'] == "nl") { 
    echo "nl"; 
  } 
} 
else echo "nl";
echo "</title>";
?>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> 
</head> 
<frameset rows="101,*" cols="*" frameborder="NO" border="0" framespacing="0"> 
  <frame src="top.php" name="topFrame" scrolling="NO" noresize> 
  <frameset rows="*" cols="143,*" framespacing="0" frameborder="NO" border="0"> 
    <frame src="nav.php" name="leftFrame" scrolling="NO" noresize> 
    <frame src="welkom.php" name="mainFrame"> 
  </frameset> 
</frameset> 
<noframes><body>     

</body></noframes> 
</html>

top.php

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
<!--
body {
	background-image:  url(images/top_bg.jpg);
	margin-top: 0px;
	margin-left: 0px;
}
.style1 {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	color: #999999;
}
-->
</style></head>

<body>
<h1 align="left"><img src="images/topleft.jpg" width="102" height="100" align="left"><em><br>
    <span class="style1">&nbsp; <? echo "MySite."; 
if (isset($_GET['lang'])) {//if lang is set do stuff 
  if ($_GET['lang'] == "be") { 
    echo "be"; 
  } elseif ( $_GET['lang'] == "nl") { 
    echo "nl"; 
  } 
} 
else echo "nl";
?>
</span></em></h1>
</body>
</html>

welkom.php

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
<!--
.style1 {font-family: Verdana, Arial, Helvetica, sans-serif}
.style2 {	font-family: Verdana, Arial, Helvetica, sans-serif;
	color: #999999;
}
-->
</style></head>

<body>
<h3><span class="style1">Welkom</span></h3>
<p><span class="style1">Welcome to 	
	<? echo "MySite."; 
if (isset($_GET['lang'])) {//if lang is set do stuff 
  if ($_GET['lang'] == "be") { 
    echo "be"; 
  } elseif ( $_GET['lang'] == "nl") { 
    echo "nl"; 
  } 
} 
else echo "nl";
?>, blah blah blah.</span></p>
</body>
</html>

helz

the problem now is that because your using frames they are being treated as seperate files. only way that i can currently think of for sending information from page to page when using frames is by starting a session...

iNFERiON

Thanks for the advice, I'll go try and set up a session in my page 🙂

iNFERiON

Hmm, having a session problem here....

Here are my new source codes...

index.php

<html> 
<head> 
<?
echo "<title>MySite."; 
if(!session_id()){
  session_start();
}
if (isset($_GET['lang'])) {
//if lang is set do stuff 
  if ($_GET['lang'] == "be") { 
    echo "be";
	$_SESSION['lang'] = 'be';
   } elseif ( $_GET['lang'] == "nl") { 
    echo "nl"; 
	$_SESSION['lang'] = 'nl';
  } 
} 
else
{
echo "nl";
$_SESSION['lang'] = 'nl';
}
echo "</title>";
?>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> 
</head> 
<frameset rows="101,*" cols="*" frameborder="NO" border="0" framespacing="0"> 
  <frame src="top.php" name="topFrame" scrolling="NO" noresize> 
  <frameset rows="*" cols="143,*" framespacing="0" frameborder="NO" border="0"> 
    <frame src="nav.php" name="leftFrame" scrolling="NO" noresize> 
    <frame src="welkom.php" name="mainFrame"> 
  </frameset> 
</frameset> 
<noframes><body>     

</body></noframes> 
</html>

top.php

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
<!--
body {
	background-image:  url(images/top_bg.jpg);
	margin-top: 0px;
	margin-left: 0px;
}
.style1 {
	font-family: Verdana, Arial, Helvetica, sans-serif;
	color: #999999;
}
-->
</style></head>

<body>
<h1 align="left"><img src="images/topleft.jpg" width="102" height="100" align="left"><em><br>
    <span class="style1">&nbsp; <? echo "MySite.";
	echo $_SESSION['lang'];	?>
</span></em></h1>
</body>
</html>

welkom.php

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">
<!--
.style1 {font-family: Verdana, Arial, Helvetica, sans-serif}
.style2 {	font-family: Verdana, Arial, Helvetica, sans-serif;
	color: #999999;
}
-->
</style></head>

<body>
<h3><span class="style1">Welcome</span></h3>
<p><span class="style1">this is 	
	<em><span class="style2"><? echo "MySite.";
	echo $_SESSION['lang'];	?></span></em>, some more blah blah here.</span></p>
</body>
</html>

I get these errors.

index.php

<title>MySite.<br />
<b>Warning</b>:  session_start(): Cannot send session cookie - headers already sent by (output started at c:\inetpub\wwwroot\MySite\index.php:3) in <b>c:\inetpub\wwwroot\MySite\index.php</b> on line <b>6</b><br />
<br />
<b>Warning</b>:  session_start(): Cannot send session cache limiter - headers already sent (output started at c:\inetpub\wwwroot\MySite\index.php:3) in <b>c:\inetpub\wwwroot\MySite\index.php</b> on line <b>6</b><br />
nl</title>

top.php

MySite.
Notice: Undefined variable: _SESSION in c:\inetpub\wwwroot\MySite\top.php on line 23

welkom.php

Welcoe
this is MySite.
Notice: Undefined variable: _SESSION in c:\inetpub\wwwroot\MySite\welkom.php on line 19
, some more blah blah here.

Doesn't look very good 😕