another file upload problem

[banpro]

I know uploading problems get asked about a lot here, but I've searched and couldn't find anything specific to my trouble which helped.

I'm trying to upload a file into a specific directory on my server then redirect to another page. The upload seems to progress, the redirection works, but when I look the file isn't in the directory?

Here's what I have:

 $uploaddir = '/home/user/public_html/April2004/';
 $uploadfile = $uploaddir . $_FILES['file']['name'];

if (move_uploaded_file($_FILES['file']['tmp_name'], $uploadfile)) {
}

 header("Location: someURL.com");
 exit();

I believe the problem lies in the "if" line but I'm just not seeing it. Any help is most appreciated.

Thanks,
Scott

[yelvington]

Your if() statement is immediately followed by an empty pair of {}, so it controls the execution of nothing.

Your header() function call is outside the braces and will always execute.

Restructure your code, and then if the upload fails, you should print some diagnostics.

[banpro]

Okay, I modified the upload script a bit and now it works fine with small files, but I get an error on anything over 100kb in size regarding the unlink line of this code (the error says no such file?):

// To allow for larger uploads
ini_set('upload_max_filesize', "7M"); 
ini_set('post_max_size', "8M"); 
ini_set('max_execution_time', "900");

// COPY UPLOADED FILE FROM tmp DIRECTORY TO April2004 DIRECTORY
 $uploaddir = '/home/user/public_html/April2004/';
 $uploadfile = $uploaddir . $_FILES['userfile']['name'];

 copy($userfile, $uploadfile);
 unlink($userfile);

The above code is followed by a header redirect. With small files it works fine, places the file into the April2004 directory and redirects the browser. With any file over 100kb it stops execution with an error on the unlink() line and states no such file exists.

Any ideas?

Thanks,
Scott

[jabi]

Have you run phpinfo() to find the max upload size permitted on your server?

[Kudose]

Here ya go:

<?  

if(isset($_POST["submit"])) { 

   $home = "/home/user/public_html/"; 
   $dir = $home.$_POST["path"];  

   $maxsize = "200000";  

   if ($file_size <= $maxsize) {  

       print ("File name: " . $file_name . "<br>");   
       print ("File size: " . $file_size . "<br>");   

       if(copy($file, "$dir/$file_name")) {   
           print ("Your file was successfully uploaded!<br>");   
       } else {   
           print ("Your file could not be copied.<br>");   
       }  

   } else { 
       print ("Filesize exceeds " . $maxsize . "File was not uploaded<br>"); 
   } 


   print "<br>" . $dir . "<br>"; 
   print "$dir/$file_name"; 

} else { 

?>  

<form action="<?= $PHP_SELF ?>" method="post" enctype="multipart/form-data"> 

<div align="center"><br> 

  <font color="#FF0000" size="2" face="Tahoma"><strong>Password to upload file: 

  <input type="password" name="password" maxlength="12"> 

  <br>Directory to upload: 

    <select name="path" id="path"> 
      <option value="Car" selected>Car</option> 
      <option value="Truck">Truck</option> 
      <option value="SUV">SUV</option> 
    </select><br> 

  Choose a file to upload: <input type="file" name="file"> <br> 

  <input type="submit" name="submit" value="submit"> 

  </strong></font></div> 

  </form> 

<? 

} 

?> 

That is the script I use on my site. It works just fine.

[yelvington]

You can't use ini_set to change the value of upload_max_filesize, according to the PHP documentation. You CAN use .htaccess,however.

[dakey]

Hello i used your code above and removed the parts i dont need, but it only works if i have register_globals turned OFF. If turned ON it displays

File name:
File size:
Your file could not be copied.

users/

Its like it dos not even recognise the uploaded file? Here is a copy of my code.

<?

extract ($POST);
if(isset($POST["submit"])) {

$maxsize = "200000";

   if ($file_size <= $maxsize) {   

       print ("File name: " . $file_name . "<br>");    
       print ("File size: " . $file_size . "<br>");    

       if(copy($file, "users/$file_name")) {    
           print ("Your file was successfully uploaded!<br>");    
       } else {    
           print ("Your file could not be copied.<br>");    
       }   

   } else {  
       print ("Filesize exceeds " . $maxsize . "File was not uploaded<br>");  
   }  

print "<br>" . $dir . "<br>";

print "users/$file_name";

} else {

?>

<form action="<?= $PHP_SELF ?>" method="post" enctype="multipart/form-data">

<div align="center"><br>  

  Choose a file to upload: <input type="file" name="file"> <br> 

  <input type="submit" name="submit" value="submit"> 

  </strong></font></div> 

</form>

<?

}

?>

[yelvington]

I would urge you not to use extract(), but rather explicitly refer to the $_POST[] array members by name.