One Vote Per IP

cmccomas

Hello,

I've got a voting system and would like to get the users IP and allow only one vote per IP per vote_id.

Can anyone help me/

helz

add an extra field into the db called, vote_ip

then when the user registers a vote change the sql query to:
INSERT INTO blahblah (blah, blah, blah, vote_ip) VALUES ('$blah', '$blah', '$blah', '".$_SERVER['REMOTE_ADDR']."')

that will add the users ip into the database
then before that sql query you need to put this:

$checkip = mysql_query("SELECT vote_ip FROM tablename WHERE vote_ip='".$_SERVER['REMOTE_ADDR']."' AND vote_id='$currentvote' ") or die(mysql_error());
$checkip = mysql_num_rows($checkip);
if ($checkip > 0) {
   echo "You have already voted for this vote!";
} else {
  //run add to vote table query
}

$currentvote is the id of the vote that the user is viewing, since we only want one ip per vote and not one ip for all the votes available in the table

cmccomas

Tried this, but it didn't insert the IP address into the table.

Where did I go wrong? My IP field is varchar(15).

<?

require ( "database_conn.inc.php" );

$checkip = mysql_query("SELECT vote_ip FROM tablename WHERE vote_ip='".$_SERVER['REMOTE_ADDR']."' AND match_id=" . $_POST['match_id'] ."") or die(mysql_error()); 
$checkip = mysql_num_rows($checkip); 
if ($checkip > 0) { 
   header ( "Location: results.php?match_id=" . $_POST['match_id'] );
} else { 
  // First, check whether the add vote form was submitted
if ( $_POST['add_votes'] ) {
	foreach ( $_POST as $key => $val ) {
		if ( eregi ( "rating", $key ) ) {
			$player_rating = explode ( "_", $val );
			$sql = 'INSERT INTO rating ( player_id, match_id, rating_value, vote_ip ) VALUES (' . $player_rating[0] . ',' . $_POST['match_id'] . ',' .  $player_rating[1] . ',' .$_SERVER['REMOTE_ADDR']. ')';
			$add_rating_rs = $conn->Execute($sql) or die ( $conn->ErrorMsg() );
		}
	}
	header ( "Location: results.php?match_id=" . $_POST['match_id'] );
	exit;	
}

?>

helz

do all the other fields have a value except the vote_ip?

also in the checkip sql, it says tablename instead of rating

cmccomas

Yes, I fixed everything to fit my needs.

It adds the votes, but not the IP. Updated code:

<?

require ( "database_conn.inc.php" );

$checkip = mysql_query("SELECT vote_ip FROM rating WHERE vote_ip='".$_SERVER['REMOTE_ADDR']."' AND match_id='" . $_POST['match_id'] ."'") or die(mysql_error()); 
$checkip = mysql_num_rows($checkip); 
if ($checkip > 0) { 
   header ( "Location: results.php?match_id=" . $_POST['match_id'] );
} else { 
  // First, check whether the add vote form was submitted
if ( $_POST['add_votes'] ) {
	foreach ( $_POST as $key => $val ) {
		if ( eregi ( "rating", $key ) ) {
			$player_rating = explode ( "_", $val );
			$sql = 'INSERT INTO rating ( player_id, match_id, rating_value, vote_ip ) VALUES (' . $player_rating[0] . ',' . $_POST['match_id'] . ',' .  $player_rating[1] . ',' .$_SERVER['REMOTE_ADDR']. ')';
			$add_rating_rs = $conn->Execute($sql) or die ( $conn->ErrorMsg() );
		}
	}
	header ( "Location: results.php?match_id=" . $_POST['match_id'] );
	exit;	
}


}
?>

helz

for future reference, also for me if i decide to do something similar.
what did you do to fix it?

cmccomas

Changed vote_id to match_id

Changed tablename to rating

Took out the echo about success and added a header to the results page

helz

so just clerical error then

cmccomas

No PHP/SQL errors, it is inserting the votes into the table, but NOT the IP address for each vote.