@function() doesn't work

mzanimephp

Hi, I have a script which gives me a error message whenever it can't connect to a remote host to get its news feed.

However if their web site goes offline for any reason thats NOT MY FAULT. The code is working fine because the feed comes perfectly if their site is up and running, it usually is 90% of the time.

So I thought it would be cool to use @ in front of the mysql_connect() to supress the error, but it doesn't work at all. Some else told me I did it wrong but I did it just the way he told me to.

Can anyone help? Here's a copy of my script:

<?

// Connect to database
$mysql_connection = @mysql_connect("localhost", "removed", "removed");
if (!$mysql_connection) die("mysql_connect() failed");
if (!mysql_select_db("mzanime_annNews", $mysql_connection))
   die("mysql_select_db() failed");

// Fetch the stored news
$result = mysql_query("SELECT * FROM annNews");
if (!$result) die(mysql_error());
$annNews = mysql_fetch_array($result);

// If the news were last updated more than one hour ago, re-update them
if ($annNews['last_query'] < time() - 3600)
{
   // Fetch the news from ANN
   // You need to put your own username and password here
   $a = file("http://animenewsnetwork.com/newsfeed/getnews.php?u=mzanime&p=q57913");
   $n = addslashes(trim(implode("", $a)));

   // Save the news to the database
   $query = "UPDATE annNews SET last_query = UNIX_TIMESTAMP()";
   if ($n)
   {  $query .= ", news='$n'";
      $annNews['news'] = stripslashes($n);
   }
   mysql_query($query);
}

// Display the news
echo $annNews['news'];

?>

planetsim

Im pretty sure FILE wont let that work you must either use fopen or fsockopen

[edit]http://au2.php.net/manual/en/function.file.php[/edit] Maybe you should read that, basically you'll have to check the fopen wrappers are enabled within the php.ini you can check by doing a phpinfo()

yelvington

Nothing wrong with using file() to fetch a remote file.

The problem is that you're trying to supress errors from the wrong function. You're not having trouble connecting to mysql. Put your @ in front of file().

And you need to write some code to handle errors. If $a comes up empty, do NOT write it to the database.

mzanimephp

I got it fixed. I turns out that I was not getting a error message, it was actually just a warning message. And I was trying to supress it, but it indeed wasn't a error at all.

So what I did was just change the last part of the script:

// Display the news--unless ANN is ofline
if(E_WARNING) {
echo "Sorry,<br /> animenewsnetwork is offline.<br /><br />";
} else {
echo $annNews['news'];
}

And this seems to do the trick. I probably should change it to say something better like "no news available at this time"... anyway, thanks!

Moonglobe

if (E_WARNING) will always return true....

mzanimephp

Omfg :o gnaws my finger off

Is there some way to say that if the script outputs a E_WARNING then display the text?

Moonglobe

[man]set_error_handler/man.... but that's a bit overkill...