[Resolved] Problems Creating an Upload Script

bump909

Can someone advise me what I'm doing wrong here. Once submitted all I keep getting is the "No file specified" or "Could not copy file"
I have Register_Globals = Off

#The HTML file "uploader.html

<html><head><title>File Uploader</title></head>
<body>
Select a file to Upload:<br/>

#The PHP file "uploader.php"

<?php

$filename = $FILES['file']['name'];
$filesize = $FILES['file']['size'];
$filetype = $FILES['file']['type'];
$file = $POST['file'];

if($filename != "" ){
copy("$file", "E:\Program Files\Apache Group\Apache2\htdocs\$filename")
or die("Could not copy file");
}else{
die("No file specified");
}

<html><head><title>Upload Complete</title></head>
<body>
<h3>File Upload Succeeded...</h3>

<a href="<?php echo($filename); ?>">Click here to view file</a>
</body>
</html>

Many thanks.

Pig

There are a few problems.

First, I'm not sure why you are doing this, but you can just keep using the post array. Also, it's a good idea to avoid names that are part of the built in arrays, such as get, post, file, etc.
$file = $_POST['file'];

Second, copy() is copy(origin, destination). Your origin is the temp file path located in the $_FILE array, NOT $file. $file is an array. It is not a string. Also, it might be more clear to just use the single quotes on the destination path, and step outside the string to add the var.
if($filename != "" ){
copy("$file", "E:\Program Files\Apache Group\Apache2\htdocs\$filename")

bump909

I think I've done what you recommend but still no joy. here is the updated php file code.

<?php

$myfilename = $POST['file']['name'];
$myfilesize = $POST['file']['size'];
$myfiletype = $_POST['file']['type'];

if($myfilename != "" ){
copy('$_POST["file"]', 'E:\Program Files\Apache Group\Apache2\htdocs\'.$myfilename)
or die("Could not copy file");
}else{
die("No file specified");
}

<html><head><title>Upload Complete</title></head>
<body>
<h3>File Upload Succeeded...</h3>

<a href="<?php echo($myfilename); ?>">Click here to view file</a>
</body>
</html>

Just returns 'No File Specified'.

Pig

should be:
copy($_POST['file']['tmp_name'], 'E:\Program Files\Apache Group\Apache2\htdocs\'.$myfilename), or die(...

bump909

Thanks for taking the time out to help me on this one.

here is the working script. you may notice that I've used $FILES as opposed to your suggestion of $POST. Well it only seems to work with the former, I don't know why though, I'm a total newbie to all this.

Thanks again, Kris.

<?php

$filesize = $FILES[file][size];
$filename = $FILES[file][name];
$filetemp = $FILES[file][tmp_name];
$filetype = $FILES[file][type];

if($filetemp != "" ){
copy($filetemp, 'E:\Program Files\Apache Group\Apache2\htdocs\'.$filename)
or die("Could not copy file");
}else{
die("No file specified");
}

<html><head><title>Upload Complete</title></head>
<body>
<h3>File Upload Succeeded...</h3>

<a href="<?php echo($filename); ?>">Click here to view file</a>
</body>
</html>

Pig

Crap, sorry man. I meant $_FILES. Don't know why I put post.

bump909

hey, no need to apologise, I really appreciate you helping me out.
Thanks again.