Constructor goofs up Paramaters - HELP

ppowell

class MySQLQuery {

  var $sql;
  var $mySQLConn;

   function MySQLQuery($sql, $mySQLConn) {
    print_r("From CONSTRUCTOR: sql = $sql<P>");
    $this->sql = $sql;
    $this->mySQLConn =& $mySQLConn;
   }

   // MORE STUFF

}


$sql = "INSERT INTO table (name) VALUES ('Phil')";
print_r($sql);
$query =& new MySQLQuery($sql, $this->getDBConn());
print_r($query);

Here is the output of the resulting code:

INSERT INTO table (name) VALUES ('Phil')

From CONSTRUCTOR: sql = Resource id #18

mysqlquery Object ( [sql] => Resource id #18 [mySQLConn] => Resource id #18 )

How on earth did that happen?? for some strange reason when I assigned the parameters to the MySQLQuery constructor everything is fine: the first parameter is a String, the second is a Resource Link Object from a previous DBConnection Object connect() method call. Suddenly, in the constructor, BOTH parameters are the very same Resource Link Object; what happened to my String?

I might be missing something but I can't find it here, any suggestions?

Thanx
Phil

renaun

Ok, here is my guess with out seeing more code.

In line

$query =& new MySQLQuery($sql, $this->getDBConn());

The function $this->getDBConn() is setting the $sql parameter. Try this code and see what happens:

class MySQLQuery {

  var $sql;
  var $mySQLConn;

   function MySQLQuery($sql, $mySQLConn) {
    print_r("From CONSTRUCTOR: sql = $sql<P>");
    $this->sql = $sql;
    $this->mySQLConn =& $mySQLConn;
   }

   // MORE STUFF

}

$asdf = 'asfd';
$sql = "INSERT INTO table (name) VALUES ('Phil')";
print_r($sql);
$query =& new MySQLQuery($sql, $asdf);
print_r($query);

ppowell

class MySQLQuery {

  var $sql;
  var $mySQLConn;

   function MySQLQuery($sql, $mySQLConn) {
    print_r("From CONSTRUCTOR: sql = $sql<P>");
    $this->sql = $sql;
    $this->mySQLConn =& $mySQLConn;
   }

   // MORE STUFF

}

$asdf = 'asfd';
$sql = "INSERT INTO table (name) VALUES ('Phil')";
print_r($sql);
$query =& new MySQLQuery($sql, $asdf);
print_r($query);

The results were completely illogical, here goes:

INSERT INTO table (name) VALUES ('Phil')

$sql =

mysqlquery Object ( [sql] => [mySQLConn] => )

So if it's not a resource id $sql is set to NULL???

Phil

renaun

Here is the same script running on my server

http://www.multispan.com:85/sandbox/const_test.php

Code:

class MySQLQuery { 

  var $sql; 
  var $mySQLConn; 

   function MySQLQuery($sql, $mySQLConn) { 
    print_r("From CONSTRUCTOR: sql = $sql<P>"); 
    $this->sql = $sql; 
    $this->mySQLConn =& $mySQLConn; 
   } 

   // MORE STUFF 

} 

$asdf = 'asfd'; 
$sql = "INSERT INTO table (name) VALUES ('Phil')"; 
print_r($sql); 
$query =& new MySQLQuery($sql, $asdf); 
print_r($query);

This is wierd, is something wrong with your server or PHP?

ahundiak

I pasted your code into a file and ran it with no changes. And got the proper output.

ppowell

I honestly have NO idea what is going on but I got it to work with a total NON-OO solution (PHP 1, OO 0!!!):

if (!mysql_query($sql, $this->getDBConn())) {
 $this->setErrorArray(array($action => 'Could not insert new department: ' . mysql_error()));
}

Good ol' "mysql_query" wins out over MySQLQuery class.. but I do not understand whatsoever why the class loaded the parameters incorrectly ONLY on that one instance (in the case of the SQL statement being a specific INSERT)

Phil

renaun

Glad you found a solution.

For the record can give us the PHP version and server you are using that had the problem?

ppowell

PHP 4.3.2 on Red Hat 7.3

here is the oddity:

If I call this for the VERY FIRST RECORD:

$query =& new MySQLQuery($sql, $this->getDBConn());

The results of the object are:

$sql = Resource id #19
$this->mySQLConn = Resource id #19

HOWEVER.. if I insert any other records after the first one:

$sql = INSERT INTO department (department_name) VALUES ('Phil')
$this->mySQLConn = Resource id #19

In other words, the class object configures the parameters correctly after the 1st record is inserted; the 1st one is always wrong.

Phil

ppowell

Well here it is, the class itself in mostly its entirety... I just can't figure this out, and I'm deeply sorry..

class ActionPerformer extends DBActionPerformer {

  var $id;

  function ActionPerformer($id = '') {
	$this->id = $id;
  }

function add_dept() {																				// VOID (OR NULL) METHOD
		/*-----------------------------------------------------------------------------------------------------------------------
			This method will add a new department to the department table, since "department" is not a
			valid section it cannot be internally handled by "$this->save()" option inherited from 
			DBActionGenerator
		-------------------------------------------------------------------------------------------------------------------------*/
		global $_POST;
		foreach ($_POST as $key => $val) if (!isset(${$key})) ${$key} = $val;
		$this->connect();		// YOU INHERIT THIS METHOD FROM DBActionPerformer
		$sql = "SELECT id FROM department WHERE unique_key = '$unique_key'";
		$query =& new MySQLQuery($sql, $this->getDBConn());
		print_r("Query 1: "); print_r($query); print_r("<P>");
		$result =& $query->getResult();
		print_r("Query 2: "); print_r($query); print_r("<P>");
		if (@sizeof($result) > 0) {		// DUPLICATE ENTRY FOUND - CLOSE DB CONNECTION AND EXIT METHOD
		 $result = null;  $query = null;
		 $this->disconnect();
		 return null;
		}
		print_r("Query 3: "); print_r($query); print_r("<P>");
		$result = null; $query = null;
		print_r("Query 4: "); print_r($query); print_r("<P>");
		if (is_array($department_parent_id) && @sizeof($department_parent_id) > 0) {
		 foreach ($department_parent_id as $key => $val) {
		  $sql = 'INSERT INTO department (' .
			     ' department_name, department_parent_id, unique_key, record_entered ' .
			     ') VALUES (' .
			     "'" . mysql_escape_string($department_name) . "', " .
			     "$key, " .
			     "'$unique_key', " .
			     "'" . date('Y-m-d H:i:s') . "'" .
			     ')';
		   // HACK AS OF 2/18/2004: THIS SHOULD BE A CALL TO MySQLQuery CLASS INSTEAD.. I HAVE NO IDEA WHAT IS GOING ON! --Phil
		  $query =& new MySQLQuery($sql, $this->getDBConn());
		  print_r ("department_parent_id! "); print_r($query);
		   if (!mysql_query($sql, $this->getDBConn())) {
		    $this->setErrorArray(array($action => "Could not perform query: " . mysql_error()));
		    break;
		   }
		 }
		} else {
		print_r("Query 5: "); print_r($query); print_r("<P>");
		 $sql = 'INSERT INTO department (' .
			    ' department_name, unique_key, record_entered ' .
			    ') VALUES (' .
			    "'" . mysql_escape_string($department_name) . "', " .
			    "'$unique_key', " .
			    "'" . date('Y-m-d H:i:s') . "'" .
			    ')';
		   // HACK AS OF 2/18/2004: THIS SHOULD BE A CALL TO MySQLQuery CLASS INSTEAD.. I HAVE NO IDEA WHAT IS GOING ON! --Phil
		  print_r("sql = "); print_r($sql); print_r("<P>"); print_r("this->getDBConn() = "); print_r($this->getDBConn()); print_r("<P>");
		print_r("Query 6: "); print_r($query); print_r("<P>");
		  $query =& new MySQLQuery($sql, $this->getDBConn());
		print_r("Query 7: "); print_r($query); print_r("<P>");
		 if (!mysql_query($sql, $this->getDBConn())) $this->setErrorArray(array($action => "Could not perform query: " . mysql_error()));
		}
		$this->disconnect();
		print_r("Query 8: "); print_r($query); print_r("<P>");
	}

}

Please refer to the earlier code for MySQLQuery and for the record DBActionPerformer extends MethodGeneratorForActionPerformer which has the method setErrorArray(), just so you know..

Phil