[url] reg exp problem

section31

I was trying to allow url tags on my php site, and I'm having problems with this regular expression i'm developing. The problem is in this portion of the code - code=php?[/code]

It was my understanding that the ? would be greedy, but its not working like i intended. I'm trying to allow people to post code=php(/url)[/code] or code=php(/url)[/code] w/o it interfering with the replace. If anyone can find my problem....please let me know....I will be extremely grateful.

Thanks,
Dave

The Code is below...I didn't put it on here because it turned all funky on me.

http://imgod.us/temp/phpurlregexp.txt

dave420

What are you trying to do, exactly? Just match the square-bracketed URL tagss and change them into proper HTML?

Also, do you need the e modifier in there?

dave420

(Did you know your URL in your code doesn't start with [url]http://,[/url] so your pattern won't match it?)

Anyway, here's what I came up with for your problem:

$from="/\[url=(\"|')?(.+)\\1\](.*)\[\/url\]/Ui";
$to="<a href=\"\\2\">\\3</a>";
$parse=preg_replace($from, $to, $text);

The first quote is referenced in the pattern, so it'll match URLs that are contained either in a complete pair of quotes, or none either side, for uniformity. There's no protocol checking (http, ftp, whatever). It's also ungreedy, which is good, as if you have two URL tags on one line, it could get interesting :-P

did that help?

section31

Originally posted by dave420 What are you trying to do, exactly? Just match the square-bracketed URL tagss and change them into proper HTML?

If you don't know what i'm doing, just ignore the post...lol Why make things harder for yoursef.

Originally posted by dave420 If you don't know what
Also, do you need the e modifier in there?

Yes I need the e there, as you see i'm using conditionals in the replacement. Checking if they added a http or not....if not I add it to the begginning.

Can anyone else help?