UPDATE $count != display

[Kudose]

Using this script I wrote I get no output. Could someone tell me why?

<?
	 if (getenv ("HTTP_X_FORWARDED_FOR")) { 
  $ip = getenv ("HTTP_X_FORWARDED_FOR"); 
} else { 
  $ip = getenv ("REMOTE_ADDR"); 
} 
$lastline = exec( "ping $ip", $resultsArray ); 
for($i=0; $i < sizeof($resultsArray); $i++) 
{ 
        echo $resultsArray[$i] . '<br>'; 
}

$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$rows = mysql_num_rows($query) or die(mysql_error());
if($row == 1){
$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$what = mysql_fetch_assoc($query);
$count = $what['count'];
echo " $count ";
} else {
mysql_query("UPDATE counter SET ip='$ip'");
$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$fetch = mysql_fetch_assoc($query);
$count = $fetch['count'];
$count = $count+1;
mysql_query("UPDATE counter SET count='$count' WHERE ip='$ip'") or die(mysql_error());
echo "$count";
}
 ?>

Thanks!

[xmatthawkx]

Hi there,

It has something to do with this:

$lastline = exec( "ping $ip", $resultsArray ); 
for($i=0; $i < sizeof($resultsArray); $i++) 
{ 
        echo $resultsArray[$i] . '<br>'; 
} 

Your resultsArray is not being filled properly. Try using print_r() to print the results of that array and see if there's actually data.

[Kudose]

Still no dice using this:

<?
	 if (getenv ("HTTP_X_FORWARDED_FOR")) { 
  $ip = getenv ("HTTP_X_FORWARDED_FOR"); 
} else { 
  $ip = getenv ("REMOTE_ADDR"); 
} 

$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$rows = mysql_num_rows($query) or die(mysql_error());
if($row == 1){
$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$what = mysql_fetch_assoc($query);
$count = $what['count'];
echo " $count ";
} else {
mysql_query("UPDATE counter SET ip='$ip'");
$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$fetch = mysql_fetch_assoc($query);
$count = $fetch['count'];
$count = $count+1;
mysql_query("UPDATE counter SET count='$count' WHERE ip='$ip'") or die(mysql_error());
echo "$count";
}
 ?>

[Kudose]

Anyone got an idea?

[Weedpacket]

Is count a numeric field? If it is the value $count probably shouldn't be in quotes. Is count a reserved word? Might that be causing a problem? When increasing the count why do it in PHP - why not just UPDATE counter SET count=count+1 WHERE ip='$ip'?

If none of those are correct, what is the value of $ip?

[Kudose]

None of those fixed it. Here is my revised code:

<?
	 if (getenv ("HTTP_X_FORWARDED_FOR")) { 
  $ip = getenv ("HTTP_X_FORWARDED_FOR"); 
} else { 
  $ip = getenv ("REMOTE_ADDR"); 
}
$lastline = exec( "ping $ip", $resultsArray ); 
for($i=0; $i < sizeof($resultsArray); $i++) 
{ 
        echo "$resultsArray[$i] . '<br>'"; 
}  

include('dbinfo.inc.php');
$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$rows = mysql_num_rows($query) or die(mysql_error());
$what = mysql_fetch_array($query);
$cnt = $what['count'];
if($rows = '1'){
echo " $cnt ";
echo "$ip";
} else {
mysql_query("UPDATE counter SET ip='$ip'") or die(mysql_error());
mysql_query("UPDATE counter SET count=count+1 WHERE ip='$ip'") or die(mysql_error());
$count = $what['count'];
echo "$count";
}
 ?>

The value of $ip is the remote users IP. It chekcs the DB to see if it is in the table, if it is, then it displays the count, otherwise it adds the IP to the field and increments the count by one then displays it.

[Weedpacket]

Well, first of all, I can see nothing that would add the line; you've got an UPDATE, but UPDATE doesn't add records to a table, only changes the ones that are already there (the UPDATE in question will change every single record in the table, because it has no WHERE clause). My guess would be that that should be an INSERT.

There are a few other syntactic wobblies there as well.

[code=php]
<?
     if (getenv ("HTTP_X_FORWARDED_FOR")) { 
  $ip = getenv ("HTTP_X_FORWARDED_FOR"); 
} else { 
  $ip = getenv ("REMOTE_ADDR"); 
}
$lastline = exec( "ping $ip", $resultsArray ); 
for($i=0; $i < sizeof($resultsArray); $i++) 
{ 
        echo "$resultsArray[$i] . '<br>'"; 
}  

include('dbinfo.inc.php');

$query = mysql_query("SELECT `count`,ip FROM counter WHERE ip='$ip'") or die(mysql_error());
$rows = mysql_num_rows($query);
$what = mysql_fetch_array($query);
$cnt = $what['count'];
$ip = $what['i'];
if($rows == 1){
	mysql_query("UPDATE counter SET count=count+1 where ip='$ip'") or die(mysql_error());
	echo " ".($cnt+1)." $ip";
}
else
{
	mysql_query("INSERT INTO counter (`count`,ip) VALUES (1,'$ip')") or die(mysql_error());
	echo ' 1 '.$ip;
}
?>

[KevinMG]

i've run into similar problems, and it's usually just caused by a simple error in the code....when i ran into the problem (it took me a while to figure it out), the error reporting was disabled by default on the php installation....try setting the error reporting to E_ALL before you run the script...

error_reporting (E_ALL);

http://www.phpbuilder.com/manual/function.error-reporting.php

hope this helps...good luck!

[laserlight]

I think I answered your question here:
http://www.phpbuilder.com/board/showthread.php?s=&threadid=10268767