[Resolved] Output is null Scripting error?

Kudose

I am trying to make a counter. It pulls info from the DB. Basically it is going to insert the users IP into the DB and increment the count by one. If the users IP is the same as the last entered into the DB then it just returns the count. All of this in only one field. Here is my script. It doesnt output anything.

<?
	 if (getenv ("HTTP_X_FORWARDED_FOR")) { 
  $ip = getenv ("HTTP_X_FORWARDED_FOR"); 
} else { 
  $ip = getenv ("REMOTE_ADDR"); 
}
$lastline = exec( "ping $ip", $resultsArray ); 
for($i=0; $i < sizeof($resultsArray); $i++) 
{ 
        echo $resultsArray[$i] . '<br>'; 
}  

$query = mysql_query("SELECT * FROM counter WHERE ip='$ip'") or die(mysql_error());
$rows = mysql_num_rows($query) or die(mysql_error());
$what = mysql_fetch_array($query);
$cnt = $what['count'];
if($rows == 1){
echo " $cnt ";
} else {
mysql_query("UPDATE counter SET ip='$ip'");
$count = $what['count'];
$count = $count+1;
mysql_query("UPDATE counter SET count='$count'") or die(mysql_error());
echo "$count";
}
 ?>

Thanks in advance!

Kudose

Anyone know?

laserlight

<?php
//get the user's IP
if (getenv("HTTP_X_FORWARDED_FOR")) {
	$ip = getenv("HTTP_X_FORWARDED_FOR");
} else {
	$ip = getenv("REMOTE_ADDR");
}

//retrieve stored IP and count
$query = mysql_query("SELECT `ip`, `count` FROM `counter`")
	OR die(mysql_error());
$row = mysql_fetch_array($query);
$count = $row['count'];
//is the stored IP different from the user's IP?
if ($ip != $row['ip']) {
	$count++;
	//store the user's IP and set the incremented count
	mysql_query("UPDATE `counter` SET `ip`='$ip', `count`='$count'")
		OR die(mysql_error());
}
echo $count;
?>

I think the problem lies in that your table has only 1 row.
The way you are retrieving this row means that if no rows are returned, you get no count to work with.

I'm not too sure of the rationale of pining the IP address either, since likely the ping will be blocked.

Kudose

Thanks. 🙂