Problem creating directories with PHP

[silver5802]

Hi there.

I got a book called "PHP and MySQL Web Development" by Sams Publishing, and I am trying to build a mailing list like the one in the book.

I am trying to get PHP to create a new folder, this is the code they use in the book:

@ mkdir("archive/$list/$mailid", 0700);

then to double check if it was made or not, they check by doing this:

if (! mkdir("archive/$list/$mailid", 0700)){
do_html_footer();
exit;
}

I understand what they are doing when using that code, but i keep getting problems with it. I keep getting a message that says this:

Warning: mkdir(archive/1/2): No such file or directory in /home/stoplowb/public_html/MLM/upload.php on line 77

HELP ME, I AM PERPLEXED! I AM SURE IT IS EASY, BUT MY HEAD IS READY TO EXPLODE. PLEASE HELP ASAP!

[Kudose]

Try:

<?

if(!mkdir("/home/stoplowb/public_html/MLM/path/to/dir", 755)){
echo "Error";
} else {
echo "Success";
}

?>

[LordShryku]

You do realize that by doing that, you're executing the mkdir function twice, right?

[silver5802]

who is calling the mkdir function twice? me or the guy who posted after me?

[silver5802]

can anyone tell me the correct code to use? thank you.

[Kudose]

Try mine, then try his. I think mine is right.

[silver5802]

i think the main problem is that it cannot make the directory. i have the permissions set correctly ( i think), but it cannot make the directory with a variable in it. the following code works:

mkdir ("blank", 0777);

but mkdir("archive/$variable/$variable", 0777); will not work.

that is why the !mkdir double check is coming up with an error, because the file is not created. how can i create dynamically like i am supposed to in the book?😕

[Kudose]

Are you suppling your absolute path?

Try:

<? 

if(!mkdir("/home/username/public_html/archive/$list/$mailid", 755)){ 
echo "Error"; 
} else { 
echo "Success"; 
} 

?> 

Replace the dir username with your login name. By the way, how are you getting data to the $list and $mailid variables? Are you using a form to post this? Or you could always go the long route and mkdir then change dirs and mkdir again and some on for each variable. But that would suck.

Here is some good info too.

http://us2.php.net/manual/en/function.mkdir.php

[silver5802]

you would think this crap would finally work. but something is not right. i cannot figure this out. i replaced the code and get all this junk returned:

Warning: mkdir(/home/stoplowb/public_html/archive/1/3): No such file or directory in /home/stoplowb/public_html/MLM/upload.php on line 77
Error
Uploading scrollUPpictures.txt - 5034 bytes.

Warning: copy(archive/1/3/text.txt): failed to open stream: No such file or directory in /home/stoplowb/public_html/MLM/upload.php on line 140

Uploading spine.htm - 7866 bytes.

Warning: copy(archive/1/3/index.html): failed to open stream: No such file or directory in /home/stoplowb/public_html/MLM/upload.php on line 140

it will not make the file. i can make a file called "bob" or "blank" or "filenamehere", but i cannot create anything with the variables.

[silver5802]

its also telling me i do not have permission:

Warning: mkdir(/home/stoplowb/public_html/archive/): Permission denied in /home/stoplowb/public_html/MLM/upload.php on line 77

how do i not have permission creating a file when i am logged in as admin?

stoplowb is my admin name, and that is what i log into the database with. someone help before i throw my comptuer out the window.

[Kudose]

Here is the exact upload script I use on my site, you will need to modify it for your needs.

edit wrong thread /edit

[Kudose]

Post your script.

[silver5802]

here is the code:

<?
  // this functionality is in a separate file to allow us to be
  // more paranoid with it

  // if anything goes wrong, we will exit 

  $max_size = 50000;

  include ('include_fns.php');
  session_start();

  // only admin users can upload files
  if(!check_admin_user())
  {
    echo "You do not seem to be authorized to use this page.";
    exit;
  }

  // set up the admin toolbar buttons
  $buttons = array();
  $buttons[0] = 'change-password';
  $buttons[1] = 'create-list';
  $buttons[2] = 'create-mail';
  $buttons[3] = 'view-mail';
  $buttons[4] = 'log-out';
  $buttons[5] = 'show-all-lists';
  $buttons[6] = 'show-my-lists';
  $buttons[7] = 'show-other-lists';

  do_html_header("Stoplowbackpain.com Mailing List - Upload Files");

  display_toolbar($buttons);

  // check that the page is being called with the required data
  if(!$userfile_name[0]||!$userfile_name[1]||!$subject||!$list)
  {
      echo "Problem: You did not fill out the form fully. The images are the 
            only optional fields.  Each message needs a subject, text version 
            and an HTML version.";
      do_html_footer();
      exit;
  }

  if(!db_connect())
  {
     echo "<p>Could not connect to db"; 
     do_html_footer();
     exit;
  }

  // add mail details to the DB  

  $query = "insert into mail values (NULL, '$admin_user',
                                     '$subject',
                                     '$list',
                                     'STORED', NULL, NULL)";
  $result = mysql_query($query);
  if(!$result)   

  {   

    do_html_footer();  

    exit; 
  }

  //get the id MySQL assigned to this mail
  $mailid = mysql_insert_id();

  if(!$mailid)   

  {   

    do_html_footer();  

    exit; 
  }


  // creating directory will fail if this is not the first message archived  

  // that's ok
  @ mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 0700);

 if(!mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 700)){  

	echo "Error";  

	} else {  

	echo "Success";  

}  


  // iterate through the array of uploaded files
  $i = 0;
  while ($userfile[$i]&&$userfile[$i]!='none')
  {
    echo "<p>Uploading ".$userfile_name[$i]." - ";
    echo $userfile_size[$i]." bytes.<br>";
    if ($userfile_size[$i]==0)
    {
      echo "Problem: $userfile_name[$i] is zero length";
      $i++;
      continue;  

    }

if ($userfile_size[$i]>$max_size)
{
  echo "Problem: $userfile_name[$i] is over 10000 bytes";
  $i++;
  continue;  
}

// we would like to check that the uploaded image is an image
// if getimagesize() can work out its size, it probably is.
if($i>1&&!getimagesize($userfile[$i]))
{
  echo "Problem: $userfile_name[$i] is corrupt, or not a gif, jpeg or png";
  $i++;
  continue;  
}

// file 0 (the text message) and file 1 (the html message) are special cases
if($i==0) 
  $destination = "archive/$list/$mailid/text.txt";
else if($i == 1)
  $destination = "archive/$list/$mailid/index.html";
else
{
  $destination = "archive/$list/$mailid/".$userfile_name[$i];
  $query = "insert into images values ($mailid, 
                                       '".$userfile_name[$i]."',
                                       '".$userfile_type[$i]."')";
  $result = mysql_query($query);
}

//if we are using PHP version >= 4.03
/*
    if (!is_uploaded_file($userfile[$i]))
    { 
      // possible file upload attack detected
      echo "Something funny happening with '$userfile', not uploading.";
      do_html_footer();
      exit;
    }

move_uploaded_file($userfile[$i], $destination);
*/
    // if version <= 4.02
    copy ($userfile[$i], $destination);

unlink($userfile[$i]);

$i++;
  }

  display_preview_button($list, $mailid, 'preview-html');
  display_preview_button($list, $mailid, 'preview-text');
  display_button('send', "&id=$mailid");

  echo "<br><br><br><br><br>";
  do_html_footer();
?>

[silver5802]

any ideas?

[Kudose]

I am going to call these as I see it to help me from forgetting. So there will be another post after this one.

First change

// creating directory will fail if this is not the first message archived   

  // that's ok 
  @ mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 0700); 

 if(!mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 700)){   

    echo "Error";   

    } else {   

    echo "Success";   

}   

to this

mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 755) or die("Error");

I just made this script on my server and it made a testfolder just fine with CHMOD of 755

Also, you are defining $mailid but not $list. Also you should change your defining of $mailid to something like this

$fetch = mysql_query("SELECT * FROM mail WHERE admin_user='$admin_user'");

$row = mysql_fetch_array($fetch);

$mailid = $row['mailid'];
$list = $row['list'];

mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 755) or die("Error");

[silver5802]

none of this is working. any other ideas?

[Kudose]

This doesnt work?

<? 
  // this functionality is in a separate file to allow us to be 
  // more paranoid with it 

  // if anything goes wrong, we will exit 

  $max_size = 50000; 

  include ('include_fns.php'); 
  session_start(); 

  // only admin users can upload files 
  if(!check_admin_user()) 
  { 
    echo "You do not seem to be authorized to use this page."; 
    exit; 
  } 

  // set up the admin toolbar buttons 
  $buttons = array(); 
  $buttons[0] = 'change-password'; 
  $buttons[1] = 'create-list'; 
  $buttons[2] = 'create-mail'; 
  $buttons[3] = 'view-mail'; 
  $buttons[4] = 'log-out'; 
  $buttons[5] = 'show-all-lists'; 
  $buttons[6] = 'show-my-lists'; 
  $buttons[7] = 'show-other-lists'; 

  do_html_header("Stoplowbackpain.com Mailing List - Upload Files"); 

  display_toolbar($buttons); 

  // check that the page is being called with the required data 
   if(!$userfile_name[0]||!$userfile_name[1]||!$subje
ct||!$list) 
  { 
      echo "Problem: You did not fill out the form fully. The images are the 
            only optional fields.  Each message needs a subject, text version 
            and an HTML version."; 
      do_html_footer(); 
      exit; 
  } 

  if(!db_connect()) 
  { 
     echo "<p>Could not connect to db";  

     do_html_footer(); 
     exit; 
  } 

  // add mail details to the DB   

  $query = "insert into mail values (NULL, '$admin_user', 
                                     '$subject', 
                                     '$list', 
                                     'STORED', NULL, NULL)"; 
  $result = mysql_query($query); 
  if(!$result)    

  {    

    do_html_footer();   

    exit;  

  } 

  //get the id MySQL assigned to this mail 
$fetch = mysql_query("SELECT * FROM mail WHERE admin_user='$admin_user'"); 
$row = mysql_fetch_array($fetch); 
$mailid = $row['mailid']; 
$list = $row['list']; 

  if(!$mailid || !$list)    

  {    

    do_html_footer();   

    exit;  

  } 

 mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 755) or die("Error");  


  // iterate through the array of uploaded files 
  $i = 0; 
  while ($userfile[$i]&&$userfile[$i]!='none') 
  { 
    echo "<p>Uploading ".$userfile_name[$i]." - "; 
    echo $userfile_size[$i]." bytes.<br>"; 
    if ($userfile_size[$i]==0) 
    { 
      echo "Problem: $userfile_name[$i] is zero length"; 
      $i++; 
      continue;   

    } 

if ($userfile_size[$i]>$max_size) 
{ 
  echo "Problem: $userfile_name[$i] is over 10000 bytes"; 
  $i++; 
  continue;   
} 

// we would like to check that the uploaded image is an image 
// if getimagesize() can work out its size, it probably is. 
if($i>1&&!getimagesize($userfile[$i])) 
{ 
  echo "Problem: $userfile_name[$i] is corrupt, or not a gif, jpeg or png"; 
  $i++; 
  continue;   
} 

// file 0 (the text message) and file 1 (the html message) are special cases 
if($i==0)  
  $destination = "archive/$list/$mailid/text.txt"; 
else if($i == 1) 
  $destination = "archive/$list/$mailid/index.html"; 
else 
{ 
  $destination = "archive/$list/$mailid/".$userfile_name[$i]; 
  $query = "insert into images values ($mailid, 
                                       '".$userfile_name[$i]."', 
                                       '".$userfile_type[$i]."')"; 
  $result = mysql_query($query); 
} 

//if we are using PHP version >= 4.03 
/* 
    if (!is_uploaded_file($userfile[$i])) 
    { 
      // possible file upload attack detected 
      echo "Something funny happening with '$userfile', not uploading."; 
      do_html_footer(); 
      exit; 
    } 

move_uploaded_file($userfile[$i], $destination); 
*/ 
    // if version <= 4.02 
    copy ($userfile[$i], $destination); 

unlink($userfile[$i]); 

$i++; 
  } 

  display_preview_button($list, $mailid, 'preview-html'); 
  display_preview_button($list, $mailid, 'preview-text'); 
  display_button('send', "&id=$mailid"); 

  echo "<br><br><br><br><br>"; 
  do_html_footer(); 
?> 

What are your errors?

[silver5802]

no, it doesnt work.

when i do just this...:
mkdir("/home/stoplowb/public_html/archive", 0777);

i get this:
Warning: mkdir(/home/stoplowb/public_html/archive): Permission denied in /home/stoplowb/public_html/MLM/uploadyea.php on line 12

so now i dont have permission. i dont understand.

uploadyea.php is just a test file i have been working with to test the mkdir() function.

[silver5802]

and this:

mkdir("/home/stoplowb/public_html/archive/$list/$mailid", 755) or die("Error");

gives me a result of this:

Warning: mkdir(/home/stoplowb/public_html/archive/1/6): No such file or directory in /home/stoplowb/public_html/MLM/upload.php on line 74

there's no winning with this script.

[Kudose]

Is your absolute path

/home/stoplowb/public_html/

or

/home/stoplowb/public_html/MLM/

???

Is it pulling the right numbers for $mailid and $list?

Is anything right? lol

Try this:

$fetch = mysql_query("SELECT * FROM mail WHERE admin_user='$admin_user'");  

$row = mysql_fetch_array($fetch);  

$mailid = $row['mailid'];  

$list = $row['list'];  

  if(!$mailid || !$list)     

  {     

    do_html_footer();    

    exit;   

  }  

$dir = "/home/stoplowb/public_html/MLM/archive/$list/$mailid";
ftp_connect("www.stoplowbackpain.com", "username", "password");
$ftp = ftp_connect("www.stoplowbackpain.com", "username", "password");
ftp_pasv($ftp, true);
ftp_mkdir($ftp, $dir) or die("Error making $dir");
ftp_close($ftp);    

Lemme know the errors if any.