regex "no whitespace" \S trouble

Brendan_Nolan

How is it that:

<(([A-Z]+://)|(www.))[A-Z0-9-.]+.\S+>i

Will match www.example.com

but not www.example.com/?something=somevalue

It is KILLING me!

Weedpacket

Um; it does for me.

$r='<(([A-Z]+://)|(www\\.))[A-Z0-9-\\.]+\\.\\S+>i';

$u = 'www.example.com/?something=somevalue';

$t=preg_match($r,$u,$m);
if($t)print_r($m);

Array
(
    [0] => [url]www.example.com/?something=somevalue[/url]
    [1] => [url]www.[/url]
    [2] =>
    [3] => [url]www.[/url]
)

Brendan_Nolan

Right as always Weedpacket... my problem wasn't in the regular expression...

It must be in my preg_replace(), but I still don't see what I am doing wrong!

$input='text text text www.example.com/?something=somevalue text text';

$is_webs = preg_match_all('<(([A-Z]+://)|(www\.))[A-Z0-9-\.]+\.\S+>i', $input, $web_addys);
if ($is_webs == true){
  foreach ($web_addys[0] as $web_addy){
    $input = preg_replace("<".$web_addy.">", "<a href=\"".$web_addy."\" target=\"_blank\">".$web_addy."</a>", $input);
		}
}
echo $input;

Weedpacket

Yes, the hiccup is in the preg_replace. What's happening is that the matched URL (www.example.com/?something=somevalue, for example) is being interpreted as a regexp - with all the special interpretations that characters like . and ? have (so that example will match things like www!example.com/something=somevalue and www example comsomething=somevalue.

Three solutions to this:
1) use preg_quote() (though you'll probably need to check the regexp delimiters;
2) use str_replace() so that the string is interpreted as an ordinary string and not as a regexp,
3) replace the whole thing from preg_match_all down with

$input = preg_replace('<(([A-Z]+://)|(www\\.))[A-Z0-9-.]+\\.\\S+>i', "<a href=\"$0\" target=\"_blank\">$0</a>", $input);

Brendan_Nolan

Thanks, I think I might move onto str_replace... mostly because in the code that I am using I also test to see if they have a protocol at the front, because if they don't I automatically add [url]http://[/url] for obvoius reasons...

UNLESS it is possible to do this in the one liner preg_replace() that you mentioned?