while loop inside a function

[gotissues68]

Howdy-

I'm using the following code to create a select menu based on a mysql query.

function do_edit() {
$dbuser = ;
$dbpass = ;
$dbhost = ;
$db_link = mysql_connect($dbhost,$dbuser,$dbpass);
mysql_select_db(contentmanagement, $db_link) or die(mysql_error());
$query = mysql_query("select * from news");
echo "<select name=\"TargetField\">";
while ($dbrow = mysql_fetch_array($query) or die(mysql_error()))
{
echo "<OPTION>$dbrow[title]</OPTION>";
}
echo "</select>";
mysql_close($db_link);
}

And it works as expected until I get to the end of the while loop, anything beyond the end of the while doesn't get executed or printed I guess is more accurate. I've tried echo'ing and printing things to the screen after the end of the loop that don't have to do with query or script itself and they aren't being printed either. I had similar code working previously but lost it due to hardware failure and can't remember how I had it working. Any ideas appreciated.

Drew-

[peppeto]

Ok try this
<select name="TargetField">
<option selected value="">Choose something...
<?
$query ="SELECT * FROM news";
$result =mysql_query($query);
while ($row_news = mysql_fetch_array($result)) {

$news_id = $row_news["news_id"];
$title       = $row_news["title"];

if($TargetField== $news_id){
?>
<option selected value='<?=$news_id?>'>
<?=$title?>
</option>
<? } else { ?>
<option value='<?=$news_id?>'>
<?=$title?>
</option>
<?
}
}
?>

Hoope this helps

[gotissues68]

Come to think of it, thats what I was doing with my prior code and it works 😉 The problem I face now is though, why is the function prematurely ending at the end of the while loop and not continuing on? Anything after the end of the while, but before the closing brace of the function should still be executed but isn't and thats whats stumping me.

[gotissues68]

I fixed it rawr :o I hate it when I'm staring the answer in the face.

$db_link = mysql_connect($dbhost,$dbuser,$dbpass);
mysql_select_db(contentmanagement, $db_link) or die(mysql_error());
$query = mysql_query("select * from news");
echo "<select name=\"TargetField\">";
while ($dbrow = mysql_fetch_array($query)):
echo "<OPTION>$dbrow[title]</OPTION>";
endwhile;
echo "</form></select>";
mysql_close($db_link);

Instead of using the execution braces I used another way of invoking while and looping over the query doh