[Resolved] Preg Match Error... Simple problem, anyone got a quick solution? (Lines=problem)

Anidazen

I have a string which contains line breaks, and preg_match doesn't seem to work across a line break, is there any way I can work around this?

Cheers.

ftrudeau

$new_string = preg_replace("\n", "", $string);
that should do it.

Weedpacket

. won't match a newline unless you add the 's' modifier to the end of the regexp.

Anidazen

I've never understood reg expressions and im finding this very difficult, I can't make the expressions right..

Here is a sample of the page im trying to parse containing the info im trying to extract:

<tr><td width="95%" class="shotdata" valign="top">
MAGIC ITEM LORE ITEM NO DROP 
Slot: RANGE PRIMARY 
Skill: Piercing Atk Delay: 16 
DMG: 14 Dmg Bonus: 13 
CHA: +10 INT: +15 AGI: +12 HP: +55 MANA: +55 
SV MAGIC: +20 
Recommended level of 51. 
Effect: <a class="shot" href="/spell.html?id=1299"> Flowing Thought II</a> (Worn) 
WT: 1.0 Size: MEDIUM 
Class: NEC WIZ MAG ENC 
Race: ALL 
Slot 1, Type 4

</td></tr>

The red bits are the outside I don't need. Any help here? Is this number of newlines and quantity of text just too much for a reg expression?

Weedpacket

Originally posted by Anidazen
Is this number of newlines and quantity of text just too much for a reg expression?

Nope, but without seeing the expression you're trying to use we're kinda stuck.

Anidazen

Ok soz, heres expression:

preg_match('/(<table cellspacing="0" cellpadding="0" class="shotbg">.*<\/table>)/i', $itemstat, $matches);

At the time this is called $itemstat has been created like this:

$itemstat = fgets($fp, 128); //This bit works, so don't need to expand.

$itemstat = str_replace ( "\n", "", $itemstat); //Trying to remove lines
$itemstat = str_replace ( "\r", "", $itemstat); // Ditto

It still doesn't seem to find a match. $matches[1] is empty after calling. 🙁

Weedpacket

Originally posted by Anidazen
$itemstat = fgets($fp, 128); //This bit works, so don't need to expand.

You sure about that? fgets() stops reading the file as soon as it reaches a newline character.

<tr><td width="95%" class="shotdata" valign="top">
MAGIC ITEM LORE ITEM NO DROP 
Slot: RANGE PRIMARY 
Skill: Piercing Atk Delay: 16 
DMG: 14 Dmg Bonus: 13 
CHA: +10 INT: +15 AGI: +12 HP: +55 MANA: +55 
SV MAGIC: +20 
Recommended level of 51. 
Effect: <a class="shot" href="/spell.html?id=1299"> Flowing Thought II</a> (Worn) 
WT: 1.0 Size: MEDIUM 
Class: NEC WIZ MAG ENC 
Race: ALL 
Slot 1, Type 4 

</td></tr>

Well, to match the text between those highlighted parts the regexp would be

/<tr><td width="95%" class="shotdata" valign="top">(.*?)<\/td><\/tr>/is

Anidazen

Oh!

This would explain everything.. Except that echo $itemstats; showed whole page?

Thanks a lot, do you know any workaround for this - Im a relative newbie to PHP and need to use that function because I spoof a cookie in the headers...

Anidazen

I must seem like such a newbie... Is there a way to get this to work? fopen() and implode() (what I ususally use) can't be used for this because I need to send a cookie in the header.

Heres the code im trying to get to work.

$fp = fsockopen("lucy.allakhazam.com", 80, $errno, $errstr, 30);
if (!$fp) {
echo "$errstr ($errno) \n";
} else {
$out = "GET /item.html?id=28820 HTTP/1.1\r\n";
$out .= "Host: lucy.allakhazam.com\r\n";
$out.= "Cookie: LucySessionID=cookievalue\r\n";
$out .= "Connection: Close\r\n\r\n";

fputs($fp, $out);
while (!feof($fp)) {
$itemstat = fgets($fp, 128);

Any alternate method that would get the whole file would be much appreciated.

swr

while (!feof($fp)) {
$itemstat = fgets($fp, 128);

Try this instead of fgets:

$itemstat .= $fread($fp, 1000);

Note the ".=". The dot causes it to append to the end of $itemstat, instead of replacing the contents of $itemstat.

You could also use [man]file_get_contents[/man] which handles the fopen/fread/fclose process for you, but is only available in PHP 4.3.0 and newer.

Anidazen

YES!

Got it working!

Thanks very much to all those who helped.

Hehe I tried your change and I was getting really frustrated and ready to abandon the whole feature because I was getting an error I couldn't track down and it was getting really annoying.

I realised that it was $fread() not fread(), changed it, and its working perfectly.

Again, thanks very much.