whats wrong with this code?

chriswheat

Hello,

I am trying to make users the first time they log on change their defualt password so I have this at the top of my header page.

if ($request !== "/accounts/accounts.html" || $request !== "/accounts/accounts.html?" && $password == "defualt")
{
$new_url = "/accounts/accounts.html";
header("Location: $new_url");
}

from my understanding !== is not equal
and || is the same as or
and && means and

But this returns a parser error.

Any ideas on what is wrong and how to fix?

Chris

ethought

!= instead of !==

LordShryku

Looks ok. What line is returning the error? And is there a description of what it expects or what is wrong in the error?

Also, !== means strict not equal. Meaning it matches the value and the type. != just does value. Example:

$this = 3; 

if($this !== 3)   // false
if($this !== "3") // true
if($this != "3")  // false

chriswheat

So I retried it and it loops forever. I tried with both !== and !== both of them loop forever. Here is the code of the header file, witch is included on all pages including the accounts.html

Also if I remove the if statement and us a print "$request2";
it returns /accounts/accounts.html

<?PHP
session_start();
$request2 = $SERVER['REQUEST_URI'];
if ($good_login !== "yessir"){
$request2 = $SERVER['REQUEST_URI'];
$new_url = "http://www.myserver.com/login/?reason=Please Login&request=$request";
header("Location: $new_url");
}
if ($password == "defualt" && $request2 != "/accounts/accounts.html" || $request2 != "/accounts/accounts.html?")
{
$new_url = "http://www.myserver.com/accounts/accounts.html";
header("Location: $new_url");
}
include ("../db_connection.php");
?>

Why the loop? it should not change the header since the if statement says password must be defauld and page can not be /accounts/accounts.html

Chris

Weedpacket

What does $request equal? What is it supposed to equal? How is it set?

chriswheat

The if statement with $request2 is the issue.

$request2 is supposed to equal the $_SERVER['REQUEST_URI'];

thanks
Chris