Annoying 2 problems!

[Maleko]

I just cant work these out:

First, I have my admin section of a guestbook, to delete unwanted messages.

When i click the delete this message button, I want a popup box to confirm the action, so if i change my mind, i can click cancel, or yes to confirm delete, I have bene using loads of scripts, and cant get any working, they just have page errors, or just link back to the guestbook main page....

this is my echo code:

echo  "<title>Maleko: Online ::::Guest_Book_Admin::::</title><link href='style.css' rel='stylesheet' type='text/css'>
<table width='50%' border='0' align='center' cellpadding='0'cellspacing='0'>
  <tr>
      <td><img src='images/top.gif' width='100%' height='10' alt=''></td>
    </tr>
    <tr>
      <td> 
        <table width='100%' border='0' cellpadding='0' cellspacing='0'>
          <tr> 
            <td width='1' bgcolor='#000000'></td>
            <td width='475'><table width='100%' border='0' cellpadding='0' cellspacing='0'>
                <tr> 
                  <td><font size='1' face='verdana,arial'>Posted by: 
                    <font size='1' face='verdana,arial'>$name on $date</font></font></td>
                </tr>
                <tr> 
                  <td><font size='1' face='verdana,arial'>$message</font><br>
                    <br>
                  </td>
                </tr>
                <tr> 
                  <td>
<div align='right'>

                <table width='100%' border='0' cellspacing='0' cellpadding='0'>
                  <tr>
                    <td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$url<a href='$url'></a></font></td>
                    <td><div align='right'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>
//heres the delete part, $delete links to the var: $delete = 'guestbook.php?gb=del&id=$id';
<a href='$delete'>Delete 
                            this message</a></font></div></td>
                      </tr>
                    </table>
                    </div></td>
                </tr>
              </table>
            </td>
            <td width='1' bgcolor='#000000'></td>
          </tr>
        </table>
      </td>
    </tr>
    <tr>
      <td><img src='images/bottomgb.gif' width='100%' height='10' alt=''></td>
    </tr>
  </table><br>"
; 

I have tried putting javascript inside and outside the php...no luck, ive tried onclick codes, a form button with a form action, javascript....annoying me, the javascript just wont work inside the echo...what am i doing wrong?
Any ideas??

Also, secondly, I want to put the delete code in the same file as this...so i dont have to link to another file to delete the entry..how can i add it to the page? I did rea dsommit about actions??

all the code is:

mysql_query("DELETE FROM guestbook WHERE ID=$id"); 

Can anyone help? Its driving me mad!

[Maleko]

blar...

[nemonoman]

easiest way to do the confirm bit is to make a form with a button:

<form name=myform action=mydelete.php method=post onsubmit="return confirmdelete();">
<input type=text name=recordid>
<input type=submit name=deletethis value="Delete record">
</form>

<script>
function confirmdelete(){
return confirm("OK to delete this record?"😉
}
</script>

your script mydelete.php would be something like:

<? $recordid= $_POST['recordid'];
$result=mysql_query("DELETE FROM guestbook WHERE id=$recordid");
if($result){
echo "Deleted record $recordid";
}
else{
echo "couldn't delete record $reccordid";
}
?>

[jnutty1]

Place this code before the opening <table> tag:

<script language="javascript">
<!--
function confirmdel(){
var oPopup = window.createPopup();
var body=\"<center>Are you sure you want to delete this message?<br></center><input type='button' name='yes' value=' Yes ' onClick='parent.deleteit(this)'>\";
    body+=\"<input type='button' name='No' value=' No ' onClick='parent.deleteit(this)'>\";

  oPopupBody = oPopup.document.body;

  oPopupBody.innerHTML = body;
  oPopupBody.style.backgroundColor = '#ffffff';
  oPopupBody.style.border = '1 solid black';
  oPopupBody.style.fontSize = '12px';
//             x    y  width height
  oPopup.show(100, 200, 100, 50);
}

function deleteit(obj){
var objname=obj.name;
if (objname=='yes'){
   location.href='$delete';
}
if (objname=='no'){
   location.href='WhereYouWantToGo.htm';
// or SomeControl.focus();
}

}
// -->
</script>
   </head>

You will have to adjust the size,location and contents to your liking.

Also, you need to change this line from:

<a href='$delete'>Delete this message</a>

To

<a href='javascript:confirmdel();'>Delete this message</a>

or if you would like a button

<input type='button' name='del' onClick='confirmdel();' value=' Delete this message'>

Hope this helps.

[batman]

The most simplest way to do this is as follows:

Change this:

<a href='$delete'>Delete this message</a>

To:

<a href='$delete' onclick='return confirm('Are you sure you want to delete this message?')'>Delete this message</a>

[Maleko]

Sweet, thanks nemonoman, and to the others for the advice, some I had already tried before.

Just gotta do some cosmetic changed now, but works excellent, thanks!

By the way, is there any way to add my the delete script onto the same page as the viewing page? So i dont ave 2 files?

[nemonoman]

Sure like this. Your file dodelete.php gets set up like this:

<?
if($deletebutton){
//or for weedpacket's benefit
//if(isset($_POST['deletebutton'])){

$result=mysql_query("DELETE FROM etc....");
echo "You just deleted a record";
//etc
}
else{
echo "This page lets you delete a record";
//etc.
}

[Maleko]

How does that work in with my form etc?

[nemonoman]

It would look something like this:

<?
if($deletebutton){

$result=mysql_query("DELETE FROM etc....");
echo "You just deleted a record";
//etc
}
else{
echo "<title>Maleko: Online ::::Guest_Book_Admin::::</title><link href='style.css' rel='stylesheet' type='text/css'>
<table width='50%' border='0' align='center' cellpadding='0'cellspacing='0'>
<tr>
<td><img src='images/top.gif' width='100%' height='10' alt=''></td>
</tr>
<tr>
<td>
<table width='100%' border='0' cellpadding='0' cellspacing='0'>
<tr>
<td width='1' bgcolor='#000000'></td>
<td width='475'><table width='100%' border='0' cellpadding='0' cellspacing='0'>
<tr>
<td><font size='1' face='verdana,arial'>Posted by:
<font size='1' face='verdana,arial'>$name on $date</font></font></td>
</tr>
<tr>
<td><font size='1' face='verdana,arial'>$message</font><br>
<br>
</td>
</tr>
<tr>
<td>
<div align='right'>

                <table width='100%' border='0' cellspacing='0' cellpadding='0'> 
                  <tr> 
                    <td><font size='1' face='Verdana, Arial, Helvetica, sans-serif'>$url<a href='$url'></a></font></td> 
                    <td><div align='right'><font size='1' face='Verdana, Arial, Helvetica, sans-serif'> 

//heres the delete part, $delete links to the var: $delete = 'guestbook.php?gb=del&id=$id';
<a href='$delete'>Delete

this message</a></font></div></td>
</tr>
</table>
</div></td>
</tr>
</table>
</td>
<td width='1' bgcolor='#000000'></td>
</tr>
</table>
</td>
</tr>
<tr>
<td><img src='images/bottomgb.gif' width='100%' height='10' alt=''></td>
</tr>
</table><br>"
;

}
?>

[Maleko]

Cheers, just one final thing, if i enter a ID that doesnt exist to delete, it still says it deletes it....anyway of making it recognise, that if there isnt an entry an ID that doesnt exist yet, to say so?

[nemonoman]

[man]mysql_affected_rows[/man]

[nemonoman]

$result=mysql_query("DELETE FROM...etc.");
if($result){
//query ran ok
$rows=mysql_affected_rows;
if($rows){echo "DELETED $rows records";}
else {"Couldn't find any records to delete, gosh darnit!";}
else{
//query didn't run ok:
echo "Couldn't execute SQL query!"
}

[batman]

This:

$rows=mysql_affected_rows;

Should be:

$rows=mysql_affected_rows($result);

[nemonoman]

Well, Batman, I did screw up with the missing parens, but in fact, the ACTUAL code is

$rows=mysql_affected_rows();

NOT $rows=mysql_affected_rows($result);

mysql_affected_rows is different from mysql_num_rows($result) which requires the result resource as an argument and which returns the number of rows found with a given SELECT statement.

[batman]

Indeed. Trying to fix your mistake I made one of my own. I am used to typing like that and acidentaly worte it in. Sorry for confusion.

[batman]

Indeed. Trying to fix your mistake I made one of my own. I am used to typing like that and acidentaly worte it in. Sorry for confusion.

Should be:

$rows=mysql_affected_rows(); 🙂

[Maleko]

Im having problems using both the $result and the $rows...both messages are displayed, for example it can display this if a letter is entered:

Deleted Message #F (Thats for $rows)

Couldnt find row (Thats for $results)

It dispalyed both errors...