why isn't my if statement working

timmybuck

Hi guys,

Not sure my if statement is working it suppoosed to check that all certain fields are filled in before they are insterted in ot the database but it doesn't.

here is my code

can anyone see anything wrong. I can just put the forename in my form and submit it and it thanks me for submitting my details. It shouldnt do this.

<?php

// create short variable names

$forename=$POST['forename'];
$surname=$POST['surname'];
$age=$POST['age'];
$telephonenumber=$POST['telephonenumber'];
$email=$_POST['email'];

("$POST[forename]<br>$POST[surname]<br>$POST[age]<br>$POST[telephonenumber]<br>$_POST[email]");

if ((isset($POST['forename'])) && (isset($POST['surname'])) && (isset($POST['age'])) && (isset($POST['telephonenumber'])) && (isset($POST['email'])) )
{
$forename = addslashes($POST['forename']);
$surname = addslashes($POST['surname']);
$age = addslashes($POST['age']);
$telephonenumber = addslashes($POST['telephonenumber']);
$email = addslashes($POST['email']);

mysql_connect('localhost', 'phpuser', 'phpuser03')or die ("Database connection error");

mysql_select_db('booking');

$result = mysql_query("INSERT INTO customer (forename, surname, age, telephonenumber, email)
VALUES('$forename', '$surname', '$age', '$telephonenumber', '$email')")
OR DIE("Unable to insert record. Error: ".mysql_error());

print("Your record has been successfuly inserted.");

}else{

print("You have not entered all the required details.<br/> Please go back and try again.");

}
?>

yelvington

If an input exists in a form, a corresponding variable will be set, even if it is set to a null value.

So in your data-verification logic, you need to test whether the variable is null, not whether it has been set.

In other words, change

if ((isset($_POST['forename']))

if ($_POST['forename'])

and so forth.

timmybuck

if (($POST['forename']) &&($POST['surname']) &&($POST['age']) &&($POST['telephonenumber']) &&($_POST['email']) )

That gives me an error

Parse error: parse error, unexpected T_IF in

shadypalm88

Try this:

if (!empty($POST['forename']) && !empty($POST['surname']) && !empty($POST['age']) && !empty($POST['telephonenumber']) && !empty($_POST['email'])) {

Note that if any of these values can filled in with zeroes (0), this won't work right, and you'll also need to check that they're not 0.

timmybuck

Hi,

sorry but i get thsi message when i tired what u suggested. God knows why this isn't working.

Thanks for trying though

Parse error: parse error, unexpected T_IF in

shadypalm88

Here's the whole file, syntax was OK for me:

<?php
if (!empty($_POST['forename']) && !empty($_POST['surname']) && !empty($_POST['age']) && !empty($_POST['telephonenumber']) && !empty($_POST['email'])) {
	$forename = addslashes($_POST['forename']);
	$surname = addslashes($_POST['surname']);
	$age = addslashes($_POST['age']);
	$telephonenumber = addslashes($_POST['telephonenumber']);
	$email = addslashes($_POST['email']);

$db = @mysql_connect('localhost', 'phpuser', 'phpuser03') or die('Could not connect to the database: '.mysql_error());
@mysql_select_db('booking') or die('Could not select the database: '.mysql_error());
$result = mysql_query('INSERT INTO `customer` (`forename`, `surname`, `age`, `telephonenumber`, `email`)'.
	"VALUES ('$forename', '$surname', '$age', '$telephonenumber', $email')") or die('Unable to insert record. '.mysql_error());

echo 'Your record was successfully inserted.';
} else {
	echo 'You have not entered all the required details.<br />'."\n";
	echo 'Please go back and try again.';
}
?>

timmybuck

hey it works now i just copied and pasted what u did, perhaps i had got the order wrong or something, but there is one thing that still isnt working. when i fill in all the fields i get the error message

Unable to insert record. You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '')' at line 1

otherwise it seems to catch everything else

this is my code so far

<form action="results.php" methods="post">
<?php
include("/Program Files\Apache Group\Apache2\htdocs\m82\software_common.inc");

intrahead("E-tickets.co.uk"); //escapes writing the HTML header code
?>
<table width="63%" height="493" border="0" align="center" cellpadding="2" cellspacing="2" bgcolor="#FFFFFF">
<tr align="left" valign="top" bgcolor="#FFFFFF">
<td align="center" bgcolor="#FFFFFF">
<p align="justify"></p>
<p align="justify">
<?php
if (!empty($POST['forename']) && !empty($POST['surname']) && !empty($POST['age']) && !empty($POST['telephonenumber']) && !empty($POST['email'])) {
$forename = addslashes($POST['forename']);
$surname = addslashes($POST['surname']);
$age = addslashes($POST['age']);
$telephonenumber = addslashes($POST['telephonenumber']);
$email = addslashes($POST['email']);

$db = @mysql_connect('localhost', 'phpuser', 'phpuser03') or die('Could not connect to the database: '.mysql_error()); 
@mysql_select_db('booking') or die('Could not select the database: '.mysql_error()); 
$result = mysql_query('INSERT INTO `customer` (`forename`, `surname`, `age`, `telephonenumber`, `email`)'. 
    "VALUES ('$forename', '$surname', '$age', '$telephonenumber', $email')") or die('Unable to insert record. '.mysql_error()); 

echo 'Your record was successfully inserted.';

} else {
echo 'You have not entered all the required details.<br />'."\n";
echo 'Please go back and try again.';
}
?>

shadypalm88

Oops, I forgot a quote. The query line should read:

$result = mysql_query('INSERT INTO `customer` (`forename`, `surname`, `age`, `telephonenumber`, `email`)'.
        "VALUES ('$forename', '$surname', '$age', '$telephonenumber', '$email')") or die('Unable to insert record. '.mysql_error());

timmybuck

shadypalm88

thanks u ever so much it is working now