[Resolved] [Resolved] [Resolved] x and y array keys when using $_POST?

cgraz

I've got a form and I'm using a loop to run an insert into the database. Looks something like this:

   foreach($_POST as $key) {
      $keys[] = $key;
   }

   $query = "INSERT INTO $table (" . implode(",", $keys) . ")";
   $query .= " VALUES('" . implode("','", $_POST) . "')";

But for some strange reason, when I use print_r(), I'm getting to extra array values at the end of my array that aren't in my form.

The array keys for these two values are x and y, and they're not consistent (meaning they have different values if I go back and submit the form again). I've never seen this before, so just wondering what it is and what the best way to get rid of it is? Should I just use array_pop() twice?? Is there something I'm missing here?

Thanks,

Cgraz

batman

Your the moderator, you tell us. 🙂 J/K. I don't know what's goin' on with that. What kind of values is x and y returning to you?

cgraz

well, for some reason it stopped adding the x and y array keys, but I have no idea what these are or where they're coming from.

They were values like 76 and 14, or 82 and 12.

If anyone knows....Can I assume they won't show up again? I don't want to have to deal with issues of these user signup's not being inputted into the database if these x and y array keys occasionally decide to pop up.

And I know I'm the moderator...but I'm a bit rusty. You're batman. Shouldn't you be saving the day...for me?? 😃

Cgraz

AstroTeg

X and Y is the mouse coordinates upon submittal. Handy if you're working with an app that could make use of this info (like mapping apps, or online games, etc).

I know Mozilla likes to send this info along. I'm not sure if IE sends this or not.

Either way, a simple solution is to just check for X and Y in your foreach code...

batman

Or possibly another way to do it is, if you know the number of values the array will have which should remain the same all the time, then you could use array_pad() to set the exact number you want in the array. Since the x and y values are at the end they should be dropped.

$input = array(12, 10, 9);

$result = array_pad($input, 5, 0);
// result is array(12, 10, 9, 0, 0)

AstroTeg

Originally posted by batman
... Since the x and y values are at the end they should be dropped.

Assuming X and Y will be at the end is very dangerous. Its very possible another browser will send them as the first elements in the array. Its very possible PHP may re-order them.

Lobbing off the last two also doesn't make sense if you don't check to make sure they exist in the first place. Like cgraz said, sometimes they're there, sometimes they're not.

cgraz

astro: Can you help me error check for this? I can't seem to get it.

I just want to check if x and y are present and if they're not making sure the key nor value go into my INSERT query. I tried doing it in my foreach loop like you suggested but wasn't successful.

My PHP is REALLY rusty right now. It's been a good 6-8 months since I've done anything.

Cgraz

AstroTeg

What you have:

foreach($_POST as $key) {
      $keys[] = $key;
   }

   $query = "INSERT INTO $table (" . implode(",", $keys) . ")";
   $query .= " VALUES('" . implode("','", $_POST) . "')";

Part of the problem is you're imploding all of $_POST which normally is ok, but here you need to exclude some values (the X and Y).

There's several ways to do this...

$column = '';
$data = '';
foreach($_POST as $key => $value) 
{
  if(strtolower($key) != 'x' && strtolower($key) != 'y')
  {
    if($column != '')
      $column .= ', ';
    $column .= $key;

if($data != '')
  $data .= ', ';
$data .= "'" . $value . "'";
  }  // end if(strtolower($key) != 'x' && strtolower($key) != 'y')
}  // end foreach($_POST as $key => $value) 

$query = "INSERT INTO $table (" . $column . ") VALUES (" . $data . ")";

That's one way. Not overly graceful, but should work. Another way might be to just do a foreach and instead of building the SQL clauses like I did above, just have it store the form data in new variables (kind of what you did with $key). Then use implode. But swap out $_POST that you have with a variable you populate in the foreach() group. Make sense?

Doesn't look like PHP has a built in way to delete specific elements from an array (it has pop, but it deletes only from one end of the array). So in the end, you have to build your own...

cgraz

thanks man. That seems to work pretty well!

Yeah, I was searching php.net for a function to delete a line in an array if you knew the key, but didn't come up with one anywhere.

I appreciate the help. You just saved me hours of headaches!

Cgraz

And Batman, thanks for the help too. I had originally thought of just dropping the last two arrays also, but all these different browsers are unpredictable. Thanks for the fast response and the smart ass comment 😃

devinemke

um, i am missing something obvious here? can't you simply do:

unset ($_POST[_submit_x]);
unset ($_POST[_submit_y]);

substitue "submit" with whatever you named your submit button

AstroTeg

Yup, looks like unset will get the job done. For some reason I didn't see it in the list of array functions.