dude, what's the deal?

benkillin

the program keeps spiting out an error that makes no sense to me:

Warning: fclose(): supplied argument is not a valid stream resource in D:\Server Files\Xitami\webpages\phonebook.php on line 23

the code for that is:

	function add($name, $number, $file){
		$fp=fopen($file, "a");
//		$fp=flock($fp, LOCK_EX); //had to comment this because it kept giving errors
		$fp=fwrite($fp, $name.",".$number, 1024);
//		$fp=flock($fp, LOCK_UN); //had to comment this because it kept giving errors
		$fp=fclose($fp); //this is the line that spits that error out
		return true;
	}

the line that calls it is this:

$fh->add($_POST['name'], $_POST['number'], "phonebook.dat");

the html that sends the post vars is this:

<form name="bob" action="phonebook.php?write" method="post">
Name:<br />
<input name="name" type="text" /><br />
Phone Number:<br />
<input name = "number" type="text" /><br />
<input type="submit" value="Add to phonebook"/>
</form>

stfuji

did you check to see if the change was actually committed to the file. if so just put use

$fp=@fclose($fp);

to suppress the warning message.

-Geoffrey

benkillin

yes the change actually takes place with the file locks commented out, however that is not a good idea to leave them commented so I need to do more then suppress the message, I need to make the locks work too (the locks error's were the same:

Warning: fwrite(): supplied argument is not a valid stream resource in D:\Server Files\Xitami\webpages\phonebook.php on line 21

Warning: flock(): supplied argument is not a valid stream resource in D:\Server Files\Xitami\webpages\phonebook.php on line 22

Warning: fclose(): supplied argument is not a valid stream resource in D:\Server Files\Xitami\webpages\phonebook.php on line 23

aparently right after I do anything with the $fp directly after the file is opened, it stops working.

stfuji

did you try opening the file:

'a+'

instead of

'a'

benkillin

oh shite son!

I already did the a+, however that was not the problem. I was quite drunk at the time of writing this program, and I had each line setting the $fp off like so:

$fp=fopen($file, "a+");
$fp=flock($fp, LOCK_EX);
$fp=fwrite($fp, $name.",".$number."\r\n", 1024);
$fp=flock($fp, LOCK_UN);
$fp=fclose($fp);

when the correct method of writing to files is this:

$fp=fopen($file, "a+");
flock($fp, LOCK_EX);
fwrite($fp, $name.",".$number."\r\n", 1024);
flock($fp, LOCK_UN);
fclose($fp);

however, this did fix my problem, I have another question, how to I alphabetically sort the names to their numbers, this is my current displaying code:

function filelist($file){
		$link=file($file);
		$i=0;
		//$link=sort($link); //WILL NOT SORT, spits out error with it uncommented.
		echo "<table border='1'>";
		while($i<=sizeof($link) - 1){
			list($name, $number)=split(",", $link[$i]);//make the variables
			echo "<tr>
			<td>".$name."</td><td>".$number."</td>
			</tr>";
			$i++;
		}//loop to get the contents of the comma delimited file
		echo "</table>";	
		return true;
	}//function to read the PHONEBOOK

stfuji

so you have a resolution? I might add this one to my book of tricks as well if the second part is functional...

Thanks,
Geoffrey

benkillin

there's no trick about writing to files, just dont get drunk and try to code 😉

but my edit... I do need help with that.

[edit:]
scratch that... same mistake, it should not be $link = sort($link); it should be sort($link);

seriously, dont drink and code.