[Resolved] Testing for existing values and die

[mOk]

Hi,

I pull all the records from the db and then check against the POSTED email address whether it already exists in the db. If it does, then I want to die. But...

The test is passing everytime (so I can't add records anymore!!!).

(I know my select is working...)

$sql = "SELECT * FROM contacts";
$result = mysql_query($sql)
or die("SELECT Error: ".mysql_error());

while ($get_info = mysql_fetch_array($result, MYSQL_ASSOC))
{
if ($email = $get_info[email])
{
echo "Your email address already exists!";
die();
}
}

Thanks!

[yelvington]

email = $get_info[email]

Perhaps you intended to do a comparison. This is an assignment.

[broc7]

Do you have $email=$_POST["email"] on that page?

Your sql should be "SELECT email FROM contacts WHERE email = '$email'", or something like that. You only want to know if there's a record with the same email address, so that's why the WHERE clause.

Then if (mysql_fetch_row($result)) is true, meaning there's at least one record pulled, "Your email address already exists!"; You don't need a while statement, one record pulled is too many.

If you didn't set $email, that may explain why the test passes every time. $email and $get_info[email] may both be NULL. (It should be $get_info["email"].)

update: yelvington probably has the better explanation.

[mOk]

Yes!

I wanted to compare not assign. Thank you.

and Yes! that is brilliant let SELECT search the data...