How could i make this more efficient?

goatshideout

I wrote this little script to be able to show a single directory's contents and upload to it, and it has evolved into this thing i call DirPHP. It browses subdirectories as well and shows PHP source code, as well as color-codes different file types. I know Apache does this, but i wanted more functionality. It works all right (albeit, with fewer restrictions than I eventually will put in) but does anyone have any ideas on how I might make the code more efficient? It's pretty long so I just saved the syntax-highlighted source to a HTML file. Link's below, and anyone is free to use it if they feel like it. Thanks--

http://www.goatshideout.com/dirphp_source.htm

Moonglobe

didnt lok at it much, but a suggestion: might look into usign a seperate file to describe the filetypes; you're missing a lot and it'd be easier to have a seperate file config file.

goatshideout

Thanks for input. One goal here is to make a script that requires only one file to run but as I make this more and more complex I see the need for more than one file more and more.

planetsim

echo "<table width=\"100%\"  border=\"0\" cellspacing=\"0\" cellpadding=\"0\">\n";
echo "<tr style=\"background-color: #EEEEEE; font-weight: bold\"><td width=\"71%\" style=\"padding: 2px\">File</td><td width=\"90\" style=\"text-align:right; padding-right: 5px\">Size</td><td width=\"90\" style=\"text-align:right; padding-right: 5px\">Modified</td></tr>\n";

Why not make it easier and do this

echo '<table width="100%"  border="0" cellspacing="0" cellpadding="0">
<tr style="background-color: #EEEEEE; font-weight: bold"><td width="71%" style="padding: 2px">File</td><td width="90" style="text-align:right; padding-right: 5px">Size</td><td width="90" style="text-align:right; padding-right: 5px">Modified</td></tr>';

LordShryku

Why not make it even easier and not use php to echo it?

BuzzLY

In theory, I agree with you, LS, but I also like consistency. I would argue that since that echo is part of a larger piece of code where there are PHP variables being used, it looks cleaner to use PHP throughout rather than jump in and out of PHP code.

My suggestion would be to use the heredoc syntax. It's much cleaner, easier to read, and allows both ' and " characters to be used in your HTML.